All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Check for null pointer of pointer substream before dereferencing it
Date: Mon, 25 Apr 2022 07:53:37 +0200	[thread overview]
Message-ID: <s5h4k2hso7y.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220424205945.1372247-1-colin.i.king@gmail.com>

On Sun, 24 Apr 2022 22:59:45 +0200,
Colin Ian King wrote:
> 
> Pointer substream is being dereferenced on the assignment of pointer card
> before substream is being null checked with the macro PCM_RUNTIME_CHECK.
> Although PCM_RUNTIME_CHECK calls BUG_ON, it still is useful to perform the
> the pointer check before card is assigned.
> 
> Fixes: commit d4cfb30fce03 ("ALSA: pcm: Set per-card upper limit of PCM buffer allocations")
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied with the correction of Fixes tag.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Check for null pointer of pointer substream before dereferencing it
Date: Mon, 25 Apr 2022 07:53:37 +0200	[thread overview]
Message-ID: <s5h4k2hso7y.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220424205945.1372247-1-colin.i.king@gmail.com>

On Sun, 24 Apr 2022 22:59:45 +0200,
Colin Ian King wrote:
> 
> Pointer substream is being dereferenced on the assignment of pointer card
> before substream is being null checked with the macro PCM_RUNTIME_CHECK.
> Although PCM_RUNTIME_CHECK calls BUG_ON, it still is useful to perform the
> the pointer check before card is assigned.
> 
> Fixes: commit d4cfb30fce03 ("ALSA: pcm: Set per-card upper limit of PCM buffer allocations")
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied with the correction of Fixes tag.


Takashi

  reply	other threads:[~2022-04-25  5:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-24 20:59 [PATCH] ALSA: pcm: Check for null pointer of pointer substream before dereferencing it Colin Ian King
2022-04-25  5:53 ` Takashi Iwai [this message]
2022-04-25  5:53   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4k2hso7y.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=colin.i.king@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.