From: Takashi Iwai <tiwai@suse.de> To: "Gustavo A. R. Silva" <garsilva@embeddedor.com> Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Date: Fri, 30 Jun 2017 22:07:00 +0200 [thread overview] Message-ID: <s5h4lux5jff.wl-tiwai@suse.de> (raw) In-Reply-To: <20170630195901.GA5751@embeddedgus> On Fri, 30 Jun 2017 21:59:01 +0200, Gustavo A. R. Silva wrote: > > platform_get_irq() returns an error code, but the sata_rcar driver > ignores it and always returns -ENODEV. Which driver? A copy&paste error? Takashi > This is not correct, and > prevents -EPROBE_DEFER from being propagated properly. Also, > notice that platform_get_irq() no longer returns 0 on error. > > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > sound/x86/intel_hdmi_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c > index c19efc9..a095150 100644 > --- a/sound/x86/intel_hdmi_audio.c > +++ b/sound/x86/intel_hdmi_audio.c > @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) > /* get resources */ > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "Could not get irq resource\n"); > - return -ENODEV; > + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq); > + return irq; > } > > res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0); > -- > 2.5.0 > >
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: "Gustavo A. R. Silva" <garsilva@embeddedor.com> Cc: Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Date: Fri, 30 Jun 2017 22:07:00 +0200 [thread overview] Message-ID: <s5h4lux5jff.wl-tiwai@suse.de> (raw) In-Reply-To: <20170630195901.GA5751@embeddedgus> On Fri, 30 Jun 2017 21:59:01 +0200, Gustavo A. R. Silva wrote: > > platform_get_irq() returns an error code, but the sata_rcar driver > ignores it and always returns -ENODEV. Which driver? A copy&paste error? Takashi > This is not correct, and > prevents -EPROBE_DEFER from being propagated properly. Also, > notice that platform_get_irq() no longer returns 0 on error. > > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > sound/x86/intel_hdmi_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c > index c19efc9..a095150 100644 > --- a/sound/x86/intel_hdmi_audio.c > +++ b/sound/x86/intel_hdmi_audio.c > @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) > /* get resources */ > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "Could not get irq resource\n"); > - return -ENODEV; > + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq); > + return irq; > } > > res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0); > -- > 2.5.0 > >
next prev parent reply other threads:[~2017-06-30 20:07 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-30 19:59 [PATCH] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Gustavo A. R. Silva 2017-06-30 20:07 ` Takashi Iwai [this message] 2017-06-30 20:07 ` Takashi Iwai 2017-06-30 20:12 ` Gustavo A. R. Silva 2017-06-30 20:18 ` [PATCH v2] " Gustavo A. R. Silva 2017-06-30 20:27 ` Takashi Iwai 2017-06-30 20:27 ` Takashi Iwai 2017-06-30 20:31 ` Gustavo A. R. Silva 2017-06-30 20:39 ` Takashi Iwai 2017-06-30 20:39 ` Takashi Iwai 2017-06-30 20:41 ` Gustavo A. R. Silva 2017-06-30 20:41 ` Gustavo A. R. Silva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5h4lux5jff.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=garsilva@embeddedor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.