All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jian-Hong Pan <jhp@endlessos.org>
Cc: Takashi Iwai <tiwai@suse.com>, Kailang Yang <kailang@realtek.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux@endlessm.com
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887
Date: Wed, 07 Oct 2020 17:31:29 +0200	[thread overview]
Message-ID: <s5h5z7m129a.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201007052224.22611-1-jhp@endlessos.org>

On Wed, 07 Oct 2020 07:22:25 +0200,
Jian-Hong Pan wrote:
> 
> The ASUS D700SA desktop's audio (1043:2390) with ALC887 cannot detect
> the headset microphone and another headphone jack until
> ALC887_FIXUP_ASUS_HMIC and ALC887_FIXUP_ASUS_AUDIO quirks are applied.
> The NID 0x15 maps as the headset microphone and NID 0x19 maps as another
> headphone jack. Also need the function like alc887_fixup_asus_jack to
> enable the audio jacks.
> 
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> Signed-off-by: Kailang Yang <kailang@realtek.com>
> ---
> v2:
>  - Change the magic numbers to meaningful macros.
>  - Change snd_hda_codec_write to snd_hda_set_pin_ctl and
>    snd_hda_set_pin_ctl_cache accroding to Takashi's suggestion

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Jian-Hong Pan <jhp@endlessos.org>
Cc: alsa-devel@alsa-project.org, Kailang Yang <kailang@realtek.com>,
	linux@endlessm.com, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887
Date: Wed, 07 Oct 2020 17:31:29 +0200	[thread overview]
Message-ID: <s5h5z7m129a.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201007052224.22611-1-jhp@endlessos.org>

On Wed, 07 Oct 2020 07:22:25 +0200,
Jian-Hong Pan wrote:
> 
> The ASUS D700SA desktop's audio (1043:2390) with ALC887 cannot detect
> the headset microphone and another headphone jack until
> ALC887_FIXUP_ASUS_HMIC and ALC887_FIXUP_ASUS_AUDIO quirks are applied.
> The NID 0x15 maps as the headset microphone and NID 0x19 maps as another
> headphone jack. Also need the function like alc887_fixup_asus_jack to
> enable the audio jacks.
> 
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> Signed-off-by: Kailang Yang <kailang@realtek.com>
> ---
> v2:
>  - Change the magic numbers to meaningful macros.
>  - Change snd_hda_codec_write to snd_hda_set_pin_ctl and
>    snd_hda_set_pin_ctl_cache accroding to Takashi's suggestion

Thanks, applied.


Takashi

  reply	other threads:[~2020-10-07 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06  7:53 [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887 Jian-Hong Pan
2020-10-06  7:53 ` Jian-Hong Pan
2020-10-06 12:24 ` Takashi Iwai
2020-10-06 12:24   ` Takashi Iwai
2020-10-07  5:22   ` [PATCH v2] " Jian-Hong Pan
2020-10-07  5:22     ` Jian-Hong Pan
2020-10-07 15:31     ` Takashi Iwai [this message]
2020-10-07 15:31       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h5z7m129a.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jhp@endlessos.org \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.