From: Takashi Iwai <tiwai@suse.de>
To: "Thomas Meyer" <thomas@m3y3r.de>
Cc: <alsa-devel@alsa-project.org>, <perex@perex.cz>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast"
Date: Thu, 21 Sep 2017 10:00:01 +0200 [thread overview]
Message-ID: <s5ha81ocwhq.wl-tiwai@suse.de> (raw)
In-Reply-To: <1505975570447-568224618-4-diffsplit-thomas@m3y3r.de>
On Thu, 21 Sep 2017 08:33:46 +0200,
Thomas Meyer wrote:
>
> Remove casting the values returned by memory allocation functions like
> kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
> Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
No, this cast is still required because it has __user annotation.
It's not about compiler warning but about sparse.
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: alsa-devel@alsa-project.org, perex@perex.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast"
Date: Thu, 21 Sep 2017 10:00:01 +0200 [thread overview]
Message-ID: <s5ha81ocwhq.wl-tiwai@suse.de> (raw)
In-Reply-To: <1505975570447-568224618-4-diffsplit-thomas@m3y3r.de>
On Thu, 21 Sep 2017 08:33:46 +0200,
Thomas Meyer wrote:
>
> Remove casting the values returned by memory allocation functions like
> kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
> Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
No, this cast is still required because it has __user annotation.
It's not about compiler warning but about sparse.
thanks,
Takashi
next prev parent reply other threads:[~2017-09-21 8:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 6:33 [PATCH 0/4] Cocci spatch "alloc_cast" - v4.14-rc1 Thomas Meyer
2017-09-21 6:33 ` [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast" Thomas Meyer
2017-09-21 8:00 ` Takashi Iwai [this message]
2017-09-21 8:00 ` Takashi Iwai
2017-09-21 17:39 ` Al Viro
2017-09-21 17:39 ` Al Viro
2017-09-21 20:39 ` Takashi Iwai
2017-09-21 20:39 ` Takashi Iwai
2017-09-21 6:33 ` [PATCH 3/4] VFS: normal filesystems (and lustre): " Thomas Meyer
2017-09-21 6:33 ` [PATCH 1/4] drm/amd/powerplay: " Thomas Meyer
2017-09-21 6:55 ` Deucher, Alexander
2017-09-26 16:10 ` Alex Deucher
2017-09-26 16:10 ` Alex Deucher
2017-09-21 6:33 ` [PATCH 2/4] fs: " Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha81ocwhq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.