From: Takashi Iwai <tiwai@suse.de> To: "Ayman Bagabas" <ayman.bagabas@gmail.com> Cc: <alsa-devel@alsa-project.org>, "Hui Wang" <hui.wang@canonical.com>, "Andy Shevchenko" <andy@infradead.org>, "Darren Hart" <dvhart@infradead.org>, "Jaroslav Kysela" <perex@perex.cz>, "Kailang Yang" <kailang@realtek.com>, <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org> Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED Date: Fri, 09 Nov 2018 10:01:38 +0100 [thread overview] Message-ID: <s5hbm6y1v65.wl-tiwai@suse.de> (raw) In-Reply-To: <20181108171701.4444-4-ayman.bagabas@gmail.com> On Thu, 08 Nov 2018 18:16:55 +0100, Ayman Bagabas wrote: > > diff --git a/drivers/platform/x86/huawei_wmi.c b/drivers/platform/x86/huawei_wmi.c > index 658c44ab2126..f06aa967c311 100644 > --- a/drivers/platform/x86/huawei_wmi.c > +++ b/drivers/platform/x86/huawei_wmi.c > @@ -23,6 +23,7 @@ > #include <linux/input.h> > #include <linux/input/sparse-keymap.h> > #include <linux/module.h> > +#include <linux/platform_data/x86/huawei_wmi.h> > > MODULE_AUTHOR("Ayman Bagabas <ayman.bagabas@gmail.com>"); > MODULE_DESCRIPTION("Huawei WMI hotkeys"); > diff --git a/include/linux/platform_data/x86/huawei_wmi.h b/include/linux/platform_data/x86/huawei_wmi.h > new file mode 100644 > index 000000000000..dd251780ee5c > --- /dev/null > +++ b/include/linux/platform_data/x86/huawei_wmi.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > +#ifndef __HUAWEI_WMI_H__ > +#define __HUAWEI_WMI_H__ > + > +int huawei_wmi_micmute_led_set(bool on); > + > +#endif > +#endif These changes should belong to the WMI patch. > @@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MIC > }, > + [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_huawei_wmi > + }, > [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { > .type = HDA_FIXUP_PINS, > .v.pins = (const struct hda_pintbl[]) { > @@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = { > {0x1e, 0x411111f0}, > {0x21, 0x04211020}, > { } > - } > + }, > + .chained = true, > + .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED > }, > [ALC269_FIXUP_ASUS_X101_FUNC] = { > .type = HDA_FIXUP_FUNC, This means that ALC256_FIXUP_HUAWEI_MBXP_PINS performs both the pin config fixup and the mic-mute LED enablement. > @@ -6609,6 +6619,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > + SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED), > SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), > SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), ... and yet you add a new entry for performing only mic-mute LED. I guess the chaining is done wrongly above? thanks, Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Ayman Bagabas <ayman.bagabas@gmail.com> Cc: alsa-devel@alsa-project.org, Hui Wang <hui.wang@canonical.com>, Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>, Kailang Yang <kailang@realtek.com>, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED Date: Fri, 09 Nov 2018 10:01:38 +0100 [thread overview] Message-ID: <s5hbm6y1v65.wl-tiwai@suse.de> (raw) In-Reply-To: <20181108171701.4444-4-ayman.bagabas@gmail.com> On Thu, 08 Nov 2018 18:16:55 +0100, Ayman Bagabas wrote: > > diff --git a/drivers/platform/x86/huawei_wmi.c b/drivers/platform/x86/huawei_wmi.c > index 658c44ab2126..f06aa967c311 100644 > --- a/drivers/platform/x86/huawei_wmi.c > +++ b/drivers/platform/x86/huawei_wmi.c > @@ -23,6 +23,7 @@ > #include <linux/input.h> > #include <linux/input/sparse-keymap.h> > #include <linux/module.h> > +#include <linux/platform_data/x86/huawei_wmi.h> > > MODULE_AUTHOR("Ayman Bagabas <ayman.bagabas@gmail.com>"); > MODULE_DESCRIPTION("Huawei WMI hotkeys"); > diff --git a/include/linux/platform_data/x86/huawei_wmi.h b/include/linux/platform_data/x86/huawei_wmi.h > new file mode 100644 > index 000000000000..dd251780ee5c > --- /dev/null > +++ b/include/linux/platform_data/x86/huawei_wmi.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > +#ifndef __HUAWEI_WMI_H__ > +#define __HUAWEI_WMI_H__ > + > +int huawei_wmi_micmute_led_set(bool on); > + > +#endif > +#endif These changes should belong to the WMI patch. > @@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MIC > }, > + [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_huawei_wmi > + }, > [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { > .type = HDA_FIXUP_PINS, > .v.pins = (const struct hda_pintbl[]) { > @@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = { > {0x1e, 0x411111f0}, > {0x21, 0x04211020}, > { } > - } > + }, > + .chained = true, > + .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED > }, > [ALC269_FIXUP_ASUS_X101_FUNC] = { > .type = HDA_FIXUP_FUNC, This means that ALC256_FIXUP_HUAWEI_MBXP_PINS performs both the pin config fixup and the mic-mute LED enablement. > @@ -6609,6 +6619,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > + SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED), > SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), > SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), ... and yet you add a new entry for performing only mic-mute LED. I guess the chaining is done wrongly above? thanks, Takashi
next prev parent reply other threads:[~2018-11-09 9:01 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-08 17:16 [PATCH v3 0/3] Huawei laptops Ayman Bagabas 2018-11-08 17:16 ` [PATCH v3 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas 2018-11-08 19:58 ` Andy Shevchenko 2018-11-09 3:52 ` ayman.bagabas 2018-11-09 10:40 ` Andy Shevchenko 2018-11-08 17:16 ` [PATCH v3 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas 2018-11-09 8:55 ` Takashi Iwai 2018-11-09 8:55 ` Takashi Iwai 2018-11-08 17:16 ` [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas 2018-11-09 9:01 ` Takashi Iwai [this message] 2018-11-09 9:01 ` Takashi Iwai 2018-11-09 13:20 ` Ayman Bagabas 2018-11-09 13:28 ` Takashi Iwai 2018-11-19 23:57 ` Pavel Machek 2018-11-20 7:07 ` Takashi Iwai 2018-11-20 7:07 ` Takashi Iwai 2018-11-20 9:10 ` Pavel Machek 2018-11-20 9:23 ` Takashi Iwai 2018-11-20 9:36 ` Pavel Machek 2018-11-20 9:36 ` Pavel Machek 2018-11-20 9:49 ` Takashi Iwai 2018-11-20 11:51 ` Pavel Machek 2018-11-20 12:19 ` Takashi Iwai 2018-11-22 11:36 ` Andy Shevchenko 2018-11-22 13:18 ` Pavel Machek 2018-11-22 13:43 ` Takashi Iwai 2018-11-23 22:05 ` Pavel Machek 2018-11-23 22:05 ` Pavel Machek 2018-11-23 23:33 ` Pavel Machek 2018-11-23 23:33 ` Pavel Machek 2018-11-24 8:10 ` Takashi Iwai 2018-11-24 8:10 ` Takashi Iwai 2018-11-24 10:41 ` Pavel Machek 2018-11-22 13:12 ` Pavel Machek 2018-11-22 13:14 ` Takashi Iwai 2018-11-08 19:59 ` [PATCH v3 0/3] Huawei laptops Andy Shevchenko 2018-11-09 3:38 ` ayman.bagabas 2018-11-09 7:41 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5hbm6y1v65.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=andy@infradead.org \ --cc=ayman.bagabas@gmail.com \ --cc=dvhart@infradead.org \ --cc=hui.wang@canonical.com \ --cc=kailang@realtek.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.