From: Takashi Iwai <tiwai@suse.de>
To: "Ben Hutchings" <ben.hutchings@codethink.co.uk>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] ALSA: seq: Enable 'use' locking in all configurations
Date: Wed, 18 Oct 2017 08:03:10 +0200 [thread overview]
Message-ID: <s5hbml5xaap.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171017234549.cybzgf4yenbutbnp@xylophone.i.decadent.org.uk>
On Wed, 18 Oct 2017 01:45:49 +0200,
Ben Hutchings wrote:
>
> The 'use' locking macros are no-ops if neither SMP or SND_DEBUG is
> enabled. This might once have been OK in non-preemptible
> configurations, but even in that case snd_seq_read() may sleep while
> relying on a 'use' lock. So always use the proper implementations.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Yeah, this conditional build makes little sense nowadays although it
was meaningful in 20 years ago.
Applied now, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: seq: Enable 'use' locking in all configurations
Date: Wed, 18 Oct 2017 08:03:10 +0200 [thread overview]
Message-ID: <s5hbml5xaap.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171017234549.cybzgf4yenbutbnp@xylophone.i.decadent.org.uk>
On Wed, 18 Oct 2017 01:45:49 +0200,
Ben Hutchings wrote:
>
> The 'use' locking macros are no-ops if neither SMP or SND_DEBUG is
> enabled. This might once have been OK in non-preemptible
> configurations, but even in that case snd_seq_read() may sleep while
> relying on a 'use' lock. So always use the proper implementations.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Yeah, this conditional build makes little sense nowadays although it
was meaningful in 20 years ago.
Applied now, thanks.
Takashi
next prev parent reply other threads:[~2017-10-18 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 23:45 [PATCH] ALSA: seq: Enable 'use' locking in all configurations Ben Hutchings
2017-10-18 6:03 ` Takashi Iwai [this message]
2017-10-18 6:03 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbml5xaap.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.