From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Takashi Iwai" <tiwai@suse.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state
Date: Tue, 07 Jul 2020 11:55:17 +0200 [thread overview]
Message-ID: <s5hfta3ejju.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200629134737.105993-4-vkoul@kernel.org>
On Mon, 29 Jun 2020 15:47:37 +0200,
Vinod Koul wrote:
>
> On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING
> state, so set that for partially draining streams in
> snd_compr_drain_notify() and use a flag for partially draining streams
>
> While at it, add locks for stream state change in
> snd_compr_drain_notify() as well.
>
> Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)")
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Applied this one to for-linus branch (while other two are for 5.9), as
this is a fix.
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
linux-kernel@vger.kernel.org,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state
Date: Tue, 07 Jul 2020 11:55:17 +0200 [thread overview]
Message-ID: <s5hfta3ejju.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200629134737.105993-4-vkoul@kernel.org>
On Mon, 29 Jun 2020 15:47:37 +0200,
Vinod Koul wrote:
>
> On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING
> state, so set that for partially draining streams in
> snd_compr_drain_notify() and use a flag for partially draining streams
>
> While at it, add locks for stream state change in
> snd_compr_drain_notify() as well.
>
> Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)")
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Applied this one to for-linus branch (while other two are for 5.9), as
this is a fix.
thanks,
Takashi
next prev parent reply other threads:[~2020-07-07 9:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 13:47 [PATCH v5 0/3] ALSA: compress: Document stream states and fix gapless SM Vinod Koul
2020-06-29 13:47 ` Vinod Koul
2020-06-29 13:47 ` [PATCH v5 1/3] ALSA: compress: document the compress audio state machine Vinod Koul
2020-06-29 13:47 ` Vinod Koul
2020-07-07 9:54 ` Takashi Iwai
2020-07-07 9:54 ` Takashi Iwai
2020-06-29 13:47 ` [PATCH v5 2/3] ALSA: compress: document the compress gapless " Vinod Koul
2020-06-29 13:47 ` Vinod Koul
2020-07-07 9:54 ` Takashi Iwai
2020-07-07 9:54 ` Takashi Iwai
2020-06-29 13:47 ` [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state Vinod Koul
2020-06-29 13:47 ` Vinod Koul
2020-07-01 14:20 ` Charles Keepax
2020-07-01 14:20 ` Charles Keepax
2020-07-01 15:04 ` Vinod Koul
2020-07-01 15:04 ` Vinod Koul
2020-07-07 9:55 ` Takashi Iwai [this message]
2020-07-07 9:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfta3ejju.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.