From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Alex Deucher <alexander.deucher@amd.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org (moderated list:SOUND),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI
Date: Fri, 23 Oct 2020 13:34:25 +0200 [thread overview]
Message-ID: <s5himb189by.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201023102340.25494-2-kai.heng.feng@canonical.com>
On Fri, 23 Oct 2020 12:23:36 +0200,
Kai-Heng Feng wrote:
>
> @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev)
> __azx_runtime_suspend(chip);
> else
> pm_runtime_force_suspend(dev);
> - if (bus->irq >= 0) {
> - free_irq(bus->irq, chip);
> - bus->irq = -1;
> - chip->card->sync_irq = -1;
> - }
This release of irq has nothing to do with MSI. There has been PCI
controllers that assign to a different IRQ line after the resume.
> - if (azx_acquire_irq(chip, 1) < 0)
> - return -EIO;
Ditto.
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
tiwai@suse.com, Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI
Date: Fri, 23 Oct 2020 13:34:25 +0200 [thread overview]
Message-ID: <s5himb189by.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201023102340.25494-2-kai.heng.feng@canonical.com>
On Fri, 23 Oct 2020 12:23:36 +0200,
Kai-Heng Feng wrote:
>
> @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev)
> __azx_runtime_suspend(chip);
> else
> pm_runtime_force_suspend(dev);
> - if (bus->irq >= 0) {
> - free_irq(bus->irq, chip);
> - bus->irq = -1;
> - chip->card->sync_irq = -1;
> - }
This release of irq has nothing to do with MSI. There has been PCI
controllers that assign to a different IRQ line after the resume.
> - if (azx_acquire_irq(chip, 1) < 0)
> - return -EIO;
Ditto.
thanks,
Takashi
next prev parent reply other threads:[~2020-10-23 11:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 10:23 [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization Kai-Heng Feng
2020-10-23 10:23 ` Kai-Heng Feng
2020-10-23 10:23 ` [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI Kai-Heng Feng
2020-10-23 10:23 ` Kai-Heng Feng
2020-10-23 11:34 ` Takashi Iwai [this message]
2020-10-23 11:34 ` Takashi Iwai
2020-10-23 12:53 ` Kai-Heng Feng
2020-10-23 12:53 ` Kai-Heng Feng
2020-10-23 12:59 ` Takashi Iwai
2020-10-23 12:59 ` Takashi Iwai
2020-10-23 10:23 ` [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization Kai-Heng Feng
2020-10-23 10:23 ` Kai-Heng Feng
2020-10-23 11:36 ` Takashi Iwai
2020-10-23 11:36 ` Takashi Iwai
2020-10-23 13:02 ` Kai-Heng Feng
2020-10-23 13:02 ` Kai-Heng Feng
2020-10-23 15:31 ` kernel test robot
2020-10-23 15:31 ` kernel test robot
2020-10-23 15:31 ` kernel test robot
2020-10-23 10:23 ` [PATCH 4/4] ALSA: hda: Reinstate runtime_allow() for all hda controllers Kai-Heng Feng
2020-10-23 10:23 ` Kai-Heng Feng
2020-10-23 11:32 ` [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization Takashi Iwai
2020-10-23 11:32 ` Takashi Iwai
2020-10-23 12:44 ` Kai-Heng Feng
2020-10-23 12:44 ` Kai-Heng Feng
2020-10-23 13:04 ` Takashi Iwai
2020-10-23 13:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5himb189by.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=kai.heng.feng@canonical.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.