From: Takashi Iwai <tiwai@suse.de>
To: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: <virtualization@lists.linux-foundation.org>,
<alsa-devel@alsa-project.org>, <virtio-dev@lists.oasis-open.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors
Date: Sun, 28 Feb 2021 12:15:27 +0100 [thread overview]
Message-ID: <s5htupwjve8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210227085956.1700687-5-anton.yakovlev@opensynergy.com>
On Sat, 27 Feb 2021 09:59:51 +0100,
Anton Yakovlev wrote:
> +static int virtsnd_pcm_build_hw(struct virtio_pcm_substream *vss,
> + struct virtio_snd_pcm_info *info)
> +{
....
> + for (i = 0; i < ARRAY_SIZE(g_v2a_format_map); ++i)
> + if (values & (1ULL << i)) {
> + snd_pcm_format_t alsa_fmt = g_v2a_format_map[i];
> + int bytes = snd_pcm_format_physical_width(alsa_fmt) / 8;
> +
> + if (!sample_min || sample_min > bytes)
> + sample_min = bytes;
> +
> + if (sample_max < bytes)
> + sample_max = bytes;
> +
> + vss->hw.formats |= (1ULL << (__force int)alsa_fmt);
Please use pcm_format_to_bits().
> + /* Align the buffer size to the page size */
> + vss->hw.buffer_bytes_max =
> + (vss->hw.buffer_bytes_max + PAGE_SIZE - 1) & -PAGE_SIZE;
You can use PAGE_ALIGN() macro.
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, alsa-devel@alsa-project.org,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v6 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors
Date: Sun, 28 Feb 2021 12:15:27 +0100 [thread overview]
Message-ID: <s5htupwjve8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210227085956.1700687-5-anton.yakovlev@opensynergy.com>
On Sat, 27 Feb 2021 09:59:51 +0100,
Anton Yakovlev wrote:
> +static int virtsnd_pcm_build_hw(struct virtio_pcm_substream *vss,
> + struct virtio_snd_pcm_info *info)
> +{
....
> + for (i = 0; i < ARRAY_SIZE(g_v2a_format_map); ++i)
> + if (values & (1ULL << i)) {
> + snd_pcm_format_t alsa_fmt = g_v2a_format_map[i];
> + int bytes = snd_pcm_format_physical_width(alsa_fmt) / 8;
> +
> + if (!sample_min || sample_min > bytes)
> + sample_min = bytes;
> +
> + if (sample_max < bytes)
> + sample_max = bytes;
> +
> + vss->hw.formats |= (1ULL << (__force int)alsa_fmt);
Please use pcm_format_to_bits().
> + /* Align the buffer size to the page size */
> + vss->hw.buffer_bytes_max =
> + (vss->hw.buffer_bytes_max + PAGE_SIZE - 1) & -PAGE_SIZE;
You can use PAGE_ALIGN() macro.
thanks,
Takashi
next prev parent reply other threads:[~2021-02-28 11:16 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 8:59 [PATCH v6 0/9] ALSA: add virtio sound driver Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 1/9] uapi: virtio_ids: add a sound device type ID from OASIS spec Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 2/9] ALSA: virtio: add virtio sound driver Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 3/9] ALSA: virtio: handling control messages Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-28 11:04 ` Takashi Iwai
2021-02-28 11:04 ` Takashi Iwai
2021-02-28 18:39 ` Anton Yakovlev
2021-02-28 18:39 ` [virtio-dev] " Anton Yakovlev
2021-02-28 18:39 ` Anton Yakovlev
2021-02-28 18:39 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-28 11:15 ` Takashi Iwai [this message]
2021-02-28 11:15 ` Takashi Iwai
2021-02-27 8:59 ` [PATCH v6 5/9] ALSA: virtio: handling control and I/O messages for the PCM device Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-28 11:27 ` Takashi Iwai
2021-02-28 11:27 ` Takashi Iwai
2021-03-01 9:25 ` Anton Yakovlev
2021-03-01 9:25 ` [virtio-dev] " Anton Yakovlev
2021-03-01 9:25 ` Anton Yakovlev
2021-03-01 9:25 ` Anton Yakovlev
2021-03-01 13:32 ` Takashi Iwai
2021-03-01 13:32 ` Takashi Iwai
2021-03-01 14:47 ` Anton Yakovlev
2021-03-01 14:47 ` [virtio-dev] " Anton Yakovlev
2021-03-01 14:47 ` Anton Yakovlev
2021-03-01 14:47 ` Anton Yakovlev
2021-03-01 14:56 ` Takashi Iwai
2021-03-01 14:56 ` Takashi Iwai
2021-03-01 15:24 ` Anton Yakovlev
2021-03-01 15:24 ` [virtio-dev] " Anton Yakovlev
2021-03-01 15:24 ` Anton Yakovlev
2021-03-01 15:24 ` Anton Yakovlev
2021-03-01 15:30 ` Takashi Iwai
2021-03-01 15:30 ` Takashi Iwai
2021-02-27 8:59 ` [PATCH v6 6/9] ALSA: virtio: PCM substream operators Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-28 11:32 ` Takashi Iwai
2021-02-28 11:32 ` Takashi Iwai
2021-03-01 9:29 ` Anton Yakovlev
2021-03-01 9:29 ` [virtio-dev] " Anton Yakovlev
2021-03-01 9:29 ` Anton Yakovlev
2021-03-01 9:29 ` Anton Yakovlev
2021-03-01 13:33 ` Takashi Iwai
2021-03-01 13:33 ` Takashi Iwai
2021-02-27 8:59 ` [PATCH v6 7/9] ALSA: virtio: introduce jack support Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 8/9] ALSA: virtio: introduce PCM channel map support Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 9/9] ALSA: virtio: introduce device suspend/resume support Anton Yakovlev
2021-02-27 8:59 ` [virtio-dev] " Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-27 8:59 ` Anton Yakovlev
2021-02-28 12:05 ` Takashi Iwai
2021-02-28 12:05 ` Takashi Iwai
2021-03-01 10:03 ` Anton Yakovlev
2021-03-01 10:03 ` [virtio-dev] " Anton Yakovlev
2021-03-01 10:03 ` Anton Yakovlev
2021-03-01 10:03 ` Anton Yakovlev
2021-03-01 13:38 ` Takashi Iwai
2021-03-01 13:38 ` Takashi Iwai
2021-03-01 15:30 ` Anton Yakovlev
2021-03-01 15:30 ` [virtio-dev] " Anton Yakovlev
2021-03-01 15:30 ` Anton Yakovlev
2021-03-01 15:30 ` Anton Yakovlev
2021-03-02 6:29 ` Anton Yakovlev
2021-03-02 6:29 ` [virtio-dev] " Anton Yakovlev
2021-03-02 6:29 ` Anton Yakovlev
2021-03-02 6:29 ` Anton Yakovlev
2021-03-02 6:48 ` Takashi Iwai
2021-03-02 6:48 ` Takashi Iwai
2021-03-02 8:09 ` Anton Yakovlev
2021-03-02 8:09 ` [virtio-dev] " Anton Yakovlev
2021-03-02 8:09 ` Anton Yakovlev
2021-03-02 8:09 ` Anton Yakovlev
2021-03-02 9:11 ` Takashi Iwai
2021-03-02 9:11 ` Takashi Iwai
2021-03-02 15:35 ` Anton Yakovlev
2021-03-02 15:35 ` [virtio-dev] " Anton Yakovlev
2021-03-02 15:35 ` Anton Yakovlev
2021-03-02 15:35 ` Anton Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htupwjve8.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=anton.yakovlev@opensynergy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.