From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Jaroslav Kysela <perex@perex.cz>,
Jeremy Szu <jeremy.szu@canonical.com>,
Werner Sembach <wse@tuxedocomputers.com>,
Hui Wang <hui.wang@canonical.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Cameron Berkenpas <cam@neo-zeon.de>,
Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
Date: Wed, 30 Mar 2022 10:17:59 +0200 [thread overview]
Message-ID: <s5hwngbhn0o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220330061335.1015533-1-kai.heng.feng@canonical.com>
On Wed, 30 Mar 2022 08:13:33 +0200,
Kai-Heng Feng wrote:
>
> Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
> issue") is to solve recording issue met on AL236, by matching codec
> variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.
>
> This match can be too broad and Mi Notebook Pro 2020 is broken by the
> patch.
>
> Instead, use codec ID to be narrow down the scope, in order to make
> ALC256 unaffected.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
> Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
> Fix wrong comparison, || -> &&
Thanks, applied now.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: alsa-devel@alsa-project.org, Kailang Yang <kailang@realtek.com>,
kernel test robot <lkp@intel.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Jeremy Szu <jeremy.szu@canonical.com>,
linux-kernel@vger.kernel.org, tiwai@suse.com,
Werner Sembach <wse@tuxedocomputers.com>,
Hui Wang <hui.wang@canonical.com>, Sami Loone <sami@loone.fi>,
Cameron Berkenpas <cam@neo-zeon.de>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
Date: Wed, 30 Mar 2022 10:17:59 +0200 [thread overview]
Message-ID: <s5hwngbhn0o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220330061335.1015533-1-kai.heng.feng@canonical.com>
On Wed, 30 Mar 2022 08:13:33 +0200,
Kai-Heng Feng wrote:
>
> Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
> issue") is to solve recording issue met on AL236, by matching codec
> variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.
>
> This match can be too broad and Mi Notebook Pro 2020 is broken by the
> patch.
>
> Instead, use codec ID to be narrow down the scope, in order to make
> ALC256 unaffected.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
> Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
> Fix wrong comparison, || -> &&
Thanks, applied now.
Takashi
next prev parent reply other threads:[~2022-03-30 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 6:13 [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 Kai-Heng Feng
2022-03-30 6:13 ` Kai-Heng Feng
2022-03-30 8:17 ` Takashi Iwai [this message]
2022-03-30 8:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwngbhn0o.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=cam@neo-zeon.de \
--cc=dan.carpenter@oracle.com \
--cc=hui.wang@canonical.com \
--cc=jeremy.szu@canonical.com \
--cc=kai.heng.feng@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=perex@perex.cz \
--cc=sami@loone.fi \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.