From: Takashi Iwai <tiwai@suse.de>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Pavel Machek <pavel@denx.de>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ALSA: line6: add hw monitor volume control for POD HD500
Date: Mon, 13 Jul 2020 18:06:38 +0200 [thread overview]
Message-ID: <s5hwo37wga9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200713152852.65832-1-anarsoul@gmail.com>
On Mon, 13 Jul 2020 17:28:52 +0200,
Vasily Khoruzhick wrote:
>
> Add hw monitor volume control for POD HD500. The same change may
> work for HD500X but I don't have it to test.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> v4: add NULL check for kmalloc-ed buffer
> v3: - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
> - use GFP_KERNEL instead of GFP_ATOMIC for allocating a message
> - use lower case for float lookup table
> v2: clamp volume value to [0, ARRAY_SIZE() -1] in
> podhd_set_monitor_level()
Applied now. Thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: alsa-devel@alsa-project.org, Pavel Machek <pavel@denx.de>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: Re: [PATCH v4] ALSA: line6: add hw monitor volume control for POD HD500
Date: Mon, 13 Jul 2020 18:06:38 +0200 [thread overview]
Message-ID: <s5hwo37wga9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200713152852.65832-1-anarsoul@gmail.com>
On Mon, 13 Jul 2020 17:28:52 +0200,
Vasily Khoruzhick wrote:
>
> Add hw monitor volume control for POD HD500. The same change may
> work for HD500X but I don't have it to test.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> v4: add NULL check for kmalloc-ed buffer
> v3: - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
> - use GFP_KERNEL instead of GFP_ATOMIC for allocating a message
> - use lower case for float lookup table
> v2: clamp volume value to [0, ARRAY_SIZE() -1] in
> podhd_set_monitor_level()
Applied now. Thanks.
Takashi
next prev parent reply other threads:[~2020-07-13 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 15:28 [PATCH v4] ALSA: line6: add hw monitor volume control for POD HD500 Vasily Khoruzhick
2020-07-13 16:06 ` Takashi Iwai [this message]
2020-07-13 16:06 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwo37wga9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.