From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org, kailang@realtek.com
Subject: Re: [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
Date: Fri, 02 Mar 2018 09:59:45 +0100 [thread overview]
Message-ID: <s5hy3jahmym.wl-tiwai@suse.de> (raw)
In-Reply-To: <1519967136-8955-1-git-send-email-hui.wang@canonical.com>
On Fri, 02 Mar 2018 06:05:36 +0100,
Hui Wang wrote:
>
> With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
> ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
> ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
> by Kailang of Realtek and is verified on the machine.
>
> (This fixes the commit 3f2f7c55)
Please use "Fixes:" tag to indicate that.
> Cc: Kailang Yang <kailang@realtek.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Applied now, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, kailang@realtek.com, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
Date: Fri, 02 Mar 2018 09:59:45 +0100 [thread overview]
Message-ID: <s5hy3jahmym.wl-tiwai@suse.de> (raw)
In-Reply-To: <1519967136-8955-1-git-send-email-hui.wang@canonical.com>
On Fri, 02 Mar 2018 06:05:36 +0100,
Hui Wang wrote:
>
> With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
> ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
> ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
> by Kailang of Realtek and is verified on the machine.
>
> (This fixes the commit 3f2f7c55)
Please use "Fixes:" tag to indicate that.
> Cc: Kailang Yang <kailang@realtek.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Applied now, thanks.
Takashi
next prev parent reply other threads:[~2018-03-02 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 5:05 [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines Hui Wang
2018-03-02 8:59 ` Takashi Iwai [this message]
2018-03-02 8:59 ` Takashi Iwai
2018-03-03 12:38 ` [alsa-devel] " Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy3jahmym.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.