SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
* certbot patch
@ 2020-02-12  3:08 Russell Coker
  2020-02-16 15:32 ` Chris PeBenito
  0 siblings, 1 reply; 2+ messages in thread
From: Russell Coker @ 2020-02-12  3:08 UTC (permalink / raw)
  To: selinux-refpolicy

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

This patch against the git refpolicy adds a domain for the certbot client for 
letsencrypt.  This allows automatic renewal of certbot certificates.

-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/

[-- Attachment #2: certbot.diff --]
[-- Type: text/x-patch, Size: 5716 bytes --]

Index: refpolicy-2.20200209/policy/modules/services/certbot.fc
===================================================================
--- /dev/null
+++ refpolicy-2.20200209/policy/modules/services/certbot.fc
@@ -0,0 +1,4 @@
+/usr/bin/certbot	--	gen_context(system_u:object_r:certbot_exec_t,s0)
+/usr/bin/letsencrypt	--	gen_context(system_u:object_r:certbot_exec_t,s0)
+/var/log/letsencrypt(/.*)?	gen_context(system_u:object_r:certbot_log_t,s0)
+/var/lib/letsencrypt(/.*)?	gen_context(system_u:object_r:certbot_var_lib_t,s0)
Index: refpolicy-2.20200209/policy/modules/services/certbot.if
===================================================================
--- /dev/null
+++ refpolicy-2.20200209/policy/modules/services/certbot.if
@@ -0,0 +1,46 @@
+## <summary>SSL certificate requesting tool certbot AKA letsencrypt.</summary>
+
+########################################
+## <summary>
+##      Execute certbot/letsencrypt in the certbot
+##      domain.
+## </summary>
+## <param name="domain">
+##      <summary>
+##      Domain allowed to transition.
+##      </summary>
+## </param>
+#
+interface(`certbot_domtrans',`
+	gen_require(`
+		type certbot_t, certbot_exec_t;
+	')
+
+	domtrans_pattern($1, certbot_exec_t, certbot_t)
+')
+
+########################################
+## <summary>
+##      Execute certbot/letsencrypt in the certbot
+##      domain, and allow the specified role
+##      the firstboot domain.
+## </summary>
+## <param name="role">
+##      <summary>
+##      Role allowed access.
+##      </summary>
+## </param>
+## <param name="domain">
+##      <summary>
+##      Domain allowed to transition.
+##      </summary>
+## </param>
+#
+interface(`certbot_run',`
+	gen_require(`
+		type certbot_t;
+	')
+
+	certbot_domtrans($2)
+	role $1 types certbot_t;
+')
Index: refpolicy-2.20200209/policy/modules/services/certbot.te
===================================================================
--- /dev/null
+++ refpolicy-2.20200209/policy/modules/services/certbot.te
@@ -0,0 +1,99 @@
+policy_module(certbot, 1.0.0)
+
+########################################
+#
+# Declarations
+#
+
+type certbot_t;
+type certbot_exec_t;
+init_daemon_domain(certbot_t, certbot_exec_t)
+
+type certbot_log_t;
+logging_log_file(certbot_log_t)
+
+type certbot_var_run_t;
+files_pid_file(certbot_var_run_t)
+
+type certbot_tmp_t;
+files_tmp_file(certbot_tmp_t)
+
+type certbot_tmpfs_t;
+files_tmpfs_file(certbot_tmpfs_t)
+
+type certbot_var_lib_t;
+files_type(certbot_var_lib_t)
+
+########################################
+#
+# Local policy
+#
+
+allow certbot_t self:fifo_file { getattr ioctl read write };
+
+allow certbot_t self:capability { chown dac_override sys_resource };
+
+# this is for certbot to have write-exec memory, I know it is bad
+allow certbot_t self:process execmem;
+allow certbot_t certbot_tmp_t:file { map execute };
+allow certbot_t certbot_tmpfs_t:file { map execute };
+allow certbot_t certbot_var_run_t:file { map execute };
+
+kernel_search_fs_sysctls(certbot_t)
+
+allow certbot_t self:tcp_socket all_tcp_socket_perms;
+allow certbot_t self:netlink_route_socket create_netlink_socket_perms;
+corenet_tcp_bind_generic_node(certbot_t)
+corenet_tcp_connect_http_port(certbot_t)
+
+# bind to http port for standalone mode
+corenet_tcp_bind_http_port(certbot_t)
+
+allow certbot_t self:udp_socket all_udp_socket_perms;
+sysnet_read_config(certbot_t)
+files_read_etc_files(certbot_t)
+
+# for /usr/bin/x86_64-linux-gnu-gcc-8 why?
+corecmd_exec_bin(certbot_t)
+# for /usr/lib/gcc/x86_64-linux-gnu/8/collect2
+libs_exec_lib_files(certbot_t)
+
+libs_exec_ldconfig(certbot_t)
+
+apache_search_config(certbot_t)
+
+# for bin_t map
+corecmd_bin_entry_type(certbot_t)
+corecmd_list_bin(certbot_t)
+miscfiles_read_localization(certbot_t)
+
+miscfiles_read_generic_certs(certbot_t)
+miscfiles_manage_generic_tls_privkey_dirs(certbot_t)
+miscfiles_manage_generic_tls_privkey_files(certbot_t)
+miscfiles_manage_generic_tls_privkey_lnk_files(certbot_t)
+
+manage_files_pattern(certbot_t, certbot_var_run_t, certbot_var_run_t)
+files_pid_filetrans(certbot_t, certbot_var_run_t, file)
+
+logging_search_logs(certbot_t)
+allow certbot_t certbot_log_t:dir manage_dir_perms;
+allow certbot_t certbot_log_t:file manage_file_perms;
+
+files_search_var_lib(certbot_t)
+manage_dirs_pattern(certbot_t, certbot_var_lib_t, certbot_var_lib_t)
+manage_files_pattern(certbot_t, certbot_var_lib_t, certbot_var_lib_t)
+
+manage_files_pattern(certbot_t, certbot_tmp_t, certbot_tmp_t)
+files_tmp_filetrans(certbot_t, certbot_tmp_t, { file })
+
+manage_files_pattern(certbot_t, certbot_tmpfs_t, certbot_tmpfs_t)
+fs_tmpfs_filetrans(certbot_t, certbot_tmpfs_t, { file })
+
+domain_use_interactive_fds(certbot_t)
+userdom_use_user_ptys(certbot_t)
+userdom_dontaudit_search_user_home_dirs(certbot_t)
+
+optional_policy(`
+	# for writing to webroot
+	apache_manage_sys_content(certbot_t)
+')
Index: refpolicy-2.20200209/policy/modules/system/miscfiles.if
===================================================================
--- refpolicy-2.20200209.orig/policy/modules/system/miscfiles.if
+++ refpolicy-2.20200209/policy/modules/system/miscfiles.if
@@ -254,6 +254,26 @@ interface(`miscfiles_manage_generic_tls_
 
 ########################################
 ## <summary>
+##	Manage generic SSL/TLS private
+##	keys.
+## </summary>
+## <param name="domain">
+##	<summary>
+##	Domain allowed access.
+##	</summary>
+## </param>
+## <rolecap/>
+#
+interface(`miscfiles_manage_generic_tls_privkey_lnk_files',`
+	gen_require(`
+		type tls_privkey_t;
+	')
+
+	manage_lnk_files_pattern($1, tls_privkey_t, tls_privkey_t)
+')
+
+########################################
+## <summary>
 ##	Read fonts.
 ## </summary>
 ## <param name="domain">

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: certbot patch
  2020-02-12  3:08 certbot patch Russell Coker
@ 2020-02-16 15:32 ` Chris PeBenito
  0 siblings, 0 replies; 2+ messages in thread
From: Chris PeBenito @ 2020-02-16 15:32 UTC (permalink / raw)
  To: russell, selinux-refpolicy

On 2/11/20 10:08 PM, Russell Coker wrote:
> This patch against the git refpolicy adds a domain for the certbot client for
> letsencrypt.  This allows automatic renewal of certbot certificates.

Please inline the patch and add signed-off-by.

 > Index: refpolicy-2.20200209/policy/modules/services/certbot.fc
 > ===================================================================
 > --- /dev/null
 > +++ refpolicy-2.20200209/policy/modules/services/certbot.fc
 > @@ -0,0 +1,4 @@
 > +/usr/bin/certbot    -- 
gen_context(system_u:object_r:certbot_exec_t,s0)
 > +/usr/bin/letsencrypt    -- 
gen_context(system_u:object_r:certbot_exec_t,s0)
 > +/var/log/letsencrypt(/.*)? 
gen_context(system_u:object_r:certbot_log_t,s0)
 > +/var/lib/letsencrypt(/.*)? 
gen_context(system_u:object_r:certbot_var_lib_t,s0)
 > Index: refpolicy-2.20200209/policy/modules/services/certbot.if
 > ===================================================================
 > --- /dev/null
 > +++ refpolicy-2.20200209/policy/modules/services/certbot.if
 > @@ -0,0 +1,46 @@
 > +## <summary>SSL certificate requesting tool certbot AKA 
letsencrypt.</summary>
 > +
 > +########################################
 > +## <summary>
 > +##      Execute certbot/letsencrypt in the certbot
 > +##      domain.
 > +## </summary>
 > +## <param name="domain">
 > +##      <summary>
 > +##      Domain allowed to transition.
 > +##      </summary>
 > +## </param>
 > +#
 > +interface(`certbot_domtrans',`
 > +    gen_require(`
 > +        type certbot_t, certbot_exec_t;
 > +    ')
 > +
 > +    domtrans_pattern($1, certbot_exec_t, certbot_t)
 > +')
 > +
 > +########################################
 > +## <summary>
 > +##      Execute certbot/letsencrypt in the certbot
 > +##      domain, and allow the specified role
 > +##      the firstboot domain.
 > +## </summary>
 > +## <param name="role">
 > +##      <summary>
 > +##      Role allowed access.
 > +##      </summary>
 > +## </param>
 > +## <param name="domain">
 > +##      <summary>
 > +##      Domain allowed to transition.
 > +##      </summary>
 > +## </param>
 > +#
 > +interface(`certbot_run',`
 > +    gen_require(`
 > +        type certbot_t;
 > +    ')
 > +
 > +    certbot_domtrans($2)
 > +    role $1 types certbot_t;
 > +')
 > Index: refpolicy-2.20200209/policy/modules/services/certbot.te
 > ===================================================================
 > --- /dev/null
 > +++ refpolicy-2.20200209/policy/modules/services/certbot.te
 > @@ -0,0 +1,99 @@
 > +policy_module(certbot, 1.0.0)
 > +
 > +########################################
 > +#
 > +# Declarations
 > +#
 > +
 > +type certbot_t;
 > +type certbot_exec_t;
 > +init_daemon_domain(certbot_t, certbot_exec_t)
 > +
 > +type certbot_log_t;
 > +logging_log_file(certbot_log_t)
 > +
 > +type certbot_var_run_t;

Please rename to certbot_runtime_t.


 > +files_pid_file(certbot_var_run_t)
 > +
 > +type certbot_tmp_t;
 > +files_tmp_file(certbot_tmp_t)
 > +
 > +type certbot_tmpfs_t;
 > +files_tmpfs_file(certbot_tmpfs_t)
 > +
 > +type certbot_var_lib_t;
 > +files_type(certbot_var_lib_t)

I'm trying to get away from encoding the path into the type name. Please 
use certbot_lib_t or another name that makes more sense, if possible.


 > +########################################
 > +#
 > +# Local policy
 > +#
 > +
 > +allow certbot_t self:fifo_file { getattr ioctl read write };
 > +
 > +allow certbot_t self:capability { chown dac_override sys_resource };
 > +
 > +# this is for certbot to have write-exec memory, I know it is bad
 > +allow certbot_t self:process execmem;
 > +allow certbot_t certbot_tmp_t:file { map execute };
 > +allow certbot_t certbot_tmpfs_t:file { map execute };
 > +allow certbot_t certbot_var_run_t:file { map execute };
 > +
 > +kernel_search_fs_sysctls(certbot_t)
 > +
 > +allow certbot_t self:tcp_socket all_tcp_socket_perms;
 > +allow certbot_t self:netlink_route_socket create_netlink_socket_perms;
 > +corenet_tcp_bind_generic_node(certbot_t)
 > +corenet_tcp_connect_http_port(certbot_t)
 > +
 > +# bind to http port for standalone mode
 > +corenet_tcp_bind_http_port(certbot_t)
 > +
 > +allow certbot_t self:udp_socket all_udp_socket_perms;
 > +sysnet_read_config(certbot_t)
 > +files_read_etc_files(certbot_t)
 > +
 > +# for /usr/bin/x86_64-linux-gnu-gcc-8 why?
 > +corecmd_exec_bin(certbot_t)
 > +# for /usr/lib/gcc/x86_64-linux-gnu/8/collect2
 > +libs_exec_lib_files(certbot_t)
 > +
 > +libs_exec_ldconfig(certbot_t)
 > +
 > +apache_search_config(certbot_t)
 > +
 > +# for bin_t map
 > +corecmd_bin_entry_type(certbot_t)

There is a better interface that doesn't allow a bin_t entrypoint, 
corecmd_mmap_bin_files().


 > +miscfiles_read_localization(certbot_t)
 > +
 > +miscfiles_read_generic_certs(certbot_t)
 > +miscfiles_manage_generic_tls_privkey_dirs(certbot_t)
 > +miscfiles_manage_generic_tls_privkey_files(certbot_t)
 > +miscfiles_manage_generic_tls_privkey_lnk_files(certbot_t)
 > +
 > +manage_files_pattern(certbot_t, certbot_var_run_t, certbot_var_run_t)
 > +files_pid_filetrans(certbot_t, certbot_var_run_t, file)
 > +
 > +logging_search_logs(certbot_t)
 > +allow certbot_t certbot_log_t:dir manage_dir_perms;
 > +allow certbot_t certbot_log_t:file manage_file_perms;
 > +
 > +files_search_var_lib(certbot_t)
 > +manage_dirs_pattern(certbot_t, certbot_var_lib_t, certbot_var_lib_t)
 > +manage_files_pattern(certbot_t, certbot_var_lib_t, certbot_var_lib_t)
 > +
 > +manage_files_pattern(certbot_t, certbot_tmp_t, certbot_tmp_t)
 > +files_tmp_filetrans(certbot_t, certbot_tmp_t, { file })
 > +
 > +manage_files_pattern(certbot_t, certbot_tmpfs_t, certbot_tmpfs_t)
 > +fs_tmpfs_filetrans(certbot_t, certbot_tmpfs_t, { file })
 > +
 > +domain_use_interactive_fds(certbot_t)
 > +userdom_use_user_ptys(certbot_t)
 > +userdom_dontaudit_search_user_home_dirs(certbot_t)
 > +
 > +optional_policy(`
 > +    # for writing to webroot
 > +    apache_manage_sys_content(certbot_t)
 > +')

In general the style (line ordering) needs to be revised.


-- 
Chris PeBenito

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12  3:08 certbot patch Russell Coker
2020-02-16 15:32 ` Chris PeBenito

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org
	public-inbox-index selinux-refpolicy

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git