From: Ondrej Mosnacek <omosnace@redhat.com>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>,
Paul Moore <paul@paul-moore.com>,
SElinux list <selinux@vger.kernel.org>,
William Roberts <william.c.roberts@intel.com>
Subject: Re: [PATCH v2] ci: run SELinux kernel test suite
Date: Fri, 22 May 2020 09:40:29 +0200 [thread overview]
Message-ID: <CAFqZXNvc-J0=wpFnNzCxiq80e-hY=5Tubu84-KkPm5nAfgaYRQ@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdqnrPr32GW71aRgXu8akvMAu3FG5L7B2fp4GzBs0=_Z9g@mail.gmail.com>
On Thu, May 21, 2020 at 4:12 PM William Roberts
<bill.c.roberts@gmail.com> wrote:
> On Thu, May 21, 2020 at 7:58 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > On Thu, May 21, 2020 at 2:52 PM Stephen Smalley
> > <stephen.smalley.work@gmail.com> wrote:
[...]
> > > Last I looked, his script builds and installs the userspace code on
> > > top of the Fedora libraries and programs (make LIBDIR=... install...)
> > > and then runs the testsuite. That was my suggestion.
> >
> > Ah, yes, I can see that line now. Sorry, somehow I missed it before.
> >
> > > While it is the
> > > kernel testsuite, it exercises a lot of SELinux userspace
> > > functionality that isn't tested by the userspace tests.
> >
> > OK, I suppose it's better than nothing...
> >
>
> Stephen pointed out the additional ways userspace gets tested, and
> perhaps my title and description
> of the patch could be better. But the main point is to increase the
> test coverage
> and perform the testing steps we expect are done before a release in
> the CI. We should have
> the testing coverage and the confidence to release userspace from master at any
> point. We also have forward facing proof that tests are being executed
> and we can make sure
> nothing regresses.
>
> My ultimate goal here, is to help make sure that if Petr gets hit by a
> bus, releases will
> move forward without worry and without any change in quality among the various
> maintainers.
>
> Additionally, we pick up some cross project testing and can find other
> surprises.
Ah, so you want to move an integration test, which we would normally
run only before release, down to per-commit testing, which is fine
because it is quite fast... OK, it started to make sense to me now :)
If I find time I'll have a closer look at the scripts. I already see
some tiny possible improvements...
--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
next prev parent reply other threads:[~2020-05-22 7:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 15:14 Travis CI: Run selinux-testsuite bill.c.roberts
2020-05-19 15:14 ` [PATCH] ci: run SE Linux kernel test suite bill.c.roberts
2020-05-19 22:00 ` Paul Moore
2020-05-19 22:16 ` William Roberts
2020-05-19 22:23 ` Paul Moore
2020-05-20 15:13 ` William Roberts
2020-05-20 15:20 ` William Roberts
2020-05-19 21:41 ` Travis CI: Run selinux-testsuite Paul Moore
2020-05-20 16:34 ` [v2] " bill.c.roberts
2020-05-20 16:34 ` [PATCH v2] ci: run SELinux kernel test suite bill.c.roberts
2020-05-21 8:50 ` Ondrej Mosnacek
2020-05-21 12:52 ` Stephen Smalley
2020-05-21 12:58 ` Ondrej Mosnacek
2020-05-21 14:11 ` William Roberts
2020-05-22 7:40 ` Ondrej Mosnacek [this message]
2020-05-24 16:18 ` William Roberts
2020-05-29 13:24 ` Stephen Smalley
2020-05-29 15:33 ` William Roberts
2020-05-21 19:54 ` Nicolas Iooss
2020-05-21 20:52 ` William Roberts
2020-05-21 22:39 ` William Roberts
2020-05-22 19:07 ` Nicolas Iooss
2020-05-23 0:21 ` William Roberts
2020-05-29 18:42 ` Ondrej Mosnacek
2020-05-29 19:17 ` William Roberts
2020-05-20 16:56 ` [v2] Travis CI: Run selinux-testsuite Paul Moore
2020-06-02 19:18 ` [v3] " bill.c.roberts
2020-06-02 19:18 ` [PATCH v3] ci: run SELinux kernel test suite bill.c.roberts
2020-06-09 14:01 ` Stephen Smalley
2020-06-11 12:01 ` Petr Lautrbach
2020-06-11 12:12 ` William Roberts
2020-06-11 12:13 ` Ondrej Mosnacek
2020-06-11 12:14 ` Stephen Smalley
2020-06-11 12:15 ` William Roberts
2020-06-11 12:23 ` William Roberts
2020-06-11 14:05 ` [PATCH] ci: dont use hardcoded project name bill.c.roberts
2020-06-11 15:34 ` Petr Lautrbach
2020-06-11 15:55 ` Petr Lautrbach
2020-06-11 16:19 ` William Roberts
2020-06-11 16:44 ` William Roberts
2020-06-11 17:30 ` [PATCH v2] " bill.c.roberts
2020-06-12 5:39 ` Petr Lautrbach
2020-06-17 17:07 ` Stephen Smalley
2020-06-18 15:52 ` Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqZXNvc-J0=wpFnNzCxiq80e-hY=5Tubu84-KkPm5nAfgaYRQ@mail.gmail.com' \
--to=omosnace@redhat.com \
--cc=bill.c.roberts@gmail.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).