selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2] LSM: Ignore "security=" when "lsm=" is specified
       [not found] ` <5260689d-9016-bdf4-6070-13d2c88ac8a8@schaufler-ca.com>
@ 2019-02-17  5:16   ` Tetsuo Handa
  2019-02-18  2:45     ` Paul Moore
  0 siblings, 1 reply; 3+ messages in thread
From: Tetsuo Handa @ 2019-02-17  5:16 UTC (permalink / raw)
  To: SELinux, kernel-team
  Cc: Casey Schaufler, Kees Cook, James Morris, linux-security-module,
	linux-kernel

On 2019/02/14 1:05, Casey Schaufler wrote:
> On 2/12/2019 10:23 AM, Kees Cook wrote:
>> To avoid potential confusion, explicitly ignore "security=" when "lsm=" is
>> used on the command line, and report that it is happening.
>>
>> Suggested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Acked-by: Casey Schaufler <casey@schaufler-ca.com>
> 

The manual for TOMOYO was updated to follow this change.
SELinux folks and AppArmor folks, can we apply this change?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] LSM: Ignore "security=" when "lsm=" is specified
  2019-02-17  5:16   ` [PATCH v2] LSM: Ignore "security=" when "lsm=" is specified Tetsuo Handa
@ 2019-02-18  2:45     ` Paul Moore
  2019-02-18  3:57       ` Kees Cook
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Moore @ 2019-02-18  2:45 UTC (permalink / raw)
  To: Tetsuo Handa
  Cc: SELinux, kernel-team, Casey Schaufler, Kees Cook, James Morris,
	linux-security-module, linux-kernel

On Sun, Feb 17, 2019 at 12:17 AM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
> On 2019/02/14 1:05, Casey Schaufler wrote:
> > On 2/12/2019 10:23 AM, Kees Cook wrote:
> >> To avoid potential confusion, explicitly ignore "security=" when "lsm=" is
> >> used on the command line, and report that it is happening.
> >>
> >> Suggested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > Acked-by: Casey Schaufler <casey@schaufler-ca.com>
>
> The manual for TOMOYO was updated to follow this change.
> SELinux folks and AppArmor folks, can we apply this change?

My main concern is that "selinux={0|1}" continues to work as it has
for years.  It doesn't look like this affects that, but I can't say
I've dug into these changes very far.

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] LSM: Ignore "security=" when "lsm=" is specified
  2019-02-18  2:45     ` Paul Moore
@ 2019-02-18  3:57       ` Kees Cook
  0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2019-02-18  3:57 UTC (permalink / raw)
  To: Paul Moore
  Cc: Tetsuo Handa, SELinux, Ubuntu Kernel Team, Casey Schaufler,
	James Morris, linux-security-module, LKML

On Sun, Feb 17, 2019 at 6:46 PM Paul Moore <paul@paul-moore.com> wrote:
> My main concern is that "selinux={0|1}" continues to work as it has
> for years.  It doesn't look like this affects that, but I can't say
> I've dug into these changes very far.

Yup, no worries; it does. :)

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-18  3:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190212182318.GA16669@beast>
     [not found] ` <5260689d-9016-bdf4-6070-13d2c88ac8a8@schaufler-ca.com>
2019-02-17  5:16   ` [PATCH v2] LSM: Ignore "security=" when "lsm=" is specified Tetsuo Handa
2019-02-18  2:45     ` Paul Moore
2019-02-18  3:57       ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).