selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scripts/selinux: fix build
@ 2019-03-19 13:21 Stephen Smalley
  2019-03-19 17:05 ` Paul Moore
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Smalley @ 2019-03-19 13:21 UTC (permalink / raw)
  To: paul; +Cc: selinux, sfr, Stephen Smalley

We need to add the object tree include directory to the include path
for building mdp in order to pick up generated/autoconf.h. Otherwise,
make O=/path/to/objtree breaks.

Fixes: e37c1877ba5b ("scripts/selinux: modernize mdp")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
---
 scripts/selinux/mdp/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
index e9c92db7e2a3..8a1269a9d0ba 100644
--- a/scripts/selinux/mdp/Makefile
+++ b/scripts/selinux/mdp/Makefile
@@ -2,7 +2,7 @@
 hostprogs-y	:= mdp
 HOST_EXTRACFLAGS += \
 	-I$(srctree)/include/uapi -I$(srctree)/include \
-	-I$(srctree)/security/selinux/include
+	-I$(srctree)/security/selinux/include -I$(objtree)/include
 
 always		:= $(hostprogs-y)
 clean-files	:= policy.* file_contexts
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/selinux: fix build
  2019-03-19 13:21 [PATCH] scripts/selinux: fix build Stephen Smalley
@ 2019-03-19 17:05 ` Paul Moore
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2019-03-19 17:05 UTC (permalink / raw)
  To: Stephen Smalley; +Cc: selinux, sfr

On Tue, Mar 19, 2019 at 9:21 AM Stephen Smalley <sds@tycho.nsa.gov> wrote:
> We need to add the object tree include directory to the include path
> for building mdp in order to pick up generated/autoconf.h. Otherwise,
> make O=/path/to/objtree breaks.
>
> Fixes: e37c1877ba5b ("scripts/selinux: modernize mdp")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
>  scripts/selinux/mdp/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I wouldn't have thought this would be necessary, but evidently it is,
and thankfully we aren't the only ones doing this.  Merged to
selinux/next, thanks Stephen.

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-19 17:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 13:21 [PATCH] scripts/selinux: fix build Stephen Smalley
2019-03-19 17:05 ` Paul Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).