From: Paul Moore <paul@paul-moore.com>
To: James Morris <jmorris@namei.org>
Cc: Ondrej Mosnacek <omosnace@redhat.com>,
linux-security-module@vger.kernel.org,
"Serge E. Hallyn" <serge@hallyn.com>,
Casey Schaufler <casey@schaufler-ca.com>,
selinux@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
John Johansen <john.johansen@canonical.com>,
Kees Cook <keescook@chromium.org>,
Micah Morton <mortonm@chromium.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: [PATCH 1/2] selinux: treat atomic flags more carefully
Date: Fri, 10 Jan 2020 15:22:58 -0500 [thread overview]
Message-ID: <CAHC9VhTJ+s+AQPZ0dDdizfx62XO+cLZ76-8XntE209t6DL9H+Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.21.2001080644500.575@namei.org>
On Tue, Jan 7, 2020 at 2:46 PM James Morris <jmorris@namei.org> wrote:
> On Tue, 7 Jan 2020, Ondrej Mosnacek wrote:
>
> > The disabled/enforcing/initialized flags are all accessed concurrently
> > by threads so use the appropriate accessors that ensure atomicity and
> > document that it is expected.
> >
> > Use smp_load/acquire...() helpers (with memory barriers) for the
> > initialized flag, since it gates access to the rest of the state
> > structures.
> >
> > Note that the disabled flag is currently not used for anything other
> > than avoiding double disable, but it will be used for bailing out of
> > hooks once security_delete_hooks() is removed.
> >
> > Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
>
>
> Reviewed-by: James Morris <jamorris@linux.microsoft.com>
You get an extra helping of gratitude James for being the only one to
properly trim your reply ;)
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-01-10 20:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:31 [PATCH 0/2] LSM: Drop security_delete_hooks() Ondrej Mosnacek
2020-01-07 13:31 ` [PATCH 1/2] selinux: treat atomic flags more carefully Ondrej Mosnacek
2020-01-07 14:45 ` Stephen Smalley
2020-01-07 18:09 ` Kees Cook
2020-01-07 19:45 ` James Morris
2020-01-10 20:22 ` Paul Moore [this message]
2020-01-10 20:21 ` Paul Moore
2020-01-07 13:31 ` [PATCH 2/2] security,selinux: get rid of security_delete_hooks() Ondrej Mosnacek
2020-01-07 14:47 ` [PATCH 2/2] security, selinux: " Stephen Smalley
2020-01-08 5:31 ` Paul Moore
2020-01-08 8:15 ` Ondrej Mosnacek
2020-01-08 13:45 ` Paul Moore
2020-01-08 14:49 ` Stephen Smalley
2020-01-07 16:46 ` [PATCH 2/2] security,selinux: " Casey Schaufler
2020-01-07 18:10 ` Kees Cook
2020-01-07 19:59 ` James Morris
2020-01-08 8:21 ` Ondrej Mosnacek
2020-01-08 18:47 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhTJ+s+AQPZ0dDdizfx62XO+cLZ76-8XntE209t6DL9H+Q@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
--cc=omosnace@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).