* Re: [selinux] 66f8e2f03c: RIP:sidtab_hash_stats
[not found] <20191223091512.GL2760@shao2-debian>
@ 2019-12-23 14:37 ` Paul Moore
2019-12-23 21:37 ` Paul Moore
0 siblings, 1 reply; 3+ messages in thread
From: Paul Moore @ 2019-12-23 14:37 UTC (permalink / raw)
To: Jeff Vander Stoep
Cc: Stephen Smalley, Jovana Knezevic, LKML, selinux, lkp, kernel test robot
On Mon, Dec 23, 2019 at 4:15 AM kernel test robot <lkp@intel.com> wrote:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: 66f8e2f03c02e812002f8e9e465681cc62edda5b ("selinux: sidtab reverse lookup hash table")
> https://git.kernel.org/cgit/linux/kernel/git/pcmoore/selinux.git next
>
> ...
Jeff, please look into this. I suspect we may need to check
state->initialized in security_sidtab_hash_stats(...) (or similar).
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [selinux] 66f8e2f03c: RIP:sidtab_hash_stats
2019-12-23 14:37 ` [selinux] 66f8e2f03c: RIP:sidtab_hash_stats Paul Moore
@ 2019-12-23 21:37 ` Paul Moore
2019-12-23 23:04 ` Paul Moore
0 siblings, 1 reply; 3+ messages in thread
From: Paul Moore @ 2019-12-23 21:37 UTC (permalink / raw)
To: Jeff Vander Stoep
Cc: Stephen Smalley, Jovana Knezevic, LKML, selinux, lkp, kernel test robot
On Mon, Dec 23, 2019 at 9:37 AM Paul Moore <paul@paul-moore.com> wrote:
>
> On Mon, Dec 23, 2019 at 4:15 AM kernel test robot <lkp@intel.com> wrote:
> > FYI, we noticed the following commit (built with gcc-7):
> >
> > commit: 66f8e2f03c02e812002f8e9e465681cc62edda5b ("selinux: sidtab reverse lookup hash table")
> > https://git.kernel.org/cgit/linux/kernel/git/pcmoore/selinux.git next
> >
> > ...
>
> Jeff, please look into this. I suspect we may need to check
> state->initialized in security_sidtab_hash_stats(...) (or similar).
I realized that Jeff may very well be on a holiday so I took a closer
look and this does appear to be the/a problem. If you try to "cat
/sys/fs/selinux/ss/sidtab_hash_stats" on a system where the policy
hasn't been loaded it blows up in a bad way. I'll write up a fix
right now and post it as soon as I've verified it fixes the problem.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [selinux] 66f8e2f03c: RIP:sidtab_hash_stats
2019-12-23 21:37 ` Paul Moore
@ 2019-12-23 23:04 ` Paul Moore
0 siblings, 0 replies; 3+ messages in thread
From: Paul Moore @ 2019-12-23 23:04 UTC (permalink / raw)
To: Jeff Vander Stoep
Cc: Stephen Smalley, Jovana Knezevic, LKML, selinux, lkp, kernel test robot
On Mon, Dec 23, 2019 at 4:37 PM Paul Moore <paul@paul-moore.com> wrote:
> On Mon, Dec 23, 2019 at 9:37 AM Paul Moore <paul@paul-moore.com> wrote:
> > On Mon, Dec 23, 2019 at 4:15 AM kernel test robot <lkp@intel.com> wrote:
> > > FYI, we noticed the following commit (built with gcc-7):
> > >
> > > commit: 66f8e2f03c02e812002f8e9e465681cc62edda5b ("selinux: sidtab reverse lookup hash table")
> > > https://git.kernel.org/cgit/linux/kernel/git/pcmoore/selinux.git next
> > >
> > > ...
> >
> > Jeff, please look into this. I suspect we may need to check
> > state->initialized in security_sidtab_hash_stats(...) (or similar).
>
> I realized that Jeff may very well be on a holiday so I took a closer
> look and this does appear to be the/a problem. If you try to "cat
> /sys/fs/selinux/ss/sidtab_hash_stats" on a system where the policy
> hasn't been loaded it blows up in a bad way. I'll write up a fix
> right now and post it as soon as I've verified it fixes the problem.
Fix posted (see archive link below) and merged into selinux/next.
Thanks for the problem report test robot!
https://lore.kernel.org/selinux/157714208320.505827.13006028554511851520.stgit@chester
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-23 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191223091512.GL2760@shao2-debian>
2019-12-23 14:37 ` [selinux] 66f8e2f03c: RIP:sidtab_hash_stats Paul Moore
2019-12-23 21:37 ` Paul Moore
2019-12-23 23:04 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).