* [PATCH] soc: tegra: fix CPU_BIG_ENDIAN dependencies
@ 2022-12-15 16:53 Arnd Bergmann
2022-12-16 13:20 ` Thierry Reding
2022-12-19 16:00 ` patchwork-bot+linux-soc
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2022-12-15 16:53 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Arnd Bergmann
Cc: soc, Sumit Gupta, Petlozu Pravareshwar, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
My previous patch to prevent BPMP from being enabled on big
endian kernels caused a build regression:
WARNING: unmet direct dependencies detected for TEGRA_BPMP
Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y]
Selected by [y]:
- ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
Add even more such dependencies for the SoC types that use
the BPMP driver.
Fixes: 4ddb1bf1a837 ("tegra: mark BPMP driver as little-endian only")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/tegra/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 5f5324294636..3658fb0f0c5b 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -95,6 +95,7 @@ config ARCH_TEGRA_210_SOC
config ARCH_TEGRA_186_SOC
bool "NVIDIA Tegra186 SoC"
+ depends on !CPU_BIG_ENDIAN
select MAILBOX
select TEGRA_BPMP
select TEGRA_HSP_MBOX
@@ -110,6 +111,7 @@ config ARCH_TEGRA_186_SOC
config ARCH_TEGRA_194_SOC
bool "NVIDIA Tegra194 SoC"
+ depends on !CPU_BIG_ENDIAN
select MAILBOX
select PINCTRL_TEGRA194
select TEGRA_BPMP
@@ -121,6 +123,7 @@ config ARCH_TEGRA_194_SOC
config ARCH_TEGRA_234_SOC
bool "NVIDIA Tegra234 SoC"
+ depends on !CPU_BIG_ENDIAN
select MAILBOX
select TEGRA_BPMP
select TEGRA_HSP_MBOX
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: tegra: fix CPU_BIG_ENDIAN dependencies
2022-12-15 16:53 [PATCH] soc: tegra: fix CPU_BIG_ENDIAN dependencies Arnd Bergmann
@ 2022-12-16 13:20 ` Thierry Reding
2022-12-19 16:00 ` patchwork-bot+linux-soc
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2022-12-16 13:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jonathan Hunter, Arnd Bergmann, soc, Sumit Gupta,
Petlozu Pravareshwar, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Thu, Dec 15, 2022 at 05:53:21PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> My previous patch to prevent BPMP from being enabled on big
> endian kernels caused a build regression:
>
> WARNING: unmet direct dependencies detected for TEGRA_BPMP
> Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y]
> Selected by [y]:
> - ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
> - ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
> - ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
>
> Add even more such dependencies for the SoC types that use
> the BPMP driver.
>
> Fixes: 4ddb1bf1a837 ("tegra: mark BPMP driver as little-endian only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/tegra/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
Do you want to pick this up into ARM SoC directly? If so:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: tegra: fix CPU_BIG_ENDIAN dependencies
2022-12-15 16:53 [PATCH] soc: tegra: fix CPU_BIG_ENDIAN dependencies Arnd Bergmann
2022-12-16 13:20 ` Thierry Reding
@ 2022-12-19 16:00 ` patchwork-bot+linux-soc
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-soc @ 2022-12-19 16:00 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: soc
Hello:
This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:
On Thu, 15 Dec 2022 17:53:21 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> My previous patch to prevent BPMP from being enabled on big
> endian kernels caused a build regression:
>
> WARNING: unmet direct dependencies detected for TEGRA_BPMP
> Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y]
> Selected by [y]:
> - ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
> - ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
> - ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
>
> [...]
Here is the summary with links:
- soc: tegra: fix CPU_BIG_ENDIAN dependencies
https://git.kernel.org/soc/soc/c/ba4b4d0293ed
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-19 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 16:53 [PATCH] soc: tegra: fix CPU_BIG_ENDIAN dependencies Arnd Bergmann
2022-12-16 13:20 ` Thierry Reding
2022-12-19 16:00 ` patchwork-bot+linux-soc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).