soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH PULL] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller
@ 2023-06-12 18:01 Krzysztof Kozlowski
  2023-06-20 21:21 ` patchwork-bot+linux-soc
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-12 18:01 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, arm, soc
  Cc: Sam Protsenko, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	Alim Akhtar, Krzysztof Kozlowski

From: Sam Protsenko <semen.protsenko@linaro.org>

As described in the corresponding binding documentation for
"samsung,exynos850-pmu", the "clocks" property should be used for
specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850
pmu_system_controller is incorrect and should be removed. Instead of
making syscon regmap keep that clock running for PMU accesses, it should
be made always running in the clock driver, because the kernel is not
the only software accessing PMU registers on Exynos850 platform.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Link: https://lore.kernel.org/r/20230308233822.31180-8-semen.protsenko@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/exynos/exynos850.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
index d67e98120313..aa077008b3be 100644
--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
@@ -200,7 +200,6 @@ gic: interrupt-controller@12a01000 {
 		pmu_system_controller: system-controller@11860000 {
 			compatible = "samsung,exynos850-pmu", "syscon";
 			reg = <0x11860000 0x10000>;
-			clocks = <&cmu_apm CLK_GOUT_PMU_ALIVE_PCLK>;
 
 			reboot: syscon-reboot {
 				compatible = "syscon-reboot";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH PULL] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller
  2023-06-12 18:01 [PATCH PULL] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller Krzysztof Kozlowski
@ 2023-06-20 21:21 ` patchwork-bot+linux-soc
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-soc @ 2023-06-20 21:21 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: soc

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon, 12 Jun 2023 20:01:02 +0200 you wrote:
> From: Sam Protsenko <semen.protsenko@linaro.org>
> 
> As described in the corresponding binding documentation for
> "samsung,exynos850-pmu", the "clocks" property should be used for
> specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850
> pmu_system_controller is incorrect and should be removed. Instead of
> making syscon regmap keep that clock running for PMU accesses, it should
> be made always running in the clock driver, because the kernel is not
> the only software accessing PMU registers on Exynos850 platform.
> 
> [...]

Here is the summary with links:
  - [PULL] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller
    https://git.kernel.org/soc/soc/c/12109610a5ce

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-20 21:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 18:01 [PATCH PULL] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller Krzysztof Kozlowski
2023-06-20 21:21 ` patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).