soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PULL] bus: Convert to platform remove callback returning void
       [not found] ` <1e5e1008-707b-449a-9dbf-48324eb2b248@app.fastmail.com>
@ 2023-11-16 11:53   ` Uwe Kleine-König
  2023-11-28 17:49     ` [PULL v2] " Uwe Kleine-König
  0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2023-11-16 11:53 UTC (permalink / raw)
  To: Arnd Bergmann, soc
  Cc: Jay Fang, Rob Herring, Jernej Skrabec, Laurentiu Tudor,
	Tony Lindgren, Sicelo A. Mhlongo, Andy Gross, Bjorn Andersson,
	Konrad Dybcio, Greg Kroah-Hartman, Liu Ying, Geert Uytterhoeven,
	Luis Chamberlain, Nick Alcock, Chen-Yu Tsai, Samuel Holland,
	Hans de Goede, Yangtao Li, Yuan Can, Thierry Reding, Jon Hunter,
	linux-arm-msm, linux-kernel, Pengutronix Kernel Team,
	linux-tegra, Linux-OMAP, linux-sunxi, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 3859 bytes --]

Hello Arnd,

On Fri, Nov 10, 2023 at 07:32:01AM +0100, Arnd Bergmann wrote:
> On Thu, Nov 9, 2023, at 21:28, Uwe Kleine-König wrote:
> > this series converts all drivers below drivers/bus to struct
> > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> > Provide a remove callback that returns no value") for an extended
> > explanation and the eventual goal.
> >
> > drivers/bus/fsl-mc was already addressed earlier with a separate
> > series[1].
> >
> > All conversations are trivial, because all .remove() callbacks returned
> > zero unconditionally.
> >
> > Some of the drivers touched here don't have a maintainer and there is no
> > maintainer for all of drivers/bus. It would be great if someone could pick up
> > the whole series, maybe Arnd might do that?
> 
> Sure, please send a pull request to soc@kernel.org if there
> are no further comments.

here it comes:

The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:

  Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

are available in the Git repository at:

  https://git.pengutronix.de/git/ukl/linux tags/bus-platform-remove-void

for you to fetch changes up to 7d6da8800a35d2257ff8b4b7d7c4551978f0a71a:

  bus: ts-nbus: Convert to platform remove callback returning void (2023-11-16 12:43:57 +0100)

----------------------------------------------------------------
This series converts all drivers below drivers/bus to struct
platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
Provide a remove callback that returns no value") for an extended
explanation and the eventual goal.

After the initial simplification in commit 864acca58000 ("bus: fsl-mc:
Drop if block with always false condition") all conversations are
trivial because the remove callbacks all return zero unconditionally.

----------------------------------------------------------------
Uwe Kleine-König (14):
      bus: fsl-mc: Drop if block with always false condition
      bus: fsl-mc: Convert to platform remove callback returning void
      bus: hisi_lpc: Convert to platform remove callback returning void
      bus: omap-ocp2scp: Convert to platform remove callback returning void
      bus: omap_l3_smx: Convert to platform remove callback returning void
      bus: qcom-ssc-block-bus: Convert to platform remove callback returning void
      bus: simple-pm-bus: Convert to platform remove callback returning void
      bus: sun50i-de2: Convert to platform remove callback returning void
      bus: sunxi-rsb: Convert to platform remove callback returning void
      bus: tegra-aconnect: Convert to platform remove callback returning void
      bus: tegra-gmi: Convert to platform remove callback returning void
      bus: ti-pwmss: Convert to platform remove callback returning void
      bus: ti-sysc: Convert to platform remove callback returning void
      bus: ts-nbus: Convert to platform remove callback returning void

 drivers/bus/fsl-mc/fsl-mc-bus.c  | 16 +++-------------
 drivers/bus/hisi_lpc.c           |  6 ++----
 drivers/bus/omap-ocp2scp.c       |  6 ++----
 drivers/bus/omap_l3_smx.c        |  6 ++----
 drivers/bus/qcom-ssc-block-bus.c |  6 ++----
 drivers/bus/simple-pm-bus.c      |  7 +++----
 drivers/bus/sun50i-de2.c         |  5 ++---
 drivers/bus/sunxi-rsb.c          |  6 ++----
 drivers/bus/tegra-aconnect.c     |  6 ++----
 drivers/bus/tegra-gmi.c          |  6 ++----
 drivers/bus/ti-pwmss.c           |  5 ++---
 drivers/bus/ti-sysc.c            |  6 ++----
 drivers/bus/ts-nbus.c            |  6 ++----
 13 files changed, 28 insertions(+), 59 deletions(-)

Thanks for considering these changes,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL v2] bus: Convert to platform remove callback returning void
  2023-11-16 11:53   ` [PULL] bus: Convert to platform remove callback returning void Uwe Kleine-König
@ 2023-11-28 17:49     ` Uwe Kleine-König
  2023-12-06 17:17       ` patchwork-bot+linux-soc
  0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2023-11-28 17:49 UTC (permalink / raw)
  To: Arnd Bergmann, soc
  Cc: Geert Uytterhoeven, Tony Lindgren, Yuan Can, Thierry Reding,
	Rob Herring, Samuel Holland, Jernej Skrabec, Jon Hunter,
	Chen-Yu Tsai, Andy Gross, linux-sunxi, Nick Alcock, Yangtao Li,
	Liu Ying, linux-arm-msm, Jay Fang, Hans de Goede, linux-tegra,
	Linux-OMAP, linux-arm-kernel, Laurentiu Tudor, Sicelo A. Mhlongo,
	Greg Kroah-Hartman, Bjorn Andersson, linux-kernel, Konrad Dybcio,
	Luis Chamberlain, Pengutronix Kernel Team

[-- Attachment #1: Type: text/plain, Size: 4392 bytes --]

Hello Arnd,

On Thu, Nov 16, 2023 at 12:53:07PM +0100, Uwe Kleine-König wrote:
> On Fri, Nov 10, 2023 at 07:32:01AM +0100, Arnd Bergmann wrote:
> > On Thu, Nov 9, 2023, at 21:28, Uwe Kleine-König wrote:
> > > this series converts all drivers below drivers/bus to struct
> > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> > > Provide a remove callback that returns no value") for an extended
> > > explanation and the eventual goal.
> > >
> > > drivers/bus/fsl-mc was already addressed earlier with a separate
> > > series[1].
> > >
> > > All conversations are trivial, because all .remove() callbacks returned
> > > zero unconditionally.
> > >
> > > Some of the drivers touched here don't have a maintainer and there is no
> > > maintainer for all of drivers/bus. It would be great if someone could pick up
> > > the whole series, maybe Arnd might do that?
> > 
> > Sure, please send a pull request to soc@kernel.org if there
> > are no further comments.
> 
> here it comes:
> 
> The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:
> 
>   Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

Here comes an updated PR. The only change is that it also includes two
Reviewed-by tags for Jernej Skrabec that came in after I sent the PR.
Obviously that changed the commit hash which made it necessary to redo
the PR. I hope it doesn't disturb your tooling that there are now two
similar pull requests.

Best regards
Uwe

The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:

  Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

are available in the Git repository at:

  https://git.pengutronix.de/git/ukl/linux tags/bus-platform-remove-void

for you to fetch changes up to fc540426f7baa0c7d4b477e80435d075659092a2:

  bus: ts-nbus: Convert to platform remove callback returning void (2023-11-28 18:43:27 +0100)

----------------------------------------------------------------
This series converts all drivers below drivers/bus to struct
platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
Provide a remove callback that returns no value") for an extended
explanation and the eventual goal.

After the initial simplification in commit 864acca58000 ("bus: fsl-mc:
Drop if block with always false condition") all conversations are
trivial because the remove callbacks all return zero unconditionally.

----------------------------------------------------------------
Uwe Kleine-König (14):
      bus: fsl-mc: Drop if block with always false condition
      bus: fsl-mc: Convert to platform remove callback returning void
      bus: hisi_lpc: Convert to platform remove callback returning void
      bus: omap-ocp2scp: Convert to platform remove callback returning void
      bus: omap_l3_smx: Convert to platform remove callback returning void
      bus: qcom-ssc-block-bus: Convert to platform remove callback returning void
      bus: simple-pm-bus: Convert to platform remove callback returning void
      bus: sun50i-de2: Convert to platform remove callback returning void
      bus: sunxi-rsb: Convert to platform remove callback returning void
      bus: tegra-aconnect: Convert to platform remove callback returning void
      bus: tegra-gmi: Convert to platform remove callback returning void
      bus: ti-pwmss: Convert to platform remove callback returning void
      bus: ti-sysc: Convert to platform remove callback returning void
      bus: ts-nbus: Convert to platform remove callback returning void

 drivers/bus/fsl-mc/fsl-mc-bus.c  | 16 +++-------------
 drivers/bus/hisi_lpc.c           |  6 ++----
 drivers/bus/omap-ocp2scp.c       |  6 ++----
 drivers/bus/omap_l3_smx.c        |  6 ++----
 drivers/bus/qcom-ssc-block-bus.c |  6 ++----
 drivers/bus/simple-pm-bus.c      |  7 +++----
 drivers/bus/sun50i-de2.c         |  5 ++---
 drivers/bus/sunxi-rsb.c          |  6 ++----
 drivers/bus/tegra-aconnect.c     |  6 ++----
 drivers/bus/tegra-gmi.c          |  6 ++----
 drivers/bus/ti-pwmss.c           |  5 ++---
 drivers/bus/ti-sysc.c            |  6 ++----
 drivers/bus/ts-nbus.c            |  6 ++----
 13 files changed, 28 insertions(+), 59 deletions(-)


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PULL v2] bus: Convert to platform remove callback returning void
  2023-11-28 17:49     ` [PULL v2] " Uwe Kleine-König
@ 2023-12-06 17:17       ` patchwork-bot+linux-soc
  0 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-soc @ 2023-12-06 17:17 UTC (permalink / raw)
  To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
  Cc: soc

Hello:

This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Tue, 28 Nov 2023 18:49:27 +0100 you wrote:
> Hello Arnd,
> 
> On Thu, Nov 16, 2023 at 12:53:07PM +0100, Uwe Kleine-König wrote:
> > On Fri, Nov 10, 2023 at 07:32:01AM +0100, Arnd Bergmann wrote:
> > > On Thu, Nov 9, 2023, at 21:28, Uwe Kleine-König wrote:
> > > > this series converts all drivers below drivers/bus to struct
> > > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> > > > Provide a remove callback that returns no value") for an extended
> > > > explanation and the eventual goal.
> > > >
> > > > drivers/bus/fsl-mc was already addressed earlier with a separate
> > > > series[1].
> > > >
> > > > All conversations are trivial, because all .remove() callbacks returned
> > > > zero unconditionally.
> > > >
> > > > Some of the drivers touched here don't have a maintainer and there is no
> > > > maintainer for all of drivers/bus. It would be great if someone could pick up
> > > > the whole series, maybe Arnd might do that?
> > >
> > > Sure, please send a pull request to soc@kernel.org if there
> > > are no further comments.
> >
> > here it comes:
> >
> > The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:
> >
> >   Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)
> 
> [...]

Here is the summary with links:
  - [PULL,v2] bus: Convert to platform remove callback returning void
    https://git.kernel.org/soc/soc/c/a351940d61e6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-06 17:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de>
     [not found] ` <1e5e1008-707b-449a-9dbf-48324eb2b248@app.fastmail.com>
2023-11-16 11:53   ` [PULL] bus: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-28 17:49     ` [PULL v2] " Uwe Kleine-König
2023-12-06 17:17       ` patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).