soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	arm@kernel.org, SoC Team <soc@kernel.org>,
	Romain Perier <romain.perier@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mohammed Billoo <mohammed.billoo@gmail.com>
Subject: Re: [GIT PULL] ARM: mstar for v5.14
Date: Sat, 12 Jun 2021 08:59:53 -0700	[thread overview]
Message-ID: <20210612155953.GA11724@lx2k> (raw)
In-Reply-To: <CAFr9PXkMSDvks+DeCNJ6iKf6zDH0VaOL6msirR3g2K7BNL8YkQ@mail.gmail.com>

Hi,

On Sat, Jun 12, 2021 at 12:09:56PM +0900, Daniel Palmer wrote:
> Hi Arnd, Olof,
> 
> This is my first time doing this so apologies in advance if I've messed this up.
> Anyhow, we have two very small patches for 5.14.

Overall this is the right way to do it, but my tooling spotted a miss: You
didn't sign off on at least one of the patches you applied (the UART one). Make
sure you do 'git am -s' or similar so you have a S-o-b entry when you're the
one applying the patch.

Mind respinning the pull request with that corrected, so we avoid getting an
email from Stephen Rothwell about it too? :)

Beyond that, keeping an eye on how you sort patches when you have more
material: In particular we keep DT, soc, drivers and defconfig updates in
separate branches as much as we can -- sometimes dt-bindings need to be in both
DT and driver branches, for example. That doesn't apply to this pull request,
since the MAINTAINERS entry and the other one fix are fine to bundle (they
would end up in the 'soc' branch at our end).

We can tweak that over time as you get more familiar with how we separate
the streams of patches.


-Olof


  parent reply	other threads:[~2021-06-12 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12  3:09 [GIT PULL] ARM: mstar for v5.14 Daniel Palmer
2021-06-12  3:09 ` Daniel Palmer
2021-06-12 15:59 ` Olof Johansson [this message]
2021-06-12 17:05   ` Daniel Palmer
2021-06-12 17:05     ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210612155953.GA11724@lx2k \
    --to=olof@lixom.net \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=daniel@0x0f.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohammed.billoo@gmail.com \
    --cc=romain.perier@gmail.com \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).