From: Daniel Palmer <daniel@0x0f.com>
To: Olof Johansson <olof@lixom.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
arm@kernel.org, SoC Team <soc@kernel.org>,
Romain Perier <romain.perier@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mohammed Billoo <mohammed.billoo@gmail.com>
Subject: Re: [GIT PULL] ARM: mstar for v5.14
Date: Sun, 13 Jun 2021 02:05:35 +0900 [thread overview]
Message-ID: <CAFr9PXnuoonY=m53==hyAo4Con_3-Fk_3KEfQp4sfLKBZyGS+Q@mail.gmail.com> (raw)
Message-ID: <20210612170535.HF7Ky3rc2e83szBzCmFdOJC8KlkRFd_toq2_DdWG3wA@z> (raw)
In-Reply-To: <20210612155953.GA11724@lx2k>
Hi Olof,
On Sun, 13 Jun 2021 at 01:15, Olof Johansson <olof@lixom.net> wrote:
> Overall this is the right way to do it, but my tooling spotted a miss: You
> didn't sign off on at least one of the patches you applied (the UART one). Make
> sure you do 'git am -s' or similar so you have a S-o-b entry when you're the
> one applying the patch.
Ah, so there should have been a sign off from me for Romain's patch
after the existing tags.
> Mind respinning the pull request with that corrected, so we avoid getting an
> email from Stephen Rothwell about it too? :)
Sure.
> Beyond that, keeping an eye on how you sort patches when you have more
> material: In particular we keep DT, soc, drivers and defconfig updates in
> separate branches as much as we can -- sometimes dt-bindings need to be in both
> DT and driver branches, for example. That doesn't apply to this pull request,
> since the MAINTAINERS entry and the other one fix are fine to bundle (they
> would end up in the 'soc' branch at our end).
Thanks for the heads up. We should have one DT patch for 5.14 that
I'll send a separate pull request for.
> We can tweak that over time as you get more familiar with how we separate
> the streams of patches.
Thanks!
Cheers,
Daniel
next prev parent reply other threads:[~2021-06-12 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 3:09 [GIT PULL] ARM: mstar for v5.14 Daniel Palmer
2021-06-12 3:09 ` Daniel Palmer
2021-06-12 15:59 ` Olof Johansson
2021-06-12 17:05 ` Daniel Palmer [this message]
2021-06-12 17:05 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFr9PXnuoonY=m53==hyAo4Con_3-Fk_3KEfQp4sfLKBZyGS+Q@mail.gmail.com' \
--to=daniel@0x0f.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammed.billoo@gmail.com \
--cc=olof@lixom.net \
--cc=romain.perier@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).