soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: versatile: Fix up interrupt controller node names
@ 2021-06-25 23:58 Linus Walleij
  2021-06-25 23:58 ` Linus Walleij
  2021-07-01 13:21 ` [PATCH v2] " Sudeep Holla
  0 siblings, 2 replies; 7+ messages in thread
From: Linus Walleij @ 2021-06-25 23:58 UTC (permalink / raw)
  To: arm, soc; +Cc: linux-arm-kernel, Sudeep Holla, Linus Walleij

From: Sudeep Holla <sudeep.holla@arm.com>

Once the new schema interrupt-controller/arm,vic.yaml is added, we get
the below warnings:

        arch/arm/boot/dts/versatile-ab.dt.yaml:
        intc@10140000: $nodename:0: 'intc@10140000' does not match
        '^interrupt-controller(@[0-9a-f,]+)*$'

	arch/arm/boot/dts/versatile-ab.dt.yaml:
	intc@10140000: 'clear-mask' does not match any of the regexes

Fix the node names for the interrupt controller to conform
to the standard node name interrupt-controller@.. Also drop invalid
clear-mask property.

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20210617210825.3064367-1-sudeep.holla@arm.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi SoC people, please apply this directly to DTS fixes, I have
no other Versatile DTS changes coming right now.
---
 arch/arm/boot/dts/versatile-ab.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 37bd41ff8dff..151c0220047d 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -195,16 +195,15 @@ amba {
 		#size-cells = <1>;
 		ranges;
 
-		vic: intc@10140000 {
+		vic: interrupt-controller@10140000 {
 			compatible = "arm,versatile-vic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			reg = <0x10140000 0x1000>;
-			clear-mask = <0xffffffff>;
 			valid-mask = <0xffffffff>;
 		};
 
-		sic: intc@10003000 {
+		sic: interrupt-controller@10003000 {
 			compatible = "arm,versatile-sic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: versatile: Fix up interrupt controller node names
  2021-06-25 23:58 [PATCH] ARM: dts: versatile: Fix up interrupt controller node names Linus Walleij
@ 2021-06-25 23:58 ` Linus Walleij
  2021-07-01 13:21 ` [PATCH v2] " Sudeep Holla
  1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-06-25 23:58 UTC (permalink / raw)
  To: arm, soc; +Cc: linux-arm-kernel, Sudeep Holla, Linus Walleij

From: Sudeep Holla <sudeep.holla@arm.com>

Once the new schema interrupt-controller/arm,vic.yaml is added, we get
the below warnings:

        arch/arm/boot/dts/versatile-ab.dt.yaml:
        intc@10140000: $nodename:0: 'intc@10140000' does not match
        '^interrupt-controller(@[0-9a-f,]+)*$'

	arch/arm/boot/dts/versatile-ab.dt.yaml:
	intc@10140000: 'clear-mask' does not match any of the regexes

Fix the node names for the interrupt controller to conform
to the standard node name interrupt-controller@.. Also drop invalid
clear-mask property.

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20210617210825.3064367-1-sudeep.holla@arm.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi SoC people, please apply this directly to DTS fixes, I have
no other Versatile DTS changes coming right now.
---
 arch/arm/boot/dts/versatile-ab.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 37bd41ff8dff..151c0220047d 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -195,16 +195,15 @@ amba {
 		#size-cells = <1>;
 		ranges;
 
-		vic: intc@10140000 {
+		vic: interrupt-controller@10140000 {
 			compatible = "arm,versatile-vic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			reg = <0x10140000 0x1000>;
-			clear-mask = <0xffffffff>;
 			valid-mask = <0xffffffff>;
 		};
 
-		sic: intc@10003000 {
+		sic: interrupt-controller@10003000 {
 			compatible = "arm,versatile-sic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH v2] ARM: dts: versatile: Fix up interrupt controller node names
  2021-06-25 23:58 [PATCH] ARM: dts: versatile: Fix up interrupt controller node names Linus Walleij
  2021-06-25 23:58 ` Linus Walleij
@ 2021-07-01 13:21 ` Sudeep Holla
  2021-07-01 13:21   ` Sudeep Holla
                     ` (2 more replies)
  1 sibling, 3 replies; 7+ messages in thread
From: Sudeep Holla @ 2021-07-01 13:21 UTC (permalink / raw)
  To: arm, soc; +Cc: Sudeep Holla, linux-arm-kernel, Linus Walleij

Once the new schema interrupt-controller/arm,vic.yaml is added, we get
the below warnings:

        arch/arm/boot/dts/versatile-ab.dt.yaml:
        intc@10140000: $nodename:0: 'intc@10140000' does not match
        '^interrupt-controller(@[0-9a-f,]+)*$'

	arch/arm/boot/dts/versatile-ab.dt.yaml:
	intc@10140000: 'clear-mask' does not match any of the regexes

Fix the node names for the interrupt controller to conform
to the standard node name interrupt-controller@.. Also drop invalid
clear-mask property.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm/boot/dts/versatile-ab.dts | 5 ++---
 arch/arm/boot/dts/versatile-pb.dts | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

Hi SoC people, please apply this directly to DTS fixes, Linus W doesn't
have no other Versatile DTS changes coming right now, so sending it to you
directly.

v1->v2:
	- Fix the build error reported by kbuild-bot which I missed as
	  I had assumed multi_v5_defconfig to include versatile :(

diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 37bd41ff8dff..151c0220047d 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -195,16 +195,15 @@ amba {
 		#size-cells = <1>;
 		ranges;
 
-		vic: intc@10140000 {
+		vic: interrupt-controller@10140000 {
 			compatible = "arm,versatile-vic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			reg = <0x10140000 0x1000>;
-			clear-mask = <0xffffffff>;
 			valid-mask = <0xffffffff>;
 		};
 
-		sic: intc@10003000 {
+		sic: interrupt-controller@10003000 {
 			compatible = "arm,versatile-sic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
diff --git a/arch/arm/boot/dts/versatile-pb.dts b/arch/arm/boot/dts/versatile-pb.dts
index 06a0fdf24026..e7e751a858d8 100644
--- a/arch/arm/boot/dts/versatile-pb.dts
+++ b/arch/arm/boot/dts/versatile-pb.dts
@@ -7,7 +7,7 @@ / {
 
 	amba {
 		/* The Versatile PB is using more SIC IRQ lines than the AB */
-		sic: intc@10003000 {
+		sic: interrupt-controller@10003000 {
 			clear-mask = <0xffffffff>;
 			/*
 			 * Valid interrupt lines mask according to
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH v2] ARM: dts: versatile: Fix up interrupt controller node names
  2021-07-01 13:21 ` [PATCH v2] " Sudeep Holla
@ 2021-07-01 13:21   ` Sudeep Holla
  2021-07-16 21:22   ` patchwork-bot+linux-soc
  2021-07-16 21:24   ` Arnd Bergmann
  2 siblings, 0 replies; 7+ messages in thread
From: Sudeep Holla @ 2021-07-01 13:21 UTC (permalink / raw)
  To: arm, soc; +Cc: Sudeep Holla, linux-arm-kernel, Linus Walleij

Once the new schema interrupt-controller/arm,vic.yaml is added, we get
the below warnings:

        arch/arm/boot/dts/versatile-ab.dt.yaml:
        intc@10140000: $nodename:0: 'intc@10140000' does not match
        '^interrupt-controller(@[0-9a-f,]+)*$'

	arch/arm/boot/dts/versatile-ab.dt.yaml:
	intc@10140000: 'clear-mask' does not match any of the regexes

Fix the node names for the interrupt controller to conform
to the standard node name interrupt-controller@.. Also drop invalid
clear-mask property.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm/boot/dts/versatile-ab.dts | 5 ++---
 arch/arm/boot/dts/versatile-pb.dts | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

Hi SoC people, please apply this directly to DTS fixes, Linus W doesn't
have no other Versatile DTS changes coming right now, so sending it to you
directly.

v1->v2:
	- Fix the build error reported by kbuild-bot which I missed as
	  I had assumed multi_v5_defconfig to include versatile :(

diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 37bd41ff8dff..151c0220047d 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -195,16 +195,15 @@ amba {
 		#size-cells = <1>;
 		ranges;
 
-		vic: intc@10140000 {
+		vic: interrupt-controller@10140000 {
 			compatible = "arm,versatile-vic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			reg = <0x10140000 0x1000>;
-			clear-mask = <0xffffffff>;
 			valid-mask = <0xffffffff>;
 		};
 
-		sic: intc@10003000 {
+		sic: interrupt-controller@10003000 {
 			compatible = "arm,versatile-sic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
diff --git a/arch/arm/boot/dts/versatile-pb.dts b/arch/arm/boot/dts/versatile-pb.dts
index 06a0fdf24026..e7e751a858d8 100644
--- a/arch/arm/boot/dts/versatile-pb.dts
+++ b/arch/arm/boot/dts/versatile-pb.dts
@@ -7,7 +7,7 @@ / {
 
 	amba {
 		/* The Versatile PB is using more SIC IRQ lines than the AB */
-		sic: intc@10003000 {
+		sic: interrupt-controller@10003000 {
 			clear-mask = <0xffffffff>;
 			/*
 			 * Valid interrupt lines mask according to
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: versatile: Fix up interrupt controller node names
  2021-07-01 13:21 ` [PATCH v2] " Sudeep Holla
  2021-07-01 13:21   ` Sudeep Holla
@ 2021-07-16 21:22   ` patchwork-bot+linux-soc
  2021-07-16 21:24   ` Arnd Bergmann
  2 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+linux-soc @ 2021-07-16 21:22 UTC (permalink / raw)
  To: Sudeep Holla; +Cc: soc

Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

On Thu,  1 Jul 2021 14:21:18 +0100 you wrote:
> Once the new schema interrupt-controller/arm,vic.yaml is added, we get
> the below warnings:
> 
>         arch/arm/boot/dts/versatile-ab.dt.yaml:
>         intc@10140000: $nodename:0: 'intc@10140000' does not match
>         '^interrupt-controller(@[0-9a-f,]+)*$'
> 
> [...]

Here is the summary with links:
  - [v2] ARM: dts: versatile: Fix up interrupt controller node names
    https://git.kernel.org/soc/soc/c/82a1c67554df

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: versatile: Fix up interrupt controller node names
  2021-07-01 13:21 ` [PATCH v2] " Sudeep Holla
  2021-07-01 13:21   ` Sudeep Holla
  2021-07-16 21:22   ` patchwork-bot+linux-soc
@ 2021-07-16 21:24   ` Arnd Bergmann
  2021-07-16 21:24     ` Arnd Bergmann
  2 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2021-07-16 21:24 UTC (permalink / raw)
  To: Sudeep Holla, arm, soc; +Cc: Arnd Bergmann, linux-arm-kernel, Linus Walleij

From: Arnd Bergmann <arnd@arndb.de>

On Thu, 1 Jul 2021 14:21:18 +0100, Sudeep Holla wrote:
> Once the new schema interrupt-controller/arm,vic.yaml is added, we get
> the below warnings:
> 
>         arch/arm/boot/dts/versatile-ab.dt.yaml:
>         intc@10140000: $nodename:0: 'intc@10140000' does not match
>         '^interrupt-controller(@[0-9a-f,]+)*$'
> 
> [...]

Applied to arm/fixes, thanks!

[1/1] ARM: dts: versatile: Fix up interrupt controller node names
      commit: 82a1c67554dff610d6be4e1982c425717b3c6a23

       Arnd

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: versatile: Fix up interrupt controller node names
  2021-07-16 21:24   ` Arnd Bergmann
@ 2021-07-16 21:24     ` Arnd Bergmann
  0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2021-07-16 21:24 UTC (permalink / raw)
  To: Sudeep Holla, arm, soc; +Cc: Arnd Bergmann, linux-arm-kernel, Linus Walleij

From: Arnd Bergmann <arnd@arndb.de>

On Thu, 1 Jul 2021 14:21:18 +0100, Sudeep Holla wrote:
> Once the new schema interrupt-controller/arm,vic.yaml is added, we get
> the below warnings:
> 
>         arch/arm/boot/dts/versatile-ab.dt.yaml:
>         intc@10140000: $nodename:0: 'intc@10140000' does not match
>         '^interrupt-controller(@[0-9a-f,]+)*$'
> 
> [...]

Applied to arm/fixes, thanks!

[1/1] ARM: dts: versatile: Fix up interrupt controller node names
      commit: 82a1c67554dff610d6be4e1982c425717b3c6a23

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-16 21:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25 23:58 [PATCH] ARM: dts: versatile: Fix up interrupt controller node names Linus Walleij
2021-06-25 23:58 ` Linus Walleij
2021-07-01 13:21 ` [PATCH v2] " Sudeep Holla
2021-07-01 13:21   ` Sudeep Holla
2021-07-16 21:22   ` patchwork-bot+linux-soc
2021-07-16 21:24   ` Arnd Bergmann
2021-07-16 21:24     ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).