From: Joel Stanley <joel@jms.id.au>
To: Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@amd.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH] ARM: dts: aspeed: Add AMD DaytonaX BMC
Date: Tue, 26 Oct 2021 21:03:22 +0000 [thread overview]
Message-ID: <CACPK8Xd5eYpsFNw1jEjv3NaShgzE3zC_Ct29pJM34TfrqRTNtQ@mail.gmail.com> (raw)
Message-ID: <20211026210322.w1Sk9QTjthERDPGlFra9Ji4iQJ3KDH5-PwvLtG5_4dE@z> (raw)
In-Reply-To: <20211026200058.2183-1-aladyshev22@gmail.com>
Hello Konstantin,
On Tue, 26 Oct 2021 at 20:01, Konstantin Aladyshev
<aladyshev22@gmail.com> wrote:
>
> Add initial version of device tree for the BMC in the AMD DaytonaX
> platform.
>
> AMD DaytonaX platform is a customer reference board (CRB) with an
> Aspeed ast2500 BMC manufactured by AMD.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
This looks good. I have one comment about the GPIOs below.
> +&gpio {
> + status = "okay";
> + gpio-line-names =
> + /*A0-A7*/ "","","FAULT_LED","","","","","",
> + /*B0-B7*/ "","","","","","","","",
> + /*C0-C7*/ "CHASSIS_ID_BTN","","","","","","","",
> + /*D0-D7*/ "","","ASSERT_BMC_READY","","","","","",
> + /*E0-E7*/ "MON_P0_RST_BTN","ASSERT_RST_BTN","MON_P0_PWR_BTN","ASSERT_PWR_BTN","",
> + "MON_P0_PWR_GOOD","MON_PWROK","",
For systems that will run openbmc, we try to use naming conventions
from this document:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
If a GPIO is missing from that doc I encourage you to add it.
next prev parent reply other threads:[~2021-10-26 21:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 20:00 [PATCH] ARM: dts: aspeed: Add AMD DaytonaX BMC Konstantin Aladyshev
2021-10-26 20:00 ` Konstantin Aladyshev
2021-10-26 20:00 ` Konstantin Aladyshev
2021-10-26 21:03 ` Joel Stanley [this message]
2021-10-26 21:03 ` Joel Stanley
2021-10-26 21:03 ` Joel Stanley
2021-10-27 11:05 ` Konstantin Aladyshev
2021-10-27 11:05 ` Konstantin Aladyshev
2021-10-27 11:05 ` Konstantin Aladyshev
2021-11-16 6:07 ` Joel Stanley
2021-11-16 6:07 ` Joel Stanley
2022-09-20 15:34 Konstantin Aladyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xd5eYpsFNw1jEjv3NaShgzE3zC_Ct29pJM34TfrqRTNtQ@mail.gmail.com \
--to=joel@jms.id.au \
--cc=aladyshev22@gmail.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=supreeth.venkatesh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).