Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible

From: Rob Herring <robh@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	 Fabio Estevam <festevam@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	 Dong Aisheng <aisheng.dong@nxp.com>,
	Stefan Agner <stefan@agner.ch>,
	 Linus Walleij <linus.walleij@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	SoC Team <soc@kernel.org>,  Russell King <linux@armlinux.org.uk>,
	Abel Vesa <abel.vesa@nxp.com>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	 Giulio Benetti <giulio.benetti@benettiengineering.com>,
	 Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	 Leonard Crestez <leonard.crestez@nxp.com>,
	Anson Huang <b20788@freescale.com>,
	 Fugang Duan <fugang.duan@nxp.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	 devicetree@vger.kernel.org,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	 "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible
Date: Tue, 2 Nov 2021 19:49:07 -0500	[thread overview]
Message-ID: <CAL_JsqJR6EfDsmwPmXxgdaC1GB7CLGYpjmDnOkD_f53Frsq6LA@mail.gmail.com> (raw)
Message-ID: <20211103004907.QlPxJVgtGoDjMIzu4v_odcRgmJnXJCuPfuZaoYbcgns@z> (raw)
In-Reply-To: <58e5ec6a-7b85-3935-f859-6670600ac6a2@gmail.com>

On Mon, Nov 1, 2021 at 6:34 PM Jesse Taube <mr.bossman075@gmail.com> wrote:
>
>
>
> On 11/1/21 16:13, Rob Herring wrote:
> > On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
> >> Add i.MXRT documentation for compatible string.
> >>
> >> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> >> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> >> ---
> >>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> >> index a90c971b4f1f..4b4340def2aa 100644
> >> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> >> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> >> @@ -21,6 +21,7 @@ properties:
> >>            - fsl,ls1028a-lpuart
> >>            - fsl,imx7ulp-lpuart
> >>            - fsl,imx8qm-lpuart
> >> +          - fsl,imxrt-lpuart
> >
> > Actually, 'rt' is not a single part is it? If the variations are same
> > die, but fused off then no need to distinguish. Otherwise, these should
> > be SoC specific.
> >
> I don't exactly know what "but fused off" means I would assume
> disconnected but on-die?

Right. Or not pinned out is another possibility.

> The imxrtxxx is a series that has the same UART
> controller across them. Should I add ACK?

Looking at the errata docs briefly, there's at least 2 die as some of
the errata docs give the mask id. So they aren't necessarily 'the
same'. You want the compatible strings to be specific enough to handle
any differences or errata. If you only care about the imxrt1050, then
I'd just use that and move on. Otherwise, maybe someone from NXP wants
to comment?

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel