From: Conor Dooley <conor.dooley@microchip.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: Conor Dooley <conor@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>, <soc@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support
Date: Tue, 30 May 2023 09:56:10 +0100 [thread overview]
Message-ID: <20230530-payday-gravity-45a26bd7f2dc@wendy> (raw)
In-Reply-To: <879b7689-5663-28b5-9431-2fdd243ffff2@foss.st.com>
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On Tue, May 30, 2023 at 10:38:30AM +0200, Alexandre TORGUE wrote:
> Hi Conor
>
> On 5/29/23 20:04, Conor Dooley wrote:
> > On Mon, May 29, 2023 at 06:20:25PM +0200, Alexandre Torgue wrote:
> > > Add stm32mp257 pinctrl support.
> > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/stm32/pinctrl-stm32.h
> > > index e0c31c4c8bca..5e5de92ddd58 100644
> > > --- a/drivers/pinctrl/stm32/pinctrl-stm32.h
> > > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.h
> > > @@ -24,6 +24,9 @@
> > > #define STM32MP_PKG_AB BIT(1)
> > > #define STM32MP_PKG_AC BIT(2)
> > > #define STM32MP_PKG_AD BIT(3)
> > > +#define STM32MP_PKG_AI BIT(8)
> > > +#define STM32MP_PKG_AK BIT(10)
> > > +#define STM32MP_PKG_AL BIT(11)
> >
> > Mainly out of curiosity, why have you go duplicate defines for these?
>
> Mainly to fit with available packages for various STM32 MPU. Currently MP1
> SoCs are available with packages AB/AC/AD and MP2 series with AI/AK/AL but
> in the future we could have package AB/AC/AD/AI available for a particular
> SoC and then I need to anticipate this case.
Sorry, what I meant was "why have you got defines for these in this
header, when there is an existing set in
include/dt-bindings/pinctrl/stm32-pinfunc.h?".
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-30 8:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 16:20 [PATCH 00/11] Add STM32MP25 support Alexandre Torgue
2023-05-29 16:20 ` [PATCH 01/11] dt-bindings: pinctrl: stm32: support for stm32mp257 and additional packages Alexandre Torgue
2023-05-29 18:00 ` Conor Dooley
2023-05-29 16:20 ` [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support Alexandre Torgue
2023-05-29 18:04 ` Conor Dooley
2023-05-30 8:38 ` Alexandre TORGUE
2023-05-30 8:56 ` Conor Dooley [this message]
2023-05-30 12:08 ` Alexandre TORGUE
2023-05-29 16:20 ` [PATCH 03/11] dt-bindings: stm32: add st,stm32mp25-syscfg compatible for syscon Alexandre Torgue
[not found] ` <d35fdc37-a793-3109-1474-065dffb03069@linaro.org>
2023-06-02 12:24 ` Alexandre TORGUE
2023-06-02 13:14 ` Krzysztof Kozlowski
2023-05-29 16:20 ` [PATCH 04/11] dt-bindings: stm32: add st,stm32mp25 compatibles to the stm32 family Alexandre Torgue
2023-05-29 18:05 ` Conor Dooley
2023-05-30 8:39 ` Alexandre TORGUE
[not found] ` <25d61668-0b79-8565-0de8-dad7e80e3798@linaro.org>
2023-06-02 12:26 ` Alexandre TORGUE
2023-06-02 13:13 ` Krzysztof Kozlowski
2023-05-29 16:20 ` [PATCH 05/11] arm64: introduce STM32 family on Armv8 architecture Alexandre Torgue
2023-05-29 16:20 ` [PATCH 06/11] arm64: dts: st: introduce stm32mp25 SoCs family Alexandre Torgue
2023-05-29 16:20 ` [PATCH 07/11] arm64: dts: st: introduce stm32mp25 pinctrl files Alexandre Torgue
2023-05-29 16:20 ` [PATCH 08/11] dt-bindings: stm32: document stm32mp257f-ev1 board Alexandre Torgue
2023-05-29 18:06 ` Conor Dooley
2023-05-29 16:20 ` [PATCH 09/11] arm64: dts: st: add stm32mp257f-ev1 board support Alexandre Torgue
2023-05-29 16:20 ` [PATCH 10/11] arm64: defconfig: enable ARCH_STM32 and STM32 serial driver Alexandre Torgue
2023-05-29 16:20 ` [PATCH 11/11] MAINTAINERS: add entry for ARM/STM32 ARCHITECTURE Alexandre Torgue
2023-05-30 12:39 ` [PATCH 00/11] Add STM32MP25 support Linus Walleij
2023-05-30 13:32 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530-payday-gravity-45a26bd7f2dc@wendy \
--to=conor.dooley@microchip.com \
--cc=alexandre.torgue@foss.st.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).