soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Conor Dooley <conor@kernel.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>,
	soc@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 04/11] dt-bindings: stm32: add st,stm32mp25 compatibles to the stm32 family
Date: Fri, 2 Jun 2023 15:13:39 +0200	[thread overview]
Message-ID: <955b84da-7d7c-1a30-680f-530c7593643d@linaro.org> (raw)
In-Reply-To: <c805cd5f-92b1-eb56-d9bc-66814705e848@foss.st.com>

On 30/05/2023 10:39, Alexandre TORGUE wrote:
> Hi Conor
> 
> On 5/29/23 20:05, Conor Dooley wrote:
>> On Mon, May 29, 2023 at 06:20:27PM +0200, Alexandre Torgue wrote:
>>> STM32 family is extended by the addition of the STM32MP25 SoCs. It is composed
>>> of 4 SoCs: STM32MP251, STM32MP253, STM32MP255 and STM32MP257.
>>>
>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> index 4af5b8f4f803..7d7ca33d2e61 100644
>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> @@ -161,6 +161,15 @@ properties:
>>>             - const: phytec,phycore-stm32mp157c-som
>>>             - const: st,stm32mp157
>>>   
>>> +      - items:
>>> +          - const: st,stm32mp251
>>> +      - items:
>>> +          - const: st,stm32mp253
>>> +      - items:
>>> +          - const: st,stm32mp255
>>> +      - items:
>>> +          - const: st,stm32mp257
>>
>> I assume the slightly odd format is just to avoid churn when adding
>> the board compatibles.
> 
> Yes, exactly.
> 

I don't get it. How are you going to extend it? Or rather - what are you
documenting here? If these are SoCs, then this is not valid. We do not
allow these alone.

No, please drop it.

Best regards,
Krzysztof


  parent reply	other threads:[~2023-06-02 13:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29 16:20 [PATCH 00/11] Add STM32MP25 support Alexandre Torgue
2023-05-29 16:20 ` [PATCH 01/11] dt-bindings: pinctrl: stm32: support for stm32mp257 and additional packages Alexandre Torgue
2023-05-29 18:00   ` Conor Dooley
2023-05-29 16:20 ` [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support Alexandre Torgue
2023-05-29 18:04   ` Conor Dooley
2023-05-30  8:38     ` Alexandre TORGUE
2023-05-30  8:56       ` Conor Dooley
2023-05-30 12:08         ` Alexandre TORGUE
2023-05-29 16:20 ` [PATCH 03/11] dt-bindings: stm32: add st,stm32mp25-syscfg compatible for syscon Alexandre Torgue
     [not found]   ` <d35fdc37-a793-3109-1474-065dffb03069@linaro.org>
2023-06-02 12:24     ` Alexandre TORGUE
2023-06-02 13:14   ` Krzysztof Kozlowski
2023-05-29 16:20 ` [PATCH 04/11] dt-bindings: stm32: add st,stm32mp25 compatibles to the stm32 family Alexandre Torgue
2023-05-29 18:05   ` Conor Dooley
2023-05-30  8:39     ` Alexandre TORGUE
     [not found]       ` <25d61668-0b79-8565-0de8-dad7e80e3798@linaro.org>
2023-06-02 12:26         ` Alexandre TORGUE
2023-06-02 13:13       ` Krzysztof Kozlowski [this message]
2023-05-29 16:20 ` [PATCH 05/11] arm64: introduce STM32 family on Armv8 architecture Alexandre Torgue
2023-05-29 16:20 ` [PATCH 06/11] arm64: dts: st: introduce stm32mp25 SoCs family Alexandre Torgue
2023-05-29 16:20 ` [PATCH 07/11] arm64: dts: st: introduce stm32mp25 pinctrl files Alexandre Torgue
2023-05-29 16:20 ` [PATCH 08/11] dt-bindings: stm32: document stm32mp257f-ev1 board Alexandre Torgue
2023-05-29 18:06   ` Conor Dooley
2023-05-29 16:20 ` [PATCH 09/11] arm64: dts: st: add stm32mp257f-ev1 board support Alexandre Torgue
2023-05-29 16:20 ` [PATCH 10/11] arm64: defconfig: enable ARCH_STM32 and STM32 serial driver Alexandre Torgue
2023-05-29 16:20 ` [PATCH 11/11] MAINTAINERS: add entry for ARM/STM32 ARCHITECTURE Alexandre Torgue
2023-05-30 12:39 ` [PATCH 00/11] Add STM32MP25 support Linus Walleij
2023-05-30 13:32   ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=955b84da-7d7c-1a30-680f-530c7593643d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).