soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL 1/2] ARM: defconfig: pull for v6.7
@ 2023-10-16  7:29 Krzysztof Kozlowski
  2023-10-16  7:29 ` [PULL 2/2 PATCH] soc: samsung: exynos-chipid: Convert to platform remove callback returning void Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16  7:29 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, arm, soc
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, Alim Akhtar, Krzysztof Kozlowski

The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d:

  Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-defconfig-6.7

for you to fetch changes up to 438fb575463fc490e6200e5e28d02159492a97f8:

  ARM: exynos_defconfig: add driver for ISL29018 (2023-10-06 13:57:37 +0200)

----------------------------------------------------------------
Samsung defconfig changes for v6.7

Enable several drivers for boards with Samsung Exynos ARM SoCs in
exynos_defconfig and multi_v7_defconfig: display PHYs, AHCI DWC, TM2
touchkey (used on ARM and ARM64 Exynos-based boards), Samsung camera
sensors and Intersil 29018 light sensor.

Enable also IIO in s5pv210_defconfig used by MAX17040 fuel gauge driver.

----------------------------------------------------------------
Marek Szyprowski (6):
      ARM: multi_v7_defconfig: make Exynos related PHYs modules
      ARM: multi_v7_defconfig: add AHCI_DWC driver
      ARM: exynos_defconfig: replace SATA_AHCI_PLATFORM with AHCI_DWC driver
      ARM: multi_v7_defconfig: add tm2-touchkey driver
      ARM: multi_v7_defconfig: add drivers for S5C73M3 & S5K6A3 camera sensors
      ARM: exynos_defconfig: add driver for ISL29018

Svyatoslav Ryhel (1):
      ARM: s5pv210_defconfig: enable IIO required by MAX17040

 arch/arm/configs/exynos_defconfig   | 3 ++-
 arch/arm/configs/multi_v7_defconfig | 6 ++++++
 arch/arm/configs/s5pv210_defconfig  | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PULL 2/2 PATCH] soc: samsung: exynos-chipid: Convert to platform remove callback returning void
  2023-10-16  7:29 [GIT PULL 1/2] ARM: defconfig: pull for v6.7 Krzysztof Kozlowski
@ 2023-10-16  7:29 ` Krzysztof Kozlowski
  2023-10-16 21:31 ` [GIT PULL 1/2] ARM: defconfig: pull for v6.7 patchwork-bot+linux-soc
  2023-10-17 22:00 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16  7:29 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, arm, soc
  Cc: Uwe Kleine-König, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, Alim Akhtar, Krzysztof Kozlowski,
	Krzysztof Kozlowski

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230925095532.1984344-32-u.kleine-koenig@pengutronix.de
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/soc/samsung/exynos-chipid.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 7ba45c4aff97..3fd0f2b84dd3 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -158,13 +158,11 @@ static int exynos_chipid_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int exynos_chipid_remove(struct platform_device *pdev)
+static void exynos_chipid_remove(struct platform_device *pdev)
 {
 	struct soc_device *soc_dev = platform_get_drvdata(pdev);
 
 	soc_device_unregister(soc_dev);
-
-	return 0;
 }
 
 static const struct exynos_chipid_variant exynos4210_chipid_drv_data = {
@@ -197,7 +195,7 @@ static struct platform_driver exynos_chipid_driver = {
 		.of_match_table = exynos_chipid_of_device_ids,
 	},
 	.probe	= exynos_chipid_probe,
-	.remove	= exynos_chipid_remove,
+	.remove_new = exynos_chipid_remove,
 };
 module_platform_driver(exynos_chipid_driver);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [GIT PULL 1/2] ARM: defconfig: pull for v6.7
  2023-10-16  7:29 [GIT PULL 1/2] ARM: defconfig: pull for v6.7 Krzysztof Kozlowski
  2023-10-16  7:29 ` [PULL 2/2 PATCH] soc: samsung: exynos-chipid: Convert to platform remove callback returning void Krzysztof Kozlowski
@ 2023-10-16 21:31 ` patchwork-bot+linux-soc
  2023-10-17 22:00 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2023-10-16 21:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: soc

Hello:

This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon, 16 Oct 2023 09:29:10 +0200 you wrote:
> The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d:
> 
>   Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-defconfig-6.7
> 
> [...]

Here is the summary with links:
  - [GIT,PULL,1/2] ARM: defconfig: pull for v6.7
    (no matching commit)
  - [PULL,2/2] soc: samsung: exynos-chipid: Convert to platform remove callback returning void
    https://git.kernel.org/soc/soc/c/55fa358ca89f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL 1/2] ARM: defconfig: pull for v6.7
  2023-10-16  7:29 [GIT PULL 1/2] ARM: defconfig: pull for v6.7 Krzysztof Kozlowski
  2023-10-16  7:29 ` [PULL 2/2 PATCH] soc: samsung: exynos-chipid: Convert to platform remove callback returning void Krzysztof Kozlowski
  2023-10-16 21:31 ` [GIT PULL 1/2] ARM: defconfig: pull for v6.7 patchwork-bot+linux-soc
@ 2023-10-17 22:00 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2023-10-17 22:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: soc

Hello:

This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon, 16 Oct 2023 09:29:10 +0200 you wrote:
> The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d:
> 
>   Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-defconfig-6.7
> 
> [...]

Here is the summary with links:
  - [GIT,PULL,1/2] ARM: defconfig: pull for v6.7
    https://git.kernel.org/soc/soc/c/0c74ef26c50a
  - [PULL,2/2] soc: samsung: exynos-chipid: Convert to platform remove callback returning void
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-17 22:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16  7:29 [GIT PULL 1/2] ARM: defconfig: pull for v6.7 Krzysztof Kozlowski
2023-10-16  7:29 ` [PULL 2/2 PATCH] soc: samsung: exynos-chipid: Convert to platform remove callback returning void Krzysztof Kozlowski
2023-10-16 21:31 ` [GIT PULL 1/2] ARM: defconfig: pull for v6.7 patchwork-bot+linux-soc
2023-10-17 22:00 ` patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).