[PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

[PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

[Lukas Bulwahn]

Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
no effect and any further purpose.

Remove the obsolete config S3C64XX_SETUP_IDE.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mach-s3c/Kconfig.s3c64xx | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
index 01a7a8eec6e8..8f40af063ad6 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c64xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
@@ -69,11 +69,6 @@ config S3C64XX_SETUP_I2C1
 	help
 	  Common setup code for i2c bus 1.
 
-config S3C64XX_SETUP_IDE
-	bool
-	help
-	  Common setup code for S3C64XX IDE.
-
 config S3C64XX_SETUP_FB_24BPP
 	bool
 	help
@@ -110,7 +105,6 @@ config MACH_WLF_CRAGG_6410
 	select S3C64XX_DEV_SPI0
 	select S3C64XX_SETUP_FB_24BPP
 	select S3C64XX_SETUP_I2C1
-	select S3C64XX_SETUP_IDE
 	select S3C64XX_SETUP_KEYPAD
 	select S3C64XX_SETUP_SDHCI
 	select S3C64XX_SETUP_SPI
-- 
2.17.1

Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

[Arnd Bergmann]

On Mon, May 8, 2023, at 06:04, Lukas Bulwahn wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
>
> Remove the obsolete config S3C64XX_SETUP_IDE.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Indeed, this was only used on the smdk64xx board file,
so the file was removed along with the deletion of the board,
but I forgot to remove the Kconfig option.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

[Krzysztof Kozlowski]

On Mon, 08 May 2023 06:04:33 +0200, Lukas Bulwahn wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
> 
> Remove the obsolete config S3C64XX_SETUP_IDE.
> 
> [...]

Applied, thanks!

[1/1] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
      https://git.kernel.org/krzk/linux/c/9d2edccb154bd98baf7f1e21d23f799e4f5e8359

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

[patchwork-bot+linux-soc]

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon,  8 May 2023 06:04:33 +0200 you wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
> 
> Remove the obsolete config S3C64XX_SETUP_IDE.
> 
> [...]

Here is the summary with links:
  - ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
    https://git.kernel.org/soc/soc/c/5038e62d4b4a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

[Arnd Bergmann]

On Fri, May 26, 2023, at 13:50, patchwork-bot+linux-soc@kernel.org wrote:
> Hello:
>
> This patch was applied to soc/soc.git (for-next)
> by Arnd Bergmann <arnd@arndb.de>:
>
> On Mon,  8 May 2023 06:04:33 +0200 you wrote:
>> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
>> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
>> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
>> no effect and any further purpose.
>> 
>> Remove the obsolete config S3C64XX_SETUP_IDE.
>> 
>> [...]
>
> Here is the summary with links:
>   - ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
>     https://git.kernel.org/soc/soc/c/5038e62d4b4a

And dropped again after I noticed that Krzysztof has already merged
it in his tree, sorry for the mixup.

      Arnd