* [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
[not found] <20211013143743.we1yI8NZ9sPL5u79YVoSyliKHyEpm-YCM0UT3Y2guTE@z>
@ 2021-10-13 14:37 ` Arnd Bergmann
[not found] ` <20211013143744.caxMt32pqbKFMbKd_XpISelcE6Zu7zxKLuHeNLAs2e0@z>
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Arnd Bergmann @ 2021-10-13 14:37 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Arnd Bergmann, Liviu Dudau
Cc: soc, Greg Kroah-Hartman, Rui Miguel Silva, Sudeep Holla,
linux-arm-kernel, devicetree, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
dtc now warns for the LED nodes on the versatile-ab board:
versatile-ab.dts:126.12-132.5: Warning (unit_address_format): /core-module@10000000/led@08.7: unit name should not have leading 0s
versatile-ab-ib2.dts:17.12-24.5: Warning (unit_address_format): /syscon@27000000/led@00.4: unit name should not have leading 0s
Remove the extra zeroes.
Fixes: 07ebfa59b9db ("ARM: versatile: add the syscon LEDs to the DT")
Fixes: 7fbe5f7ff267 ("ARM: dts: Add Versatile IB2 device tree")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/boot/dts/arm-realview-eb.dtsi | 18 +++++++++---------
arch/arm/boot/dts/arm-realview-pb1176.dts | 18 +++++++++---------
arch/arm/boot/dts/arm-realview-pb11mp.dts | 18 +++++++++---------
arch/arm/boot/dts/arm-realview-pbx.dtsi | 18 +++++++++---------
arch/arm/boot/dts/versatile-ab-ib2.dts | 2 +-
arch/arm/boot/dts/versatile-ab.dts | 16 ++++++++--------
6 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/arch/arm/boot/dts/arm-realview-eb.dtsi b/arch/arm/boot/dts/arm-realview-eb.dtsi
index 04e8a27ba1eb..48b8994db0af 100644
--- a/arch/arm/boot/dts/arm-realview-eb.dtsi
+++ b/arch/arm/boot/dts/arm-realview-eb.dtsi
@@ -199,7 +199,7 @@ syscon: syscon@10000000 {
compatible = "arm,realview-eb-syscon", "syscon", "simple-mfd";
reg = <0x10000000 0x1000>;
- led@08.0 {
+ led@8.0 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x01>;
@@ -207,7 +207,7 @@ led@08.0 {
linux,default-trigger = "heartbeat";
default-state = "on";
};
- led@08.1 {
+ led@8.1 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x02>;
@@ -215,7 +215,7 @@ led@08.1 {
linux,default-trigger = "mmc0";
default-state = "off";
};
- led@08.2 {
+ led@8.2 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x04>;
@@ -223,42 +223,42 @@ led@08.2 {
linux,default-trigger = "cpu0";
default-state = "off";
};
- led@08.3 {
+ led@8.3 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x08>;
label = "versatile:3";
default-state = "off";
};
- led@08.4 {
+ led@8.4 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x10>;
label = "versatile:4";
default-state = "off";
};
- led@08.5 {
+ led@8.5 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x20>;
label = "versatile:5";
default-state = "off";
};
- led@08.6 {
+ led@8.6 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x40>;
label = "versatile:6";
default-state = "off";
};
- led@08.7 {
+ led@8.7 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x80>;
label = "versatile:7";
default-state = "off";
};
- oscclk0: osc0@0c {
+ oscclk0: osc0@c {
compatible = "arm,syscon-icst307";
#clock-cells = <0>;
lock-offset = <0x20>;
diff --git a/arch/arm/boot/dts/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm-realview-pb1176.dts
index 366687fb1ee3..753c8439ab42 100644
--- a/arch/arm/boot/dts/arm-realview-pb1176.dts
+++ b/arch/arm/boot/dts/arm-realview-pb1176.dts
@@ -217,7 +217,7 @@ syscon: syscon@10000000 {
compatible = "arm,realview-pb1176-syscon", "syscon", "simple-mfd";
reg = <0x10000000 0x1000>;
- led@08.0 {
+ led@8.0 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x01>;
@@ -225,7 +225,7 @@ led@08.0 {
linux,default-trigger = "heartbeat";
default-state = "on";
};
- led@08.1 {
+ led@8.1 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x02>;
@@ -233,7 +233,7 @@ led@08.1 {
linux,default-trigger = "mmc0";
default-state = "off";
};
- led@08.2 {
+ led@8.2 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x04>;
@@ -241,42 +241,42 @@ led@08.2 {
linux,default-trigger = "cpu0";
default-state = "off";
};
- led@08.3 {
+ led@8.3 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x08>;
label = "versatile:3";
default-state = "off";
};
- led@08.4 {
+ led@8.4 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x10>;
label = "versatile:4";
default-state = "off";
};
- led@08.5 {
+ led@8.5 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x20>;
label = "versatile:5";
default-state = "off";
};
- led@08.6 {
+ led@8.6 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x40>;
label = "versatile:6";
default-state = "off";
};
- led@08.7 {
+ led@8.7 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x80>;
label = "versatile:7";
default-state = "off";
};
- oscclk0: osc0@0c {
+ oscclk0: osc0@c {
compatible = "arm,syscon-icst307";
#clock-cells = <0>;
lock-offset = <0x20>;
diff --git a/arch/arm/boot/dts/arm-realview-pb11mp.dts b/arch/arm/boot/dts/arm-realview-pb11mp.dts
index 228a51a38f95..2974daeac5db 100644
--- a/arch/arm/boot/dts/arm-realview-pb11mp.dts
+++ b/arch/arm/boot/dts/arm-realview-pb11mp.dts
@@ -304,7 +304,7 @@ pb11mp_syscon: syscon@10000000 {
compatible = "arm,realview-pb11mp-syscon", "syscon", "simple-mfd";
reg = <0x10000000 0x1000>;
- led@08.0 {
+ led@8.0 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x01>;
@@ -312,7 +312,7 @@ led@08.0 {
linux,default-trigger = "heartbeat";
default-state = "on";
};
- led@08.1 {
+ led@8.1 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x02>;
@@ -320,7 +320,7 @@ led@08.1 {
linux,default-trigger = "mmc0";
default-state = "off";
};
- led@08.2 {
+ led@8.2 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x04>;
@@ -328,7 +328,7 @@ led@08.2 {
linux,default-trigger = "cpu0";
default-state = "off";
};
- led@08.3 {
+ led@8.3 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x08>;
@@ -336,7 +336,7 @@ led@08.3 {
linux,default-trigger = "cpu1";
default-state = "off";
};
- led@08.4 {
+ led@8.4 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x10>;
@@ -344,7 +344,7 @@ led@08.4 {
linux,default-trigger = "cpu2";
default-state = "off";
};
- led@08.5 {
+ led@8.5 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x20>;
@@ -352,14 +352,14 @@ led@08.5 {
linux,default-trigger = "cpu3";
default-state = "off";
};
- led@08.6 {
+ led@8.6 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x40>;
label = "versatile:6";
default-state = "off";
};
- led@08.7 {
+ led@8.7 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x80>;
@@ -367,7 +367,7 @@ led@08.7 {
default-state = "off";
};
- oscclk0: osc0@0c {
+ oscclk0: osc0@c {
compatible = "arm,syscon-icst307";
#clock-cells = <0>;
lock-offset = <0x20>;
diff --git a/arch/arm/boot/dts/arm-realview-pbx.dtsi b/arch/arm/boot/dts/arm-realview-pbx.dtsi
index ccf6f756b6ed..535fe91d78a4 100644
--- a/arch/arm/boot/dts/arm-realview-pbx.dtsi
+++ b/arch/arm/boot/dts/arm-realview-pbx.dtsi
@@ -221,7 +221,7 @@ syscon: syscon@10000000 {
compatible = "arm,realview-pbx-syscon", "syscon", "simple-mfd";
reg = <0x10000000 0x1000>;
- led@08.0 {
+ led@8.0 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x01>;
@@ -229,7 +229,7 @@ led@08.0 {
linux,default-trigger = "heartbeat";
default-state = "on";
};
- led@08.1 {
+ led@8.1 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x02>;
@@ -237,7 +237,7 @@ led@08.1 {
linux,default-trigger = "mmc0";
default-state = "off";
};
- led@08.2 {
+ led@8.2 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x04>;
@@ -245,42 +245,42 @@ led@08.2 {
linux,default-trigger = "cpu0";
default-state = "off";
};
- led@08.3 {
+ led@8.3 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x08>;
label = "versatile:3";
default-state = "off";
};
- led@08.4 {
+ led@8.4 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x10>;
label = "versatile:4";
default-state = "off";
};
- led@08.5 {
+ led@8.5 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x20>;
label = "versatile:5";
default-state = "off";
};
- led@08.6 {
+ led@8.6 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x40>;
label = "versatile:6";
default-state = "off";
};
- led@08.7 {
+ led@8.7 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x80>;
label = "versatile:7";
default-state = "off";
};
- oscclk0: osc0@0c {
+ oscclk0: osc0@c {
compatible = "arm,syscon-icst307";
#clock-cells = <0>;
lock-offset = <0x20>;
diff --git a/arch/arm/boot/dts/versatile-ab-ib2.dts b/arch/arm/boot/dts/versatile-ab-ib2.dts
index c577ff4bb4be..74b851fdf11c 100644
--- a/arch/arm/boot/dts/versatile-ab-ib2.dts
+++ b/arch/arm/boot/dts/versatile-ab-ib2.dts
@@ -14,7 +14,7 @@ syscon@27000000 {
compatible = "arm,versatile-ib2-syscon", "syscon", "simple-mfd";
reg = <0x27000000 0x4>;
- led@00.4 {
+ led@0.4 {
compatible = "register-bit-led";
offset = <0x00>;
mask = <0x10>;
diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 151c0220047d..c12c4a3d4ff5 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -71,7 +71,7 @@ core-module@10000000 {
compatible = "arm,core-module-versatile", "syscon", "simple-mfd";
reg = <0x10000000 0x200>;
- led@08.0 {
+ led@8.0 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x01>;
@@ -79,7 +79,7 @@ led@08.0 {
linux,default-trigger = "heartbeat";
default-state = "on";
};
- led@08.1 {
+ led@8.1 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x02>;
@@ -87,7 +87,7 @@ led@08.1 {
linux,default-trigger = "mmc0";
default-state = "off";
};
- led@08.2 {
+ led@8.2 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x04>;
@@ -95,35 +95,35 @@ led@08.2 {
linux,default-trigger = "cpu0";
default-state = "off";
};
- led@08.3 {
+ led@8.3 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x08>;
label = "versatile:3";
default-state = "off";
};
- led@08.4 {
+ led@8.4 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x10>;
label = "versatile:4";
default-state = "off";
};
- led@08.5 {
+ led@8.5 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x20>;
label = "versatile:5";
default-state = "off";
};
- led@08.6 {
+ led@8.6 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x40>;
label = "versatile:6";
default-state = "off";
};
- led@08.7 {
+ led@8.7 {
compatible = "register-bit-led";
offset = <0x08>;
mask = <0x80>;
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/2] arm64: exynos: fix cpu unit name warnings
[not found] ` <20211013143744.caxMt32pqbKFMbKd_XpISelcE6Zu7zxKLuHeNLAs2e0@z>
@ 2021-10-13 14:37 ` Arnd Bergmann
[not found] ` <20211013150104.4s1xN55vWckFnvJmR4cfTYN2TtVmqm-GaFHs4zSvPYM@z>
0 siblings, 1 reply; 15+ messages in thread
From: Arnd Bergmann @ 2021-10-13 14:37 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Chanho Park
Cc: soc, Arnd Bergmann, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
dtc started warning about some of the CPU addresses:
arch/arm64/boot/dts/exynos/exynosautov9.dtsi:78.20-83.5: Warning (unit_address_format): /cpus/cpu@000000: unit name should not have leading 0s
arch/arm64/boot/dts/exynos/exynosautov9.dtsi:85.20-90.5: Warning (unit_address_format): /cpus/cpu@000100: unit name should not have leading 0s
arch/arm64/boot/dts/exynos/exynosautov9.dtsi:92.20-97.5: Warning (unit_address_format): /cpus/cpu@000200: unit name should not have leading 0s
arch/arm64/boot/dts/exynos/exynosautov9.dtsi:99.20-104.5: Warning (unit_address_format): /cpus/cpu@000300: unit name should not have leading 0s
Remove the leading zeroes.
Fixes: f695b3f4c45d ("arm64: dts: exynos: add initial support for exynosautov9 SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index 1dd1d73a52b8..284a7adb474a 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -75,28 +75,28 @@ core3 {
};
};
- cpu0: cpu@000000 {
+ cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a76";
reg = <0x0>;
enable-method = "psci";
};
- cpu1: cpu@000100 {
+ cpu1: cpu@100 {
device_type = "cpu";
compatible = "arm,cortex-a76";
reg = <0x100>;
enable-method = "psci";
};
- cpu2: cpu@000200 {
+ cpu2: cpu@200 {
device_type = "cpu";
compatible = "arm,cortex-a76";
reg = <0x200>;
enable-method = "psci";
};
- cpu3: cpu@000300 {
+ cpu3: cpu@300 {
device_type = "cpu";
compatible = "arm,cortex-a76";
reg = <0x300>;
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/2] arm64: exynos: fix cpu unit name warnings
[not found] ` <20211013150104.4s1xN55vWckFnvJmR4cfTYN2TtVmqm-GaFHs4zSvPYM@z>
@ 2021-10-13 15:01 ` Krzysztof Kozlowski
2021-10-13 15:01 ` Krzysztof Kozlowski
[not found] ` <20211013151239.Z1ZA-ZTBDUJGMgDoSwXKjKspBW8V5AHquP5jVIRFJFA@z>
0 siblings, 2 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-13 15:01 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rob Herring, Chanho Park, soc, Arnd Bergmann, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On Wed, 13 Oct 2021 at 16:38, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc started warning about some of the CPU addresses:
>
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:78.20-83.5: Warning (unit_address_format): /cpus/cpu@000000: unit name should not have leading 0s
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:85.20-90.5: Warning (unit_address_format): /cpus/cpu@000100: unit name should not have leading 0s
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:92.20-97.5: Warning (unit_address_format): /cpus/cpu@000200: unit name should not have leading 0s
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:99.20-104.5: Warning (unit_address_format): /cpus/cpu@000300: unit name should not have leading 0s
>
> Remove the leading zeroes.
>
> Fixes: f695b3f4c45d ("arm64: dts: exynos: add initial support for exynosautov9 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks Arnd, but this was fixed with the next version of patchset.
It's my bad because I did not drop the patch from my next branch after
spotting it, knowing that Chanho will resubmit the next day and then I
would replace it. This replacement happened next day but linux next
got the older/buggy patch.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/2] arm64: exynos: fix cpu unit name warnings
2021-10-13 15:01 ` Krzysztof Kozlowski
@ 2021-10-13 15:01 ` Krzysztof Kozlowski
[not found] ` <20211013151239.Z1ZA-ZTBDUJGMgDoSwXKjKspBW8V5AHquP5jVIRFJFA@z>
1 sibling, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-13 15:01 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rob Herring, Chanho Park, soc, Arnd Bergmann, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On Wed, 13 Oct 2021 at 16:38, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc started warning about some of the CPU addresses:
>
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:78.20-83.5: Warning (unit_address_format): /cpus/cpu@000000: unit name should not have leading 0s
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:85.20-90.5: Warning (unit_address_format): /cpus/cpu@000100: unit name should not have leading 0s
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:92.20-97.5: Warning (unit_address_format): /cpus/cpu@000200: unit name should not have leading 0s
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi:99.20-104.5: Warning (unit_address_format): /cpus/cpu@000300: unit name should not have leading 0s
>
> Remove the leading zeroes.
>
> Fixes: f695b3f4c45d ("arm64: dts: exynos: add initial support for exynosautov9 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks Arnd, but this was fixed with the next version of patchset.
It's my bad because I did not drop the patch from my next branch after
spotting it, knowing that Chanho will resubmit the next day and then I
would replace it. This replacement happened next day but linux next
got the older/buggy patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/2] arm64: exynos: fix cpu unit name warnings
[not found] ` <20211013151239.Z1ZA-ZTBDUJGMgDoSwXKjKspBW8V5AHquP5jVIRFJFA@z>
@ 2021-10-13 15:12 ` Arnd Bergmann
0 siblings, 0 replies; 15+ messages in thread
From: Arnd Bergmann @ 2021-10-13 15:12 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Chanho Park, SoC Team, Arnd Bergmann, DTML,
Linux ARM, linux-samsung-soc, linux-kernel
On Wed, Oct 13, 2021 at 5:01 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
> On Wed, 13 Oct 2021 at 16:38, Arnd Bergmann <arnd@kernel.org> wrote:
>
> Thanks Arnd, but this was fixed with the next version of patchset.
> It's my bad because I did not drop the patch from my next branch after
> spotting it, knowing that Chanho will resubmit the next day and then I
> would replace it. This replacement happened next day but linux next
> got the older/buggy patch.
Ok, I see it now. Looks like I forgot to rebase onto the latest next/master
before testing my patches today.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
[not found] ` <20211013234314.W5p7gfBueySxPRt8Fd8B8o35myHIxRU4SNzeB95W8a8@z>
@ 2021-10-13 23:43 ` Linus Walleij
2021-10-13 23:43 ` Linus Walleij
0 siblings, 1 reply; 15+ messages in thread
From: Linus Walleij @ 2021-10-13 23:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rob Herring, Arnd Bergmann, Liviu Dudau, SoC Team,
Greg Kroah-Hartman, Rui Miguel Silva, Sudeep Holla, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Oct 13, 2021 at 4:38 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc now warns for the LED nodes on the versatile-ab board:
>
> versatile-ab.dts:126.12-132.5: Warning (unit_address_format): /core-module@10000000/led@08.7: unit name should not have leading 0s
> versatile-ab-ib2.dts:17.12-24.5: Warning (unit_address_format): /syscon@27000000/led@00.4: unit name should not have leading 0s
>
> Remove the extra zeroes.
>
> Fixes: 07ebfa59b9db ("ARM: versatile: add the syscon LEDs to the DT")
> Fixes: 7fbe5f7ff267 ("ARM: dts: Add Versatile IB2 device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fair enough,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Can you apply/send this directly to the SoC tree?
I don't have any other changes for Versatile this merge
window.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-13 23:43 ` [PATCH 1/2] ARM: versatile: remove leading 0 on unit address Linus Walleij
@ 2021-10-13 23:43 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2021-10-13 23:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rob Herring, Arnd Bergmann, Liviu Dudau, SoC Team,
Greg Kroah-Hartman, Rui Miguel Silva, Sudeep Holla, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Oct 13, 2021 at 4:38 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc now warns for the LED nodes on the versatile-ab board:
>
> versatile-ab.dts:126.12-132.5: Warning (unit_address_format): /core-module@10000000/led@08.7: unit name should not have leading 0s
> versatile-ab-ib2.dts:17.12-24.5: Warning (unit_address_format): /syscon@27000000/led@00.4: unit name should not have leading 0s
>
> Remove the extra zeroes.
>
> Fixes: 07ebfa59b9db ("ARM: versatile: add the syscon LEDs to the DT")
> Fixes: 7fbe5f7ff267 ("ARM: dts: Add Versatile IB2 device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fair enough,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Can you apply/send this directly to the SoC tree?
I don't have any other changes for Versatile this merge
window.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
[not found] ` <20211014005322.UKmTWDI2VngfYgBKGmJObzYakZMzNfpqGSao9HCsHsw@z>
@ 2021-10-14 0:53 ` Rob Herring
2021-10-21 20:48 ` Arnd Bergmann
0 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2021-10-14 0:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Arnd Bergmann, Liviu Dudau, SoC Team,
Greg Kroah-Hartman, Rui Miguel Silva, Sudeep Holla,
linux-arm-kernel, devicetree, linux-kernel
On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc now warns for the LED nodes on the versatile-ab board:
>
> versatile-ab.dts:126.12-132.5: Warning (unit_address_format): /core-module@10000000/led@08.7: unit name should not have leading 0s
> versatile-ab-ib2.dts:17.12-24.5: Warning (unit_address_format): /syscon@27000000/led@00.4: unit name should not have leading 0s
>
> Remove the extra zeroes.
>
> Fixes: 07ebfa59b9db ("ARM: versatile: add the syscon LEDs to the DT")
> Fixes: 7fbe5f7ff267 ("ARM: dts: Add Versatile IB2 device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/boot/dts/arm-realview-eb.dtsi | 18 +++++++++---------
> arch/arm/boot/dts/arm-realview-pb1176.dts | 18 +++++++++---------
> arch/arm/boot/dts/arm-realview-pb11mp.dts | 18 +++++++++---------
> arch/arm/boot/dts/arm-realview-pbx.dtsi | 18 +++++++++---------
> arch/arm/boot/dts/versatile-ab-ib2.dts | 2 +-
> arch/arm/boot/dts/versatile-ab.dts | 16 ++++++++--------
> 6 files changed, 45 insertions(+), 45 deletions(-)
Please apply these instead:
https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
There's also also these fixes that I sent:
https://lore.kernel.org/all/20210928192143.1841497-1-robh@kernel.org/
https://lore.kernel.org/all/20210928192210.1842377-1-robh@kernel.org/
https://lore.kernel.org/all/20210928192123.1840842-1-robh@kernel.org/
https://lore.kernel.org/all/20210928191759.1835325-1-robh@kernel.org/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-14 0:53 ` Rob Herring
@ 2021-10-21 20:48 ` Arnd Bergmann
2021-10-21 20:48 ` Arnd Bergmann
2021-10-21 21:10 ` Rob Herring
0 siblings, 2 replies; 15+ messages in thread
From: Arnd Bergmann @ 2021-10-21 20:48 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, Arnd Bergmann, Liviu Dudau, SoC Team,
Greg Kroah-Hartman, Rui Miguel Silva, Sudeep Holla,
linux-arm-kernel, DTML, linux-kernel
On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> Please apply these instead:
> https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
>
> There's also also these fixes that I sent:
> https://lore.kernel.org/all/20210928192143.1841497-1-robh@kernel.org/
> https://lore.kernel.org/all/20210928192210.1842377-1-robh@kernel.org/
> https://lore.kernel.org/all/20210928192123.1840842-1-robh@kernel.org/
> https://lore.kernel.org/all/20210928191759.1835325-1-robh@kernel.org/
Is this list still up to date? It looks like some of these are already
in linux-next
by now, so I'm not sure which ones to apply. Could you send the ones that
you want me to take to soc@kernel.org?
Arnd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-21 20:48 ` Arnd Bergmann
@ 2021-10-21 20:48 ` Arnd Bergmann
2021-10-21 21:10 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Arnd Bergmann @ 2021-10-21 20:48 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, Arnd Bergmann, Liviu Dudau, SoC Team,
Greg Kroah-Hartman, Rui Miguel Silva, Sudeep Holla,
linux-arm-kernel, DTML, linux-kernel
On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> Please apply these instead:
> https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
>
> There's also also these fixes that I sent:
> https://lore.kernel.org/all/20210928192143.1841497-1-robh@kernel.org/
> https://lore.kernel.org/all/20210928192210.1842377-1-robh@kernel.org/
> https://lore.kernel.org/all/20210928192123.1840842-1-robh@kernel.org/
> https://lore.kernel.org/all/20210928191759.1835325-1-robh@kernel.org/
Is this list still up to date? It looks like some of these are already
in linux-next
by now, so I'm not sure which ones to apply. Could you send the ones that
you want me to take to soc@kernel.org?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-21 20:48 ` Arnd Bergmann
2021-10-21 20:48 ` Arnd Bergmann
@ 2021-10-21 21:10 ` Rob Herring
2021-10-21 21:10 ` Rob Herring
2021-10-24 23:16 ` Linus Walleij
1 sibling, 2 replies; 15+ messages in thread
From: Rob Herring @ 2021-10-21 21:10 UTC (permalink / raw)
To: Arnd Bergmann, Linus Walleij, Viresh Kumar, Bjorn Andersson
Cc: Arnd Bergmann, Liviu Dudau, SoC Team, Greg Kroah-Hartman,
Rui Miguel Silva, Sudeep Holla, linux-arm-kernel, DTML,
linux-kernel
On Thu, Oct 21, 2021 at 3:49 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> > On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > Please apply these instead:
> > https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> > https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
Linus?
> >
> > There's also also these fixes that I sent:
> > https://lore.kernel.org/all/20210928192143.1841497-1-robh@kernel.org/
Viresh?
> > https://lore.kernel.org/all/20210928192210.1842377-1-robh@kernel.org/
Bjorn?
> > https://lore.kernel.org/all/20210928192123.1840842-1-robh@kernel.org/
> > https://lore.kernel.org/all/20210928191759.1835325-1-robh@kernel.org/
These 2 are the only ones in next.
> Is this list still up to date? It looks like some of these are already
> in linux-next
> by now, so I'm not sure which ones to apply. Could you send the ones that
> you want me to take to soc@kernel.org?
Splitting up dts fixes by sub-arch only to have them ignored and have
to chase down the status or resend really doesn't motivate me to fix
anything.
Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-21 21:10 ` Rob Herring
@ 2021-10-21 21:10 ` Rob Herring
2021-10-24 23:16 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-10-21 21:10 UTC (permalink / raw)
To: Arnd Bergmann, Linus Walleij, Viresh Kumar, Bjorn Andersson
Cc: Arnd Bergmann, Liviu Dudau, SoC Team, Greg Kroah-Hartman,
Rui Miguel Silva, Sudeep Holla, linux-arm-kernel, DTML,
linux-kernel
On Thu, Oct 21, 2021 at 3:49 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> > On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > Please apply these instead:
> > https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> > https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
Linus?
> >
> > There's also also these fixes that I sent:
> > https://lore.kernel.org/all/20210928192143.1841497-1-robh@kernel.org/
Viresh?
> > https://lore.kernel.org/all/20210928192210.1842377-1-robh@kernel.org/
Bjorn?
> > https://lore.kernel.org/all/20210928192123.1840842-1-robh@kernel.org/
> > https://lore.kernel.org/all/20210928191759.1835325-1-robh@kernel.org/
These 2 are the only ones in next.
> Is this list still up to date? It looks like some of these are already
> in linux-next
> by now, so I'm not sure which ones to apply. Could you send the ones that
> you want me to take to soc@kernel.org?
Splitting up dts fixes by sub-arch only to have them ignored and have
to chase down the status or resend really doesn't motivate me to fix
anything.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-21 21:10 ` Rob Herring
2021-10-21 21:10 ` Rob Herring
@ 2021-10-24 23:16 ` Linus Walleij
2021-10-24 23:16 ` Linus Walleij
2021-10-24 23:16 ` Linus Walleij
1 sibling, 2 replies; 15+ messages in thread
From: Linus Walleij @ 2021-10-24 23:16 UTC (permalink / raw)
To: Rob Herring
Cc: Arnd Bergmann, Viresh Kumar, Bjorn Andersson, Arnd Bergmann,
Liviu Dudau, SoC Team, Greg Kroah-Hartman, Rui Miguel Silva,
Sudeep Holla, linux-arm-kernel, DTML, linux-kernel
On Thu, Oct 21, 2021 at 11:10 PM Rob Herring <robh@kernel.org> wrote:
> On Thu, Oct 21, 2021 at 3:49 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> > > On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > Please apply these instead:
> > > https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> > > https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
>
> Linus?
I don't recognize these patches, no idea why I have missed them :(
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Arnd, please feel free to go ahead and apply these.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-24 23:16 ` Linus Walleij
2021-10-24 23:16 ` Linus Walleij
@ 2021-10-24 23:16 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2021-10-24 23:16 UTC (permalink / raw)
To: Rob Herring
Cc: Arnd Bergmann, Viresh Kumar, Bjorn Andersson, Arnd Bergmann,
Liviu Dudau, SoC Team, Greg Kroah-Hartman, Rui Miguel Silva,
Sudeep Holla, linux-arm-kernel, DTML, linux-kernel
On Thu, Oct 21, 2021 at 11:10 PM Rob Herring <robh@kernel.org> wrote:
> On Thu, Oct 21, 2021 at 3:49 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> > > On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > Please apply these instead:
> > > https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> > > https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
>
> Linus?
I don't recognize these patches, no idea why I have missed them :(
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Arnd, please feel free to go ahead and apply these.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: versatile: remove leading 0 on unit address
2021-10-24 23:16 ` Linus Walleij
@ 2021-10-24 23:16 ` Linus Walleij
2021-10-24 23:16 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2021-10-24 23:16 UTC (permalink / raw)
To: Rob Herring
Cc: Arnd Bergmann, Viresh Kumar, Bjorn Andersson, Arnd Bergmann,
Liviu Dudau, SoC Team, Greg Kroah-Hartman, Rui Miguel Silva,
Sudeep Holla, linux-arm-kernel, DTML, linux-kernel
On Thu, Oct 21, 2021 at 11:10 PM Rob Herring <robh@kernel.org> wrote:
> On Thu, Oct 21, 2021 at 3:49 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > On Thu, Oct 14, 2021 at 2:53 AM Rob Herring <robh+dt@kernel.org> wrote:
> > > On Wed, Oct 13, 2021 at 9:38 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > Please apply these instead:
> > > https://lore.kernel.org/all/20210913192816.1225025-7-robh@kernel.org/
> > > https://lore.kernel.org/all/20210913192816.1225025-8-robh@kernel.org/
>
> Linus?
I don't recognize these patches, no idea why I have missed them :(
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Arnd, please feel free to go ahead and apply these.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-10-24 23:18 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211013143743.we1yI8NZ9sPL5u79YVoSyliKHyEpm-YCM0UT3Y2guTE@z>
2021-10-13 14:37 ` [PATCH 1/2] ARM: versatile: remove leading 0 on unit address Arnd Bergmann
[not found] ` <20211013143744.caxMt32pqbKFMbKd_XpISelcE6Zu7zxKLuHeNLAs2e0@z>
2021-10-13 14:37 ` [PATCH 2/2] arm64: exynos: fix cpu unit name warnings Arnd Bergmann
[not found] ` <20211013150104.4s1xN55vWckFnvJmR4cfTYN2TtVmqm-GaFHs4zSvPYM@z>
2021-10-13 15:01 ` Krzysztof Kozlowski
2021-10-13 15:01 ` Krzysztof Kozlowski
[not found] ` <20211013151239.Z1ZA-ZTBDUJGMgDoSwXKjKspBW8V5AHquP5jVIRFJFA@z>
2021-10-13 15:12 ` Arnd Bergmann
[not found] ` <20211013234314.W5p7gfBueySxPRt8Fd8B8o35myHIxRU4SNzeB95W8a8@z>
2021-10-13 23:43 ` [PATCH 1/2] ARM: versatile: remove leading 0 on unit address Linus Walleij
2021-10-13 23:43 ` Linus Walleij
[not found] ` <20211014005322.UKmTWDI2VngfYgBKGmJObzYakZMzNfpqGSao9HCsHsw@z>
2021-10-14 0:53 ` Rob Herring
2021-10-21 20:48 ` Arnd Bergmann
2021-10-21 20:48 ` Arnd Bergmann
2021-10-21 21:10 ` Rob Herring
2021-10-21 21:10 ` Rob Herring
2021-10-24 23:16 ` Linus Walleij
2021-10-24 23:16 ` Linus Walleij
2021-10-24 23:16 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).