soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts
@ 2023-09-01  6:25 Binbin Zhou
  2023-09-01  6:25 ` [PATCH 1/2] soc: loongson: loongson2_guts: Convert to devm_platform_ioremap_resource() Binbin Zhou
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Binbin Zhou @ 2023-09-01  6:25 UTC (permalink / raw)
  To: Binbin Zhou, Huacai Chen, Yinbo Zhu, Arnd Bergmann
  Cc: Huacai Chen, loongson-kernel, soc, Xuerui Wang, loongarch, Binbin Zhou

Hi All:

I noticed that there were some minor changes to loongson2_guts on the
mailing list earlier, but they were put on hold because they were not
cc'd to the appropriate people (Arnd & soc@kernel.org).

I'd like to try to gather them together and resubmit them.

For patch[1], I modified the patch to use generic functions and
simplify the code.

Original link:
patch[1]: https://lore.kernel.org/loongarch/20230306025308.248987-1-dzm91@hust.edu.cn/
patch[2]: https://lore.kernel.org/loongarch/a69170cb55cfc73e378b40ccf1d9c16f@208suo.com/

Thanks.

Dongliang Mu (1):
  soc: loongson: loongson2_guts: Convert to
    devm_platform_ioremap_resource()

Mingtong Bao (1):
  soc: loongson: loongson2_guts: Remove unneeded semicolon

 drivers/soc/loongson/loongson2_guts.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.39.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] soc: loongson: loongson2_guts: Convert to devm_platform_ioremap_resource()
  2023-09-01  6:25 [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts Binbin Zhou
@ 2023-09-01  6:25 ` Binbin Zhou
  2023-09-01  6:25 ` [PATCH 2/2] soc: loongson: loongson2_guts: Remove unneeded semicolon Binbin Zhou
  2023-09-26 21:03 ` [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: Binbin Zhou @ 2023-09-01  6:25 UTC (permalink / raw)
  To: Binbin Zhou, Huacai Chen, Yinbo Zhu, Arnd Bergmann
  Cc: Huacai Chen, loongson-kernel, soc, Xuerui Wang, loongarch,
	Dongliang Mu, Binbin Zhou

From: Dongliang Mu <dzm91@hust.edu.cn>

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
---
 drivers/soc/loongson/loongson2_guts.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/loongson/loongson2_guts.c b/drivers/soc/loongson/loongson2_guts.c
index bace4bc8e03b..d97c77a9a4a2 100644
--- a/drivers/soc/loongson/loongson2_guts.c
+++ b/drivers/soc/loongson/loongson2_guts.c
@@ -94,7 +94,6 @@ static int loongson2_guts_probe(struct platform_device *pdev)
 {
 	struct device_node *root, *np = pdev->dev.of_node;
 	struct device *dev = &pdev->dev;
-	struct resource *res;
 	const struct loongson2_soc_die_attr *soc_die;
 	const char *machine;
 	u32 svr;
@@ -106,8 +105,7 @@ static int loongson2_guts_probe(struct platform_device *pdev)
 
 	guts->little_endian = of_property_read_bool(np, "little-endian");
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	guts->regs = ioremap(res->start, res->end - res->start + 1);
+	guts->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(guts->regs))
 		return PTR_ERR(guts->regs);
 
-- 
2.39.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] soc: loongson: loongson2_guts: Remove unneeded semicolon
  2023-09-01  6:25 [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts Binbin Zhou
  2023-09-01  6:25 ` [PATCH 1/2] soc: loongson: loongson2_guts: Convert to devm_platform_ioremap_resource() Binbin Zhou
@ 2023-09-01  6:25 ` Binbin Zhou
  2023-09-26 21:03 ` [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: Binbin Zhou @ 2023-09-01  6:25 UTC (permalink / raw)
  To: Binbin Zhou, Huacai Chen, Yinbo Zhu, Arnd Bergmann
  Cc: Huacai Chen, loongson-kernel, soc, Xuerui Wang, loongarch, Mingtong Bao

From: Mingtong Bao <baomingtong001@208suo.com>

No functional modification involved.

./drivers/soc/loongson/loongson2_guts.c:73:2-3: Unneeded semicolon.

Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
 drivers/soc/loongson/loongson2_guts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/loongson/loongson2_guts.c b/drivers/soc/loongson/loongson2_guts.c
index d97c77a9a4a2..9a469779eea7 100644
--- a/drivers/soc/loongson/loongson2_guts.c
+++ b/drivers/soc/loongson/loongson2_guts.c
@@ -70,7 +70,7 @@ static const struct loongson2_soc_die_attr *loongson2_soc_die_match(
 		if (matches->svr == (svr & matches->mask))
 			return matches;
 		matches++;
-	};
+	}
 
 	return NULL;
 }
-- 
2.39.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts
  2023-09-01  6:25 [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts Binbin Zhou
  2023-09-01  6:25 ` [PATCH 1/2] soc: loongson: loongson2_guts: Convert to devm_platform_ioremap_resource() Binbin Zhou
  2023-09-01  6:25 ` [PATCH 2/2] soc: loongson: loongson2_guts: Remove unneeded semicolon Binbin Zhou
@ 2023-09-26 21:03 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2023-09-26 21:03 UTC (permalink / raw)
  To: Binbin Zhou; +Cc: soc

Hello:

This series was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:

On Fri,  1 Sep 2023 14:25:47 +0800 you wrote:
> Hi All:
> 
> I noticed that there were some minor changes to loongson2_guts on the
> mailing list earlier, but they were put on hold because they were not
> cc'd to the appropriate people (Arnd & soc@kernel.org).
> 
> I'd like to try to gather them together and resubmit them.
> 
> [...]

Here is the summary with links:
  - [1/2] soc: loongson: loongson2_guts: Convert to devm_platform_ioremap_resource()
    https://git.kernel.org/soc/soc/c/840844c26239
  - [2/2] soc: loongson: loongson2_guts: Remove unneeded semicolon
    https://git.kernel.org/soc/soc/c/e756ce123c9a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-26 21:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01  6:25 [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts Binbin Zhou
2023-09-01  6:25 ` [PATCH 1/2] soc: loongson: loongson2_guts: Convert to devm_platform_ioremap_resource() Binbin Zhou
2023-09-01  6:25 ` [PATCH 2/2] soc: loongson: loongson2_guts: Remove unneeded semicolon Binbin Zhou
2023-09-26 21:03 ` [PATCH 0/2] soc: loongson: Fix some issues about loongson2_guts patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).