* [PATCH] ARM: at91: use proper asm syntax in pm_suspend
@ 2021-02-04 16:01 Arnd Bergmann
2021-02-04 16:01 ` Arnd Bergmann
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Arnd Bergmann @ 2021-02-04 16:01 UTC (permalink / raw)
To: Russell King, Nicolas Ferre, Alexandre Belloni,
Ludovic Desroches, Nathan Chancellor, Nick Desaulniers,
Claudiu Beznea
Cc: soc, Arnd Bergmann, Stephen Boyd, clang-built-linux,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Compiling with the clang integrated assembler warns about
a recently added instruction:
<instantiation>:14:13: error: unknown token in expression
ldr tmp1, =#0x00020010UL
arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
at91_plla_enable
Remove the extra '#' character that is not used for the 'ldr'
instruction when doing an indirect load of a constant.
Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-at91/pm_suspend.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
index 909856c8a8c6..0d467cc40129 100644
--- a/arch/arm/mach-at91/pm_suspend.S
+++ b/arch/arm/mach-at91/pm_suspend.S
@@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
/* step 2. */
- ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
+ ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
str tmp1, [pmc, #AT91_PMC_PLL_ACR]
/* step 3. */
--
2.29.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
@ 2021-02-04 16:01 ` Arnd Bergmann
2021-02-04 18:18 ` Claudiu.Beznea
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2021-02-04 16:01 UTC (permalink / raw)
To: Russell King, Nicolas Ferre, Alexandre Belloni,
Ludovic Desroches, Nathan Chancellor, Nick Desaulniers,
Claudiu Beznea
Cc: Arnd Bergmann, Stephen Boyd, linux-kernel, clang-built-linux,
soc, linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Compiling with the clang integrated assembler warns about
a recently added instruction:
<instantiation>:14:13: error: unknown token in expression
ldr tmp1, =#0x00020010UL
arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
at91_plla_enable
Remove the extra '#' character that is not used for the 'ldr'
instruction when doing an indirect load of a constant.
Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-at91/pm_suspend.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
index 909856c8a8c6..0d467cc40129 100644
--- a/arch/arm/mach-at91/pm_suspend.S
+++ b/arch/arm/mach-at91/pm_suspend.S
@@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
/* step 2. */
- ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
+ ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
str tmp1, [pmc, #AT91_PMC_PLL_ACR]
/* step 3. */
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
2021-02-04 16:01 ` Arnd Bergmann
@ 2021-02-04 18:18 ` Claudiu.Beznea
2021-02-04 18:18 ` Claudiu.Beznea
2021-02-04 18:43 ` Nicolas Ferre
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Claudiu.Beznea @ 2021-02-04 18:18 UTC (permalink / raw)
To: arnd, linux, Nicolas.Ferre, alexandre.belloni, Ludovic.Desroches,
nathan, ndesaulniers
Cc: soc, arnd, sboyd, clang-built-linux, linux-arm-kernel, linux-kernel
On 04.02.2021 18:01, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 18:18 ` Claudiu.Beznea
@ 2021-02-04 18:18 ` Claudiu.Beznea
0 siblings, 0 replies; 9+ messages in thread
From: Claudiu.Beznea @ 2021-02-04 18:18 UTC (permalink / raw)
To: arnd, linux, Nicolas.Ferre, alexandre.belloni, Ludovic.Desroches,
nathan, ndesaulniers
Cc: arnd, sboyd, linux-kernel, clang-built-linux, soc, linux-arm-kernel
On 04.02.2021 18:01, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
2021-02-04 16:01 ` Arnd Bergmann
2021-02-04 18:18 ` Claudiu.Beznea
@ 2021-02-04 18:43 ` Nicolas Ferre
2021-02-04 18:43 ` Nicolas Ferre
2021-02-04 18:49 ` Nathan Chancellor
2021-02-09 16:40 ` patchwork-bot+linux-soc
4 siblings, 1 reply; 9+ messages in thread
From: Nicolas Ferre @ 2021-02-04 18:43 UTC (permalink / raw)
To: Arnd Bergmann, Russell King, Alexandre Belloni,
Ludovic Desroches, Nathan Chancellor, Nick Desaulniers,
Claudiu Beznea
Cc: soc, Arnd Bergmann, Stephen Boyd, clang-built-linux,
linux-arm-kernel, linux-kernel
On 04/02/2021 at 17:01, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks!
Best regards,
Nicolas
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 18:43 ` Nicolas Ferre
@ 2021-02-04 18:43 ` Nicolas Ferre
0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Ferre @ 2021-02-04 18:43 UTC (permalink / raw)
To: Arnd Bergmann, Russell King, Alexandre Belloni,
Ludovic Desroches, Nathan Chancellor, Nick Desaulniers,
Claudiu Beznea
Cc: Arnd Bergmann, Stephen Boyd, linux-kernel, clang-built-linux,
soc, linux-arm-kernel
On 04/02/2021 at 17:01, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks!
Best regards,
Nicolas
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
` (2 preceding siblings ...)
2021-02-04 18:43 ` Nicolas Ferre
@ 2021-02-04 18:49 ` Nathan Chancellor
2021-02-04 18:49 ` Nathan Chancellor
2021-02-09 16:40 ` patchwork-bot+linux-soc
4 siblings, 1 reply; 9+ messages in thread
From: Nathan Chancellor @ 2021-02-04 18:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Russell King, Nicolas Ferre, Alexandre Belloni,
Ludovic Desroches, Nick Desaulniers, Claudiu Beznea, soc,
Arnd Bergmann, Stephen Boyd, clang-built-linux, linux-arm-kernel,
linux-kernel
On Thu, Feb 04, 2021 at 05:01:20PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 18:49 ` Nathan Chancellor
@ 2021-02-04 18:49 ` Nathan Chancellor
0 siblings, 0 replies; 9+ messages in thread
From: Nathan Chancellor @ 2021-02-04 18:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alexandre Belloni, Arnd Bergmann, clang-built-linux, soc,
linux-kernel, Nick Desaulniers, Russell King, Stephen Boyd,
Ludovic Desroches, Claudiu Beznea, linux-arm-kernel
On Thu, Feb 04, 2021 at 05:01:20PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
` (3 preceding siblings ...)
2021-02-04 18:49 ` Nathan Chancellor
@ 2021-02-09 16:40 ` patchwork-bot+linux-soc
4 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+linux-soc @ 2021-02-09 16:40 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: soc
Hello:
This patch was applied to soc/soc.git (refs/heads/arm/fixes):
On Thu, 4 Feb 2021 17:01:20 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> [...]
Here is the summary with links:
- ARM: at91: use proper asm syntax in pm_suspend
https://git.kernel.org/soc/soc/c/d30337da8677
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-09 16:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
2021-02-04 16:01 ` Arnd Bergmann
2021-02-04 18:18 ` Claudiu.Beznea
2021-02-04 18:18 ` Claudiu.Beznea
2021-02-04 18:43 ` Nicolas Ferre
2021-02-04 18:43 ` Nicolas Ferre
2021-02-04 18:49 ` Nathan Chancellor
2021-02-04 18:49 ` Nathan Chancellor
2021-02-09 16:40 ` patchwork-bot+linux-soc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).