stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Aw: [PATCH 3/3] mmc: mediatek: add optional module reset property
       [not found] ` <20200812093726.10123-4-wenbin.mei@mediatek.com>
@ 2020-08-12 10:07   ` Frank Wunderlich
  2020-08-12 11:55     ` Wenbin Mei
  0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2020-08-12 10:07 UTC (permalink / raw)
  To: Wenbin Mei
  Cc: Ulf Hansson, Rob Herring, devicetree, Wenbin Mei, srv_heupstream,
	linux-mmc, linux-kernel, linux-mediatek, linux-arm-kernel,
	Philipp Zabel, Matthias Brugger, Chaotian Jing, stable

> Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> Von: "Wenbin Mei" <wenbin.mei@mediatek.com>
> Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property

> This patch adds a optional reset management for msdc.
> Sometimes the bootloader does not bring msdc register
> to default state, so need reset the msdc controller.
>
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>

Thanks for posting the fix to Mainline

imho this should contain a fixes-Tag as it fixes eMMC-Access on mt7622/Bpi-R64

before we got these Errors on mounting eMMC ion R64:

[   48.664925] blk_update_request: I/O error, dev mmcblk0, sector 204800 op 0x1:(WRITE) flags 0x800 phys_seg 1 prio class 0
[   48.676019] Buffer I/O error on dev mmcblk0p1, logical block 0, lost sync page write

Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
Tested-By: Frank Wunderlich <frank-w@public-files.de>

and it needs to be fixed at least for 5.4+, so adding stable-CC

Cc: stable@vger.kernel.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Aw: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device
       [not found] ` <20200812093726.10123-3-wenbin.mei@mediatek.com>
@ 2020-08-12 10:33   ` Frank Wunderlich
  2020-08-12 11:57     ` Wenbin Mei
  0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2020-08-12 10:33 UTC (permalink / raw)
  To: Wenbin Mei
  Cc: Ulf Hansson, Rob Herring, devicetree, Wenbin Mei, srv_heupstream,
	linux-mmc, linux-kernel, linux-mediatek, linux-arm-kernel,
	Philipp Zabel, Matthias Brugger, Chaotian Jing, stable

> Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> Von: "Wenbin Mei" <wenbin.mei@mediatek.com>
> Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property

> This patch adds a optional reset management for msdc.
> Sometimes the bootloader does not bring msdc register
> to default state, so need reset the msdc controller.
>
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>

Thanks for posting the fix to Mainline
same as 3/3, dts-patch is also needed for fixing eMMC-Issue on R64

Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
Tested-By: Frank Wunderlich <frank-w@public-files.de>

and it needs to be fixed at least for 5.4+, so adding stable-CC

Cc: stable@vger.kernel.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Aw: [PATCH 3/3] mmc: mediatek: add optional module reset property
  2020-08-12 10:07   ` Aw: [PATCH 3/3] mmc: mediatek: add optional module reset property Frank Wunderlich
@ 2020-08-12 11:55     ` Wenbin Mei
  0 siblings, 0 replies; 4+ messages in thread
From: Wenbin Mei @ 2020-08-12 11:55 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: Ulf Hansson, Rob Herring, devicetree, srv_heupstream, linux-mmc,
	linux-kernel, linux-mediatek, linux-arm-kernel, Philipp Zabel,
	Matthias Brugger, Chaotian Jing, stable

Thanks for your reply.
I will add this in the next version.
On Wed, 2020-08-12 at 12:07 +0200, Frank Wunderlich wrote:
> > Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> > Von: "Wenbin Mei" <wenbin.mei@mediatek.com>
> > Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property
> 
> > This patch adds a optional reset management for msdc.
> > Sometimes the bootloader does not bring msdc register
> > to default state, so need reset the msdc controller.
> >
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> 
> Thanks for posting the fix to Mainline
> 
> imho this should contain a fixes-Tag as it fixes eMMC-Access on mt7622/Bpi-R64
> 
> before we got these Errors on mounting eMMC ion R64:
> 
> [   48.664925] blk_update_request: I/O error, dev mmcblk0, sector 204800 op 0x1:(WRITE) flags 0x800 phys_seg 1 prio class 0
> [   48.676019] Buffer I/O error on dev mmcblk0p1, logical block 0, lost sync page write
> 
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Tested-By: Frank Wunderlich <frank-w@public-files.de>
> 
> and it needs to be fixed at least for 5.4+, so adding stable-CC
> 
> Cc: stable@vger.kernel.org


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Aw: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device
  2020-08-12 10:33   ` Aw: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device Frank Wunderlich
@ 2020-08-12 11:57     ` Wenbin Mei
  0 siblings, 0 replies; 4+ messages in thread
From: Wenbin Mei @ 2020-08-12 11:57 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: Ulf Hansson, Rob Herring, devicetree, srv_heupstream, linux-mmc,
	linux-kernel, linux-mediatek, linux-arm-kernel, Philipp Zabel,
	Matthias Brugger, Chaotian Jing, stable

Thanks for your reply.
I will add this in the next version.
On Wed, 2020-08-12 at 12:33 +0200, Frank Wunderlich wrote:
> > Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> > Von: "Wenbin Mei" <wenbin.mei@mediatek.com>
> > Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property
> 
> > This patch adds a optional reset management for msdc.
> > Sometimes the bootloader does not bring msdc register
> > to default state, so need reset the msdc controller.
> >
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> 
> Thanks for posting the fix to Mainline
> same as 3/3, dts-patch is also needed for fixing eMMC-Issue on R64
> 
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Tested-By: Frank Wunderlich <frank-w@public-files.de>
> 
> and it needs to be fixed at least for 5.4+, so adding stable-CC
> 
> Cc: stable@vger.kernel.org


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-12 11:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200812093726.10123-1-wenbin.mei@mediatek.com>
     [not found] ` <20200812093726.10123-4-wenbin.mei@mediatek.com>
2020-08-12 10:07   ` Aw: [PATCH 3/3] mmc: mediatek: add optional module reset property Frank Wunderlich
2020-08-12 11:55     ` Wenbin Mei
     [not found] ` <20200812093726.10123-3-wenbin.mei@mediatek.com>
2020-08-12 10:33   ` Aw: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device Frank Wunderlich
2020-08-12 11:57     ` Wenbin Mei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).