stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250
       [not found] <20220208171823.226211-1-krzysztof.kozlowski@canonical.com>
@ 2022-02-08 17:18 ` Krzysztof Kozlowski
  2022-02-10  3:03   ` Alim Akhtar
  2022-02-12 16:37   ` (subset) " Krzysztof Kozlowski
  2022-02-08 17:18 ` [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420 Krzysztof Kozlowski
  1 sibling, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-08 17:18 UTC (permalink / raw)
  To: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Alim Akhtar, Kishon Vijay Abraham I, Vinod Koul, dri-devel,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	linux-phy
  Cc: Marek Szyprowski, Sylwester Nawrocki, stable

Add required VDD supplies to HDMI block on SMDK5250.  Without them, the
HDMI driver won't probe.  Because of lack of schematics, use same
supplies as on Arndale 5250 board (voltage matches).

Cc: <stable@vger.kernel.org> # v3.15+
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 65d2474f83eb..21fbbf3d8684 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -118,6 +118,9 @@ &hdmi {
 	status = "okay";
 	ddc = <&i2c_2>;
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
+	vdd-supply = <&ldo8_reg>;
+	vdd_osc-supply = <&ldo10_reg>;
+	vdd_pll-supply = <&ldo8_reg>;
 };
 
 &i2c_0 {
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420
       [not found] <20220208171823.226211-1-krzysztof.kozlowski@canonical.com>
  2022-02-08 17:18 ` [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250 Krzysztof Kozlowski
@ 2022-02-08 17:18 ` Krzysztof Kozlowski
  2022-02-10  4:03   ` Alim Akhtar
  2022-02-12 16:37   ` (subset) " Krzysztof Kozlowski
  1 sibling, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-08 17:18 UTC (permalink / raw)
  To: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Alim Akhtar, Kishon Vijay Abraham I, Vinod Koul, dri-devel,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	linux-phy
  Cc: Marek Szyprowski, Sylwester Nawrocki, stable

Add required VDD supplies to HDMI block on SMDK5420.  Without them, the
HDMI driver won't probe.  Because of lack of schematics, use same
supplies as on Arndale Octa and Odroid XU3 boards (voltage matches).

Cc: <stable@vger.kernel.org> # v3.15+
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 2978b5775a6d..4d7b6d9008a7 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -124,6 +124,9 @@ &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&hdmi_hpd_irq>;
+	vdd-supply = <&ldo6_reg>;
+	vdd_osc-supply = <&ldo7_reg>;
+	vdd_pll-supply = <&ldo6_reg>;
 };
 
 &hsi2c_4 {
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250
  2022-02-08 17:18 ` [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250 Krzysztof Kozlowski
@ 2022-02-10  3:03   ` Alim Akhtar
  2022-02-12 16:37   ` (subset) " Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-02-10  3:03 UTC (permalink / raw)
  To: 'Krzysztof Kozlowski', 'Inki Dae',
	'Joonyoung Shim', 'Seung-Woo Kim',
	'Kyungmin Park', 'David Airlie',
	'Daniel Vetter', 'Rob Herring',
	'Kishon Vijay Abraham I', 'Vinod Koul',
	dri-devel, devicetree, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, linux-phy
  Cc: 'Marek Szyprowski', 'Sylwester Nawrocki', stable



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Tuesday, February 8, 2022 10:48 PM
>To: Inki Dae <inki.dae@samsung.com>; Joonyoung Shim
><jy0922.shim@samsung.com>; Seung-Woo Kim
><sw0312.kim@samsung.com>; Kyungmin Park
><kyungmin.park@samsung.com>; David Airlie <airlied@linux.ie>; Daniel
>Vetter <daniel@ffwll.ch>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Kishon Vijay Abraham I <kishon@ti.com>;
>Vinod Koul <vkoul@kernel.org>; dri-devel@lists.freedesktop.org;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>phy@lists.infradead.org
>Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Sylwester Nawrocki
><snawrocki@kernel.org>; stable@vger.kernel.org
>Subject: [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on
>SMDK5250
>
>Add required VDD supplies to HDMI block on SMDK5250.  Without them, the
>HDMI driver won't probe.  Because of lack of schematics, use same supplies
as
>on Arndale 5250 board (voltage matches).
>
>Cc: <stable@vger.kernel.org> # v3.15+
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>index 65d2474f83eb..21fbbf3d8684 100644
>--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>@@ -118,6 +118,9 @@ &hdmi {
> 	status = "okay";
> 	ddc = <&i2c_2>;
> 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
>+	vdd-supply = <&ldo8_reg>;
>+	vdd_osc-supply = <&ldo10_reg>;
>+	vdd_pll-supply = <&ldo8_reg>;
> };

Cross checked with SMDK schematic, looks correct.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>
> &i2c_0 {
>--
>2.32.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420
  2022-02-08 17:18 ` [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420 Krzysztof Kozlowski
@ 2022-02-10  4:03   ` Alim Akhtar
  2022-02-12 16:37   ` (subset) " Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-02-10  4:03 UTC (permalink / raw)
  To: 'Krzysztof Kozlowski', 'Inki Dae',
	'Joonyoung Shim', 'Seung-Woo Kim',
	'Kyungmin Park', 'David Airlie',
	'Daniel Vetter', 'Rob Herring',
	'Kishon Vijay Abraham I', 'Vinod Koul',
	dri-devel, devicetree, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, linux-phy
  Cc: 'Marek Szyprowski', 'Sylwester Nawrocki', stable



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Tuesday, February 8, 2022 10:48 PM
>To: Inki Dae <inki.dae@samsung.com>; Joonyoung Shim
><jy0922.shim@samsung.com>; Seung-Woo Kim
><sw0312.kim@samsung.com>; Kyungmin Park
><kyungmin.park@samsung.com>; David Airlie <airlied@linux.ie>; Daniel
>Vetter <daniel@ffwll.ch>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Kishon Vijay Abraham I <kishon@ti.com>;
>Vinod Koul <vkoul@kernel.org>; dri-devel@lists.freedesktop.org;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>phy@lists.infradead.org
>Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Sylwester Nawrocki
><snawrocki@kernel.org>; stable@vger.kernel.org
>Subject: [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on
>SMDK5420
>
>Add required VDD supplies to HDMI block on SMDK5420.  Without them, the
>HDMI driver won't probe.  Because of lack of schematics, use same supplies
as
>on Arndale Octa and Odroid XU3 boards (voltage matches).
>
>Cc: <stable@vger.kernel.org> # v3.15+
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>index 2978b5775a6d..4d7b6d9008a7 100644
>--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>@@ -124,6 +124,9 @@ &hdmi {
> 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
> 	pinctrl-names = "default";
> 	pinctrl-0 = <&hdmi_hpd_irq>;
>+	vdd-supply = <&ldo6_reg>;
>+	vdd_osc-supply = <&ldo7_reg>;
>+	vdd_pll-supply = <&ldo6_reg>;
> };


Same supply found on smdk5420 as well.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>
> &hsi2c_4 {
>--
>2.32.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250
  2022-02-08 17:18 ` [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250 Krzysztof Kozlowski
  2022-02-10  3:03   ` Alim Akhtar
@ 2022-02-12 16:37   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-12 16:37 UTC (permalink / raw)
  To: linux-phy, Kishon Vijay Abraham I, linux-arm-kernel, Alim Akhtar,
	Seung-Woo Kim, linux-samsung-soc, Rob Herring, Daniel Vetter,
	dri-devel, Kyungmin Park, Vinod Koul, Krzysztof Kozlowski,
	Joonyoung Shim, David Airlie, devicetree, Inki Dae, linux-kernel
  Cc: stable, Sylwester Nawrocki, Marek Szyprowski

On Tue, 8 Feb 2022 18:18:14 +0100, Krzysztof Kozlowski wrote:
> Add required VDD supplies to HDMI block on SMDK5250.  Without them, the
> HDMI driver won't probe.  Because of lack of schematics, use same
> supplies as on Arndale 5250 board (voltage matches).
> 
> 

Applied, thanks!

[01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250
        commit: 60a9914cb2061ba612a3f14f6ad329912b486360

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420
  2022-02-08 17:18 ` [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420 Krzysztof Kozlowski
  2022-02-10  4:03   ` Alim Akhtar
@ 2022-02-12 16:37   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-12 16:37 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Joonyoung Shim, linux-arm-kernel,
	Alim Akhtar, Seung-Woo Kim, Inki Dae, linux-samsung-soc,
	Rob Herring, dri-devel, Kyungmin Park, Vinod Koul,
	Krzysztof Kozlowski, linux-kernel, David Airlie, devicetree,
	linux-phy, Daniel Vetter
  Cc: stable, Sylwester Nawrocki, Marek Szyprowski

On Tue, 8 Feb 2022 18:18:15 +0100, Krzysztof Kozlowski wrote:
> Add required VDD supplies to HDMI block on SMDK5420.  Without them, the
> HDMI driver won't probe.  Because of lack of schematics, use same
> supplies as on Arndale Octa and Odroid XU3 boards (voltage matches).
> 
> 

Applied, thanks!

[02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420
        commit: 453a24ded415f7fce0499c6b0a2c7b28f84911f2

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-12 16:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220208171823.226211-1-krzysztof.kozlowski@canonical.com>
2022-02-08 17:18 ` [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250 Krzysztof Kozlowski
2022-02-10  3:03   ` Alim Akhtar
2022-02-12 16:37   ` (subset) " Krzysztof Kozlowski
2022-02-08 17:18 ` [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420 Krzysztof Kozlowski
2022-02-10  4:03   ` Alim Akhtar
2022-02-12 16:37   ` (subset) " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).