* [PATCH -next] fbdev: savage: Handle err return when savagefb_check_var failed
@ 2024-04-16 6:51 Cai Xinchen
2024-04-25 10:05 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Cai Xinchen @ 2024-04-16 6:51 UTC (permalink / raw)
To: adaplas, deller, fullwaywang; +Cc: linux-fbdev, dri-devel, linux-kernel, stable
The commit 04e5eac8f3ab("fbdev: savage: Error out if pixclock equals zero")
checks the value of pixclock to avoid divide-by-zero error. However
the function savagefb_probe doesn't handle the error return of
savagefb_check_var. When pixclock is 0, it will cause divide-by-zero error.
Fixes: 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero")
Signed-off-by: Cai Xinchen <caixinchen1@huawei.com>
Cc: stable@vger.kernel.org
---
drivers/video/fbdev/savage/savagefb_driver.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c
index ebc9aeffdde7..ac41f8f37589 100644
--- a/drivers/video/fbdev/savage/savagefb_driver.c
+++ b/drivers/video/fbdev/savage/savagefb_driver.c
@@ -2276,7 +2276,10 @@ static int savagefb_probe(struct pci_dev *dev, const struct pci_device_id *id)
if (info->var.xres_virtual > 0x1000)
info->var.xres_virtual = 0x1000;
#endif
- savagefb_check_var(&info->var, info);
+ err = savagefb_check_var(&info->var, info);
+ if (err)
+ goto failed;
+
savagefb_set_fix(info);
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] fbdev: savage: Handle err return when savagefb_check_var failed
2024-04-16 6:51 [PATCH -next] fbdev: savage: Handle err return when savagefb_check_var failed Cai Xinchen
@ 2024-04-25 10:05 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2024-04-25 10:05 UTC (permalink / raw)
To: Cai Xinchen, adaplas, fullwaywang
Cc: linux-fbdev, dri-devel, linux-kernel, stable
On 4/16/24 08:51, Cai Xinchen wrote:
> The commit 04e5eac8f3ab("fbdev: savage: Error out if pixclock equals zero")
> checks the value of pixclock to avoid divide-by-zero error. However
> the function savagefb_probe doesn't handle the error return of
> savagefb_check_var. When pixclock is 0, it will cause divide-by-zero error.
>
> Fixes: 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero")
> Signed-off-by: Cai Xinchen <caixinchen1@huawei.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/video/fbdev/savage/savagefb_driver.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
applied.
Thanks!
Helge
>
> diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c
> index ebc9aeffdde7..ac41f8f37589 100644
> --- a/drivers/video/fbdev/savage/savagefb_driver.c
> +++ b/drivers/video/fbdev/savage/savagefb_driver.c
> @@ -2276,7 +2276,10 @@ static int savagefb_probe(struct pci_dev *dev, const struct pci_device_id *id)
> if (info->var.xres_virtual > 0x1000)
> info->var.xres_virtual = 0x1000;
> #endif
> - savagefb_check_var(&info->var, info);
> + err = savagefb_check_var(&info->var, info);
> + if (err)
> + goto failed;
> +
> savagefb_set_fix(info);
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-25 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-16 6:51 [PATCH -next] fbdev: savage: Handle err return when savagefb_check_var failed Cai Xinchen
2024-04-25 10:05 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).