From: Boris Brezillon <boris.brezillon@bootlin.com>
To: OuYang ZhiZhong <ouyzz@yealink.com>
Cc: <dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<boris.brezillon@free-electrons.com>, <marek.vasut@gmail.com>,
<richard@nod.at>, <cyrille.pitchen@wedev4u.fr>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<oyzhizhong@gmail.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v4] mtdchar: fix usage of mtd_ooblayout_ecc()
Date: Mon, 19 Mar 2018 10:30:00 +0100 [thread overview]
Message-ID: <20180319103000.2c1902f7@bbrezillon> (raw)
In-Reply-To: <1520755147-4414-1-git-send-email-ouyzz@yealink.com>
On Sun, 11 Mar 2018 15:59:07 +0800
OuYang ZhiZhong <ouyzz@yealink.com> wrote:
> Section was not properly computed. The value of OOB region definition is
> always ECC section 0 information in the OOB area, but we want to get all
> the ECC bytes information, so we should call
> mtd_ooblayout_ecc(mtd, section++, &oobregion) until it returns -ERANGE.
Applied.
Thanks,
Boris
>
> Fixes: c2b78452a9db ("mtd: use mtd_ooblayout_xxx() helpers where appropriate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: OuYang ZhiZhong <ouyzz@yealink.com>
> ---
> drivers/mtd/mtdchar.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index de8c902..7d80a8b 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -479,7 +479,7 @@ static int shrink_ecclayout(struct mtd_info *mtd,
> for (i = 0; i < MTD_MAX_ECCPOS_ENTRIES;) {
> u32 eccpos;
>
> - ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
> + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
> if (ret < 0) {
> if (ret != -ERANGE)
> return ret;
> @@ -526,7 +526,7 @@ static int get_oobinfo(struct mtd_info *mtd, struct nand_oobinfo *to)
> for (i = 0; i < ARRAY_SIZE(to->eccpos);) {
> u32 eccpos;
>
> - ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
> + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
> if (ret < 0) {
> if (ret != -ERANGE)
> return ret;
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-03-19 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 7:59 [PATCH v4] mtdchar: fix usage of mtd_ooblayout_ecc() OuYang ZhiZhong
2018-03-19 9:30 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319103000.2c1902f7@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=ouyzz@yealink.com \
--cc=oyzhizhong@gmail.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).