* [PATCH v4] mtdchar: fix usage of mtd_ooblayout_ecc()
@ 2018-03-11 7:59 OuYang ZhiZhong
2018-03-19 9:30 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: OuYang ZhiZhong @ 2018-03-11 7:59 UTC (permalink / raw)
To: dwmw2
Cc: computersforpeace, boris.brezillon, marek.vasut, richard,
cyrille.pitchen, linux-mtd, linux-kernel, oyzhizhong, ouyzz,
stable
Section was not properly computed. The value of OOB region definition is
always ECC section 0 information in the OOB area, but we want to get all
the ECC bytes information, so we should call
mtd_ooblayout_ecc(mtd, section++, &oobregion) until it returns -ERANGE.
Fixes: c2b78452a9db ("mtd: use mtd_ooblayout_xxx() helpers where appropriate")
Cc: <stable@vger.kernel.org>
Signed-off-by: OuYang ZhiZhong <ouyzz@yealink.com>
---
drivers/mtd/mtdchar.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index de8c902..7d80a8b 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -479,7 +479,7 @@ static int shrink_ecclayout(struct mtd_info *mtd,
for (i = 0; i < MTD_MAX_ECCPOS_ENTRIES;) {
u32 eccpos;
- ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
+ ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
if (ret < 0) {
if (ret != -ERANGE)
return ret;
@@ -526,7 +526,7 @@ static int get_oobinfo(struct mtd_info *mtd, struct nand_oobinfo *to)
for (i = 0; i < ARRAY_SIZE(to->eccpos);) {
u32 eccpos;
- ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
+ ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
if (ret < 0) {
if (ret != -ERANGE)
return ret;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] mtdchar: fix usage of mtd_ooblayout_ecc()
2018-03-11 7:59 [PATCH v4] mtdchar: fix usage of mtd_ooblayout_ecc() OuYang ZhiZhong
@ 2018-03-19 9:30 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-03-19 9:30 UTC (permalink / raw)
To: OuYang ZhiZhong
Cc: dwmw2, computersforpeace, boris.brezillon, marek.vasut, richard,
cyrille.pitchen, linux-mtd, linux-kernel, oyzhizhong, stable
On Sun, 11 Mar 2018 15:59:07 +0800
OuYang ZhiZhong <ouyzz@yealink.com> wrote:
> Section was not properly computed. The value of OOB region definition is
> always ECC section 0 information in the OOB area, but we want to get all
> the ECC bytes information, so we should call
> mtd_ooblayout_ecc(mtd, section++, &oobregion) until it returns -ERANGE.
Applied.
Thanks,
Boris
>
> Fixes: c2b78452a9db ("mtd: use mtd_ooblayout_xxx() helpers where appropriate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: OuYang ZhiZhong <ouyzz@yealink.com>
> ---
> drivers/mtd/mtdchar.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index de8c902..7d80a8b 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -479,7 +479,7 @@ static int shrink_ecclayout(struct mtd_info *mtd,
> for (i = 0; i < MTD_MAX_ECCPOS_ENTRIES;) {
> u32 eccpos;
>
> - ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
> + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
> if (ret < 0) {
> if (ret != -ERANGE)
> return ret;
> @@ -526,7 +526,7 @@ static int get_oobinfo(struct mtd_info *mtd, struct nand_oobinfo *to)
> for (i = 0; i < ARRAY_SIZE(to->eccpos);) {
> u32 eccpos;
>
> - ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
> + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
> if (ret < 0) {
> if (ret != -ERANGE)
> return ret;
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-11 7:59 [PATCH v4] mtdchar: fix usage of mtd_ooblayout_ecc() OuYang ZhiZhong
2018-03-19 9:30 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).