From: Greg KH <gregkh@linuxfoundation.org>
To: Alakesh Haloi <alakeshh@amazon.com>
Cc: stable@vger.kernel.org, Steve French <stfrench@microsoft.com>
Subject: Re: Request for inclusion into linux-4.14.y
Date: Thu, 24 Jan 2019 19:02:37 +0100 [thread overview]
Message-ID: <20190124180237.GE7484@kroah.com> (raw)
In-Reply-To: <20190121210512.GB72263@dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com>
On Mon, Jan 21, 2019 at 09:05:12PM +0000, Alakesh Haloi wrote:
> On Mon, Jan 21, 2019 at 08:44:48PM +0100, Greg KH wrote:
> > On Mon, Jan 21, 2019 at 07:35:43PM +0000, Alakesh Haloi wrote:
> > > Hello Greg,
> > > Can you please consider including the following patch in the stable
> > > linux-4.14.y branch? This is to fix a broken dependency for config option
> > > CONFIG_CIFS_POSIX
> > >
> > > 04f67ed3d83a ("cifs: allow disabling insecure dialects in the config")
> >
> > I do not see that commit in Linus's tree, are you sure the sha1 is
> > correct?
> >
> Apologies for pasting a wrong sha1 for the commit. Following is the commit from
> linus's tree that needs to be included to fix the dependency:
>
> 7420451f6a10 ("cifs: allow disabling insecure dialects in the config")
>
> > > Following commit introduced a dependency for CONFIG_CIFS_POSIX on the config
> > > CONFIG_CIFS_ALLOW_INSECURE_LEGACY, but the above mentioned commit that had
> > > enable CONFIG_CIFS_POSIX in 4.14.94.
> > >
> > > ab9697222a1d ("cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy
> > > (insecure cifs)")
> >
> > Was the above patch incorrectly applied? Should it just be dropped
> > instead?
> This patch that is already there in 4.14.y looks correct but it does
> have missing dependency on the patch that is requested to be included.
> The other option is to drop this patch. But I would prefer to keep the
> patch and have the dependency resolved.
Ok, now queued up, thanks.
greg k-h
prev parent reply other threads:[~2019-01-24 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 19:35 Request for inclusion into linux-4.14.y Alakesh Haloi
2019-01-21 19:44 ` Greg KH
2019-01-21 21:05 ` Alakesh Haloi
2019-01-24 18:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124180237.GE7484@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alakeshh@amazon.com \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).