[PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation

* [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
@ 2019-03-19 20:19 Janusz Krzysztofik
  2019-03-20  1:01 ` Aaro Koskinen
  0 siblings, 1 reply; 3+ messages in thread
From: Janusz Krzysztofik @ 2019-03-19 20:19 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Aaro Koskinen, linux-omap, linux-arm-kernel, linux-kernel,
	Janusz Krzysztofik, stable

In order to request dynamic allocationn of GPIO IDs, a negative number
should be passed as a base GPIO ID via platform data.  Unfortuntely,
commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
GPIO numbers") didn't follow that rule while switching to dynamically
allocated GPIO IDs for Amstrad Delta latches, making their IDs
overlapping with those already assigned to OMAP GPIO devices.  Fix it.

Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: stable@vger.kernel.org
---
 arch/arm/mach-omap1/board-ams-delta.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index be30c3c061b4..1b15d593837e 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -182,6 +182,7 @@ static struct resource latch1_resources[] = {
 
 static struct bgpio_pdata latch1_pdata = {
 	.label	= LATCH1_LABEL,
+	.base	= -1,
 	.ngpio	= LATCH1_NGPIO,
 };
 
@@ -219,6 +220,7 @@ static struct resource latch2_resources[] = {
 
 static struct bgpio_pdata latch2_pdata = {
 	.label	= LATCH2_LABEL,
+	.base	= -1,
 	.ngpio	= LATCH2_NGPIO,
 };
 
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread