stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Todd Kjos <tkjos@android.com>,
	Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Sasha Levin <Alexander.Levin@microsoft.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [stable] binder: fix race between munmap() and direct reclaim
Date: Tue, 28 May 2019 08:51:31 +0200	[thread overview]
Message-ID: <20190528065131.GA2623@kroah.com> (raw)
In-Reply-To: <1558991372.2631.10.camel@codethink.co.uk>

On Mon, May 27, 2019 at 10:09:32PM +0100, Ben Hutchings wrote:
> There are commits in the 4.14, 4.19 and 5.0 stable branches that claim
> to be backports of:
> 
> commit 26528be6720bb40bc8844e97ee73a37e530e9c5e
> Author: Todd Kjos <tkjos@android.com>
> Date:   Thu Feb 14 15:22:57 2019 -0800
> 
>     binder: fix handling of misaligned binder object
> 
> However the source changes actually match:
> 
> commit 5cec2d2e5839f9c0fec319c523a911e0a7fd299f
> Author: Todd Kjos <tkjos@android.com>
> Date:   Fri Mar 1 15:06:06 2019 -0800
> 
>     binder: fix race between munmap() and direct reclaim
> 
> So far as I can see, the former fixes a bug only introduced in 5.1 and
> the latter fixes an older bug, so the changes are correct and only the
> metadata is not.
> 
> Similar mix-ups have happened before and I'm a little disturbed that
> this keeps happening.  In any case, you may want to revert and re-apply 
> with correct metadata.

Note, these backports came directly from Todd, so he can provide more
information about them.  Todd, did something get messed up on your end
and do we need to include another patch to fix this up?

thanks,

greg k-h

  reply	other threads:[~2019-05-28  6:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 21:09 [stable] binder: fix race between munmap() and direct reclaim Ben Hutchings
2019-05-28  6:51 ` Greg Kroah-Hartman [this message]
     [not found]   ` <CAHRSSEzopAbeAv4ap9xTrC1nCbpw1ZPrEYEMZOc5W_EcLZaktQ@mail.gmail.com>
2019-05-31 20:09     ` Todd Kjos
2019-06-04 14:50       ` Greg Kroah-Hartman
2019-06-05 16:43         ` Todd Kjos
2019-06-05 17:49           ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528065131.GA2623@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Alexander.Levin@microsoft.com \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=stable@vger.kernel.org \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).