From: Todd Kjos <tkjos@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Todd Kjos <tkjos@android.com>,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
Sasha Levin <Alexander.Levin@microsoft.com>,
stable <stable@vger.kernel.org>
Subject: Re: [stable] binder: fix race between munmap() and direct reclaim
Date: Wed, 5 Jun 2019 09:43:53 -0700 [thread overview]
Message-ID: <CAHRSSEwxB0YRZd5+JAMUew3w2MKEDcf-t4ReRq-b=zTFEYgW1A@mail.gmail.com> (raw)
In-Reply-To: <20190604145037.GB5824@kroah.com>
On Tue, Jun 4, 2019 at 7:50 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, May 31, 2019 at 01:09:53PM -0700, Todd Kjos wrote:
> > Greg,
> >
> > I'm really confused. [1] was my submittal to stable for "binder: fix
> > race between munmap() and direct reclaim" which I think looks correct.
> >
> > For "binder: fix handling of misaligned binder object", I only
> > submitted to LKML [2]. But then I see [3] for 4.14 (that looks
> > incorrect as Ben pointed out).
> >
> > So the result is that fix is present in the LTS trees where it is
> > needed, but it has the wrong commit message and headline.
> >
> > I agree with Ben that the cleanest approach is to revert and apply the
> > correct version (to 4.14, 4.19, 5.0). I think the correct version is
> > the one I sent [1], but please let me know if you see something I
> > screwed up or if you need me to do something.
> >
> > [1] https://www.spinics.net/lists/stable/msg299033.html
> > [2] https://lkml.org/lkml/2019/2/14/1235
> > [3] https://lkml.org/lkml/2019/4/30/650
>
> Can you send me a patch series that fixes things up properly? I really
> don't know exactly what to do here, sorry.
Sent. 2 patches for each of 4.14, 4.19, 5.0 (1/2=revert of bad patch,
2/2 apply good patch). Code ends up the same.
-Todd
next prev parent reply other threads:[~2019-06-05 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 21:09 [stable] binder: fix race between munmap() and direct reclaim Ben Hutchings
2019-05-28 6:51 ` Greg Kroah-Hartman
[not found] ` <CAHRSSEzopAbeAv4ap9xTrC1nCbpw1ZPrEYEMZOc5W_EcLZaktQ@mail.gmail.com>
2019-05-31 20:09 ` Todd Kjos
2019-06-04 14:50 ` Greg Kroah-Hartman
2019-06-05 16:43 ` Todd Kjos [this message]
2019-06-05 17:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHRSSEwxB0YRZd5+JAMUew3w2MKEDcf-t4ReRq-b=zTFEYgW1A@mail.gmail.com' \
--to=tkjos@google.com \
--cc=Alexander.Levin@microsoft.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).