* + fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch added to -mm tree
@ 2019-05-29 21:55 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2019-05-29 21:55 UTC (permalink / raw)
To: mm-commits, stable, luto, jlu, adobriyan, john.ogness
The patch titled
Subject: fs/proc/array.c: allow reporting eip/esp for all coredumping threads
has been added to the -mm tree. Its filename is
fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: John Ogness <john.ogness@linutronix.de>
Subject: fs/proc/array.c: allow reporting eip/esp for all coredumping threads
0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in /proc/PID/stat")
stopped reporting eip/esp and fd7d56270b52 ("fs/proc: Report eip/esp in
/prod/PID/stat for coredumping") reintroduced the feature to fix a
regression with userspace core dump handlers (such as minicoredumper).
Because PF_DUMPCORE is only set for the primary thread, this didn't fix
the original problem for secondary threads. Allow reporting the eip/esp
for all threads by checking for PF_EXITING as well. This is set for all
the other threads when they are killed. coredump_wait() waits for all the
tasks to become inactive before proceeding to invoke the core the core
dumper.
Link: http://lkml.kernel.org/r/87y32p7i7a.fsf@linutronix.de
Link: http://lkml.kernel.org/r/20190522161614.628-1-jlu@pengutronix.de
Fixes: fd7d56270b526ca3 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping")
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reported-by: Jan Luebbe <jlu@pengutronix.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/proc/array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/proc/array.c~fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads
+++ a/fs/proc/array.c
@@ -462,7 +462,7 @@ static int do_task_stat(struct seq_file
* a program is not able to use ptrace(2) in that case. It is
* safe because the task has stopped executing permanently.
*/
- if (permitted && (task->flags & PF_DUMPCORE)) {
+ if (permitted && (task->flags & (PF_EXITING|PF_DUMPCORE))) {
if (try_get_task_stack(task)) {
eip = KSTK_EIP(task);
esp = KSTK_ESP(task);
_
Patches currently in -mm which might be from john.ogness@linutronix.de are
fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-29 21:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 21:55 + fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).