From: kbuild test robot <lkp@intel.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
linux-kernel@vger.kernel.org, arnd@arndb.de, dbueso@suse.de,
axboe@kernel.dk, dave@stgolabs.net, e@80x24.org,
jbaron@akamai.com, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, omar.kilani@gmail.com, tglx@linutronix.de,
stable@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask
Date: Thu, 6 Jun 2019 09:06:18 +0800 [thread overview]
Message-ID: <201906060935.dl3l1jsq%lkp@intel.com> (raw)
In-Reply-To: <20190605155833.GB25165@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]
Hi Oleg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mmotm/master]
url: https://github.com/0day-ci/linux/commits/Oleg-Nesterov/signal-simplify-set_user_sigmask-restore_user_sigmask/20190606-062512
base: git://git.cmpxchg.org/linux-mmotm.git master
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
In file included from include/linux/poll.h:12:0,
from include/linux/ring_buffer.h:7,
from include/linux/trace_events.h:6,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:86,
from kernel/signal.c:30:
kernel/signal.c: In function 'set_user_sigmask':
include/linux/uaccess.h:113:7: warning: 'kmask' may be used uninitialized in this function [-Wmaybe-uninitialized]
res = raw_copy_from_user(to, from, n);
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/signal.c:2960:12: note: 'kmask' was declared here
sigset_t *kmask;
^~~~~
kernel/signal.c: In function 'set_compat_user_sigmask':
>> kernel/signal.c:2986:6: warning: 'kmask' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (get_compat_sigset(kmask, umask))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/kmask +2986 kernel/signal.c
2975
2976 #ifdef CONFIG_COMPAT
2977 int set_compat_user_sigmask(const compat_sigset_t __user *umask,
2978 size_t sigsetsize)
2979 {
2980 sigset_t *kmask;
2981
2982 if (!umask)
2983 return 0;
2984 if (sigsetsize != sizeof(compat_sigset_t))
2985 return -EINVAL;
> 2986 if (get_compat_sigset(kmask, umask))
2987 return -EFAULT;
2988
2989 set_restore_sigmask();
2990 current->saved_sigmask = current->blocked;
2991 set_current_blocked(kmask);
2992
2993 return 0;
2994 }
2995 #endif
2996
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58396 bytes --]
next prev parent reply other threads:[~2019-06-06 1:06 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 3:21 [PATCH v2] signal: Adjust error codes according to restore_user_sigmask() Deepa Dinamani
2019-05-22 15:05 ` Oleg Nesterov
2019-05-22 15:55 ` Deepa Dinamani
2019-05-22 16:14 ` Oleg Nesterov
2019-05-22 16:33 ` Deepa Dinamani
2019-05-23 9:03 ` David Laight
2019-05-23 14:59 ` Oleg Nesterov
2019-05-23 16:18 ` David Laight
2019-05-23 16:36 ` Oleg Nesterov
2019-05-23 16:56 ` David Laight
2019-05-23 18:06 ` Deepa Dinamani
2019-05-23 20:41 ` Deepa Dinamani
2019-05-23 21:06 ` Deepa Dinamani
2019-05-24 9:58 ` David Laight
2019-05-24 14:10 ` Oleg Nesterov
2019-05-24 15:16 ` Deepa Dinamani
2019-05-24 16:33 ` Oleg Nesterov
2019-05-24 17:01 ` Deepa Dinamani
2019-05-27 15:04 ` Oleg Nesterov
2019-05-28 20:47 ` Deepa Dinamani
2019-05-29 16:57 ` Oleg Nesterov
2019-05-29 18:42 ` Deepa Dinamani
2019-05-28 9:02 ` David Laight
2019-05-28 9:12 ` David Laight
2019-05-28 11:37 ` Deepa Dinamani
2019-05-28 12:04 ` David Laight
2019-05-24 14:19 ` Oleg Nesterov
2019-05-24 14:29 ` Deepa Dinamani
2019-05-24 14:51 ` Oleg Nesterov
2019-05-24 13:29 ` Oleg Nesterov
2019-05-24 14:59 ` David Laight
2019-05-24 15:09 ` David Laight
2019-05-24 15:46 ` Oleg Nesterov
2019-05-24 15:44 ` Oleg Nesterov
2019-05-24 16:40 ` David Laight
2019-05-23 14:33 ` Oleg Nesterov
2019-05-22 22:18 ` Chris Down
2019-05-22 22:52 ` Deepa Dinamani
2019-05-29 16:11 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Oleg Nesterov
2019-05-29 16:54 ` David Laight
2019-05-29 18:50 ` Eric Wong
2019-05-30 9:34 ` David Laight
2019-05-30 13:04 ` pselect/etc semantics Eric W. Biederman
2019-05-29 16:56 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Deepa Dinamani
2019-05-29 18:26 ` Deepa Dinamani
2019-05-29 22:32 ` Arnd Bergmann
2019-05-30 1:54 ` pselect/etc semantics Eric W. Biederman
2019-05-30 18:28 ` Arnd Bergmann
2019-05-30 14:40 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Oleg Nesterov
2019-05-30 18:37 ` Arnd Bergmann
2019-05-30 13:01 ` pselect/etc semantics Eric W. Biederman
2019-05-30 15:18 ` David Laight
2019-05-30 16:13 ` Oleg Nesterov
2019-05-30 15:38 ` Eric W. Biederman
2019-05-30 15:48 ` Deepa Dinamani
2019-05-30 16:59 ` Deepa Dinamani
2019-05-30 16:08 ` Oleg Nesterov
2019-05-30 17:20 ` Eric W. Biederman
2019-05-30 16:22 ` David Laight
2019-05-30 15:57 ` Oleg Nesterov
2019-05-30 21:03 ` Eric Wong
2019-06-04 13:41 ` [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask() Oleg Nesterov
2019-06-04 15:31 ` Eric W. Biederman
2019-06-04 15:57 ` David Laight
2019-06-04 16:37 ` Arnd Bergmann
2019-06-04 18:14 ` Deepa Dinamani
2019-06-04 18:35 ` Eric Wong
2019-06-04 21:26 ` Linus Torvalds
2019-06-04 22:24 ` Eric Wong
2019-06-04 23:51 ` Eric W. Biederman
2019-06-05 9:04 ` Oleg Nesterov
2019-06-05 8:56 ` Oleg Nesterov
2019-06-05 9:02 ` David Laight
2019-06-05 9:25 ` Oleg Nesterov
2019-06-05 9:58 ` David Laight
2019-06-05 15:58 ` [PATCH -mm 0/1] signal: simplify set_user_sigmask/restore_user_sigmask Oleg Nesterov
2019-06-05 15:58 ` [PATCH -mm 1/1] " Oleg Nesterov
2019-06-06 0:14 ` kbuild test robot
2019-06-06 1:06 ` kbuild test robot [this message]
2019-06-06 7:25 ` Oleg Nesterov
2019-06-06 7:30 ` Sedat Dilek
2019-06-05 17:24 ` [PATCH -mm 0/1] " Linus Torvalds
2019-06-06 9:05 ` David Laight
2019-06-06 11:05 ` Oleg Nesterov
2019-06-06 11:29 ` David Laight
2019-06-06 12:41 ` Oleg Nesterov
2019-06-06 13:23 ` David Laight
2019-06-06 10:22 ` Oleg Nesterov
2019-06-06 11:32 ` [PATCH -mm V2 1/1] " Oleg Nesterov
2019-06-06 14:08 ` [PATCH 0/2] select: simplify the usage of restore_saved_sigmask_unless() Oleg Nesterov
2019-06-06 14:08 ` [PATCH 1/2] select: change do_poll() to return -ERESTARTNOHAND rather than -EINTR Oleg Nesterov
2019-06-07 18:05 ` Linus Torvalds
2019-06-06 14:09 ` [PATCH 2/2] select: shift restore_saved_sigmask_unless() into poll_select_copy_remaining() Oleg Nesterov
2019-06-07 21:39 ` [RFC PATCH 0/5]: Removing saved_sigmask Eric W. Biederman
2019-06-11 18:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906060935.dl3l1jsq%lkp@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=deepa.kernel@gmail.com \
--cc=e@80x24.org \
--cc=ebiederm@xmission.com \
--cc=jbaron@akamai.com \
--cc=kbuild-all@01.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=omar.kilani@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).