Re: [PATCH] MIPS: Remove superfluous check for __linux__

Re: [PATCH] MIPS: Remove superfluous check for __linux__

[Hauke Mehrtens]

Hi,

Please backport the following patch to Linux stable, OpenWrt now ships
it backported to kernel 4.14 and 4.19, but it should also work with
older kernel versions.

Upstream commit 1287533d3d95d5ad8b02773733044500b1be06bc

Hauke

On 11/16/18 5:09 PM, Sean Young wrote:
> When building BPF code using "clang -target bpf -c", clang does not
> define __linux__.
> 
> To build BPF IR decoders the include linux/lirc.h is needed which
> includes linux/types.h. Currently this workaround is needed:
> 
> https://git.linuxtv.org/v4l-utils.git/commit/?id=dd3ff81f58c4e1e6f33765dc61ad33c48ae6bb07
> 
> This check might otherwise be useful to stop users from using a non-linux
> compiler, but if you're doing that you are going to have a lot more
> trouble anyway.
> 
> Signed-off-by: Sean Young <sean@mess.org>
> ---
>  arch/mips/include/uapi/asm/sgidefs.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/arch/mips/include/uapi/asm/sgidefs.h b/arch/mips/include/uapi/asm/sgidefs.h
> index 26143e3b7c26..69c3de90c536 100644
> --- a/arch/mips/include/uapi/asm/sgidefs.h
> +++ b/arch/mips/include/uapi/asm/sgidefs.h
> @@ -11,14 +11,6 @@
>  #ifndef __ASM_SGIDEFS_H
>  #define __ASM_SGIDEFS_H
>  
> -/*
> - * Using a Linux compiler for building Linux seems logic but not to
> - * everybody.
> - */
> -#ifndef __linux__
> -#error Use a Linux compiler or give up.
> -#endif
> -
>  /*
>   * Definitions for the ISA levels
>   *
> 

Re: [PATCH] MIPS: Remove superfluous check for __linux__

[Greg KH]

On Fri, Jul 12, 2019 at 11:10:12AM +0200, Hauke Mehrtens wrote:
> Hi,
> 
> Please backport the following patch to Linux stable, OpenWrt now ships
> it backported to kernel 4.14 and 4.19, but it should also work with
> older kernel versions.
> 
> Upstream commit 1287533d3d95d5ad8b02773733044500b1be06bc

Now queued up, thanks.

greg k-h