* Re: [PATCH] mm: memcontrol: flush percpu vmevents before releasing memcg
[not found] ` <20190813143117.885bef5929813445ef39fa61@linux-foundation.org>
@ 2019-08-13 21:47 ` Roman Gushchin
0 siblings, 0 replies; only message in thread
From: Roman Gushchin @ 2019-08-13 21:47 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, Michal Hocko, Johannes Weiner, linux-kernel,
Kernel Team, stable
On Tue, Aug 13, 2019 at 02:31:17PM -0700, Andrew Morton wrote:
> On Mon, 12 Aug 2019 16:37:54 -0700 Roman Gushchin <guro@fb.com> wrote:
>
> > Similar to vmstats, percpu caching of local vmevents leads to an
> > accumulation of errors on non-leaf levels. This happens because
> > some leftovers may remain in percpu caches, so that they are
> > never propagated up by the cgroup tree and just disappear into
> > nonexistence with on releasing of the memory cgroup.
> >
> > To fix this issue let's accumulate and propagate percpu vmevents
> > values before releasing the memory cgroup similar to what we're
> > doing with vmstats.
> >
> > Since on cpu hotplug we do flush percpu vmstats anyway, we can
> > iterate only over online cpus.
> >
> > Fixes: 42a300353577 ("mm: memcontrol: fix recursive statistics correctness & scalabilty")
>
> No cc:stable?
>
Here too, cc:stable is definitely missing. Adding now. Thanks!
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-13 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190812233754.2570543-1-guro@fb.com>
[not found] ` <20190813143117.885bef5929813445ef39fa61@linux-foundation.org>
2019-08-13 21:47 ` [PATCH] mm: memcontrol: flush percpu vmevents before releasing memcg Roman Gushchin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).