Stable Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] ALSA: hda - Let all conexant codec enter D3 when rebooting
@ 2019-08-14  4:09 Hui Wang
  2019-08-14  4:09 ` [PATCH 2/2] ALSA: hda - Add a generic reboot_notify Hui Wang
  2019-08-14  6:39 ` [PATCH 1/2] ALSA: hda - Let all conexant codec enter D3 when rebooting Takashi Iwai
  0 siblings, 2 replies; 4+ messages in thread
From: Hui Wang @ 2019-08-14  4:09 UTC (permalink / raw)
  To: alsa-devel, tiwai; +Cc: stable

We have 3 new lenovo laptops which have conexant codec 0x14f11f86,
these 3 laptops also have the noise issue when rebooting, after
letting the codec enter D3 before rebooting or poweroff, the noise
disappers.

Instead of adding a new ID again in the reboot_notify(), let us make
this function apply to all conexant codec. In theory make codec enter
D3 before rebooting or poweroff is harmless, and I tested this change
on a couple of other Lenovo laptops which have different conexant
codecs, there is no side effect so far.

Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_conexant.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index f299f137eaea..93a303676aea 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -163,15 +163,6 @@ static void cx_auto_reboot_notify(struct hda_codec *codec)
 {
 	struct conexant_spec *spec = codec->spec;
 
-	switch (codec->core.vendor_id) {
-	case 0x14f12008: /* CX8200 */
-	case 0x14f150f2: /* CX20722 */
-	case 0x14f150f4: /* CX20724 */
-		break;
-	default:
-		return;
-	}
-
 	/* Turn the problematic codec into D3 to avoid spurious noises
 	   from the internal speaker during (and after) reboot */
 	cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14  4:09 [PATCH 1/2] ALSA: hda - Let all conexant codec enter D3 when rebooting Hui Wang
2019-08-14  4:09 ` [PATCH 2/2] ALSA: hda - Add a generic reboot_notify Hui Wang
2019-08-14  6:39   ` Takashi Iwai
2019-08-14  6:39 ` [PATCH 1/2] ALSA: hda - Let all conexant codec enter D3 when rebooting Takashi Iwai

Stable Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://lore.kernel.org/stable \
		stable@vger.kernel.org
	public-inbox-index stable

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git