stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: revert: ASoC: Fail card instantiation if DAI format setup fails
Date: Fri, 6 Sep 2019 14:29:17 -0400	[thread overview]
Message-ID: <20190906182917.GA1528@sasha-vm> (raw)
In-Reply-To: <alpine.DEB.2.20.1909061658580.3985@lnxricardw1.se.axis.com>

On Fri, Sep 06, 2019 at 05:00:28PM +0200, Ricard Wanderlof wrote:
>
>Sorry for the repost, I relized I stupidly got Greg's email adress wrong
>first time around.
>
>> > On Tue, Aug 27, 2019 at 12:00:14PM +0100, Mark Brown wrote:
>> > > On Sun, Aug 25, 2019 at 09:35:15PM -0400, Sasha Levin wrote:
>> > > > On Wed, Aug 14, 2019 at 10:22:13AM +0100, Mark Brown wrote:
>> > >
>> > > > > > If the DAI format setup fails, there is no valid communication format
>> > > > > > between CPU and CODEC, so fail card instantiation, rather than
>> > > > continue
>> > > > > > with a card that will most likely not function properly.
>> > >
>> > > > > This is another one where if nobody noticed a problem already and things
>> > > > > just happened to be working this might break things, it's vanishingly
>> > > > > unlikely to fix anything that was broken.
>> > >
>> > > > Same as the other patch: this patch suggests it fixes a real bug, and if
>> > > > this patch is broken let's fix it.
>> > >
>> > > If anyone ran into this on the older kernel and fixed or worked
>> > > around it locally there's a reasonable chance this will then
>> > > break what they're doing.  The patch itself is perfectly fine but
>
>(Sorry about the mangled subject line, I'd accidentally deleted the
>original message from my inbox.)
>
>I'm a bit bewildered here. As the author of the original patch I'm of
>course biased, and I can certainly understand the patch being dropped from
>existing release branches, since as Mark correctly states, it does not fix
>any broken behavior and might even break things that happen to work by
>chance.
>
>But is this being dropped from the master branch as well? To me it makes
>the kernel behave in an inconsistent way, first reporting a failure to
>instantiate a specific sound card in the kernel log, but then seemingly
>bringing it up anyway.

Hi Richard,

This patch is only dropped from the stable branches, it still remains in
the mainline branch.

--
Thanks,
Sasha

  reply	other threads:[~2019-09-06 18:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 15:00 revert: ASoC: Fail card instantiation if DAI format setup fails Ricard Wanderlof
2019-09-06 18:29 ` Sasha Levin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-08-14  2:08 [PATCH AUTOSEL 5.2 001/123] ASoC: simple_card_utils.h: care NULL dai at asoc_simple_debug_dai() Sasha Levin
2019-08-14  2:09 ` [PATCH AUTOSEL 5.2 040/123] ASoC: Fail card instantiation if DAI format setup fails Sasha Levin
2019-08-14  9:22   ` Mark Brown
2019-08-26  1:35     ` Sasha Levin
2019-08-27 11:00       ` Mark Brown
2019-08-28  2:13         ` Sasha Levin
2019-08-28  7:07           ` Ricard Wanderlof
2019-09-06  8:40             ` revert: " Ricard Wanderlof
2019-09-06 10:58               ` Mark Brown
2019-09-06 18:38                 ` Sasha Levin
2019-09-09  9:35                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906182917.GA1528@sasha-vm \
    --to=sashal@kernel.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricard.wanderlof@axis.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).