Re: Patch "ALSA: pcm: Return 0 when size < start_threshold in capture" has been added to the 4.19-stable tree

Re: Patch "ALSA: pcm: Return 0 when size < start_threshold in capture" has been added to the 4.19-stable tree

[Ricardo Biehl Pasquali]

On Wed, Sep 11, 2019 at 05:30:33AM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     ALSA: pcm: Return 0 when size < start_threshold in capture
> 
> to the 4.19-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      alsa-pcm-return-0-when-size-start_threshold-in-captu.patch
> and it can be found in the queue-4.19 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

Hi Sasha.

This patch was reverted by the commit 932a81519572156a88db
("ALSA: pcm: Comment why read blocks when PCM is not
running"):

  This avoids bringing back the problem introduced by
  62ba568f7aef ("ALSA: pcm: Return 0 when size <
  start_threshold in capture") and fixed in 00a399cad1a0
  ("ALSA: pcm: Revert capture stream behavior change in
  blocking mode"), which prevented the user from starting
  capture from another thread.

Should this be queued anyway? If yes, I think it should also
be queued the fix and the commit above.

	pasquali

Re: Patch "ALSA: pcm: Return 0 when size < start_threshold in capture" has been added to the 4.19-stable tree

[Ricardo Biehl Pasquali]

On Wed, Sep 11, 2019 at 11:14:31AM -0300, Ricardo Biehl Pasquali wrote:
> This patch was reverted by the commit 932a81519572156a88db
> ("ALSA: pcm: Comment why read blocks when PCM is not
> running"):

Sorry. It was reverted by 00a399cad1a0 ("ALSA: pcm: Revert
capture stream behavior change in blocking mode"). The
commit I mentioned just add a comment as described below:

> 
>   This avoids bringing back the problem introduced by
>   62ba568f7aef ("ALSA: pcm: Return 0 when size <
>   start_threshold in capture") and fixed in 00a399cad1a0
>   ("ALSA: pcm: Revert capture stream behavior change in
>   blocking mode"), which prevented the user from starting
>   capture from another thread.

Re: Patch "ALSA: pcm: Return 0 when size < start_threshold in capture" has been added to the 4.19-stable tree

[Sasha Levin]

On Wed, Sep 11, 2019 at 11:14:31AM -0300, Ricardo Biehl Pasquali wrote:
>On Wed, Sep 11, 2019 at 05:30:33AM -0400, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>     ALSA: pcm: Return 0 when size < start_threshold in capture
>>
>> to the 4.19-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      alsa-pcm-return-0-when-size-start_threshold-in-captu.patch
>> and it can be found in the queue-4.19 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>
>Hi Sasha.
>
>This patch was reverted by the commit 932a81519572156a88db
>("ALSA: pcm: Comment why read blocks when PCM is not
>running"):
>
>  This avoids bringing back the problem introduced by
>  62ba568f7aef ("ALSA: pcm: Return 0 when size <
>  start_threshold in capture") and fixed in 00a399cad1a0
>  ("ALSA: pcm: Revert capture stream behavior change in
>  blocking mode"), which prevented the user from starting
>  capture from another thread.
>
>Should this be queued anyway? If yes, I think it should also
>be queued the fix and the commit above.

Nope, I'll drop it. Thank you.

--
Thanks,
Sasha