stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
       [not found] ` <442718702.90376810.1572939552776.JavaMail.zimbra@kalray.eu>
@ 2019-11-05 15:31   ` Christoph Hellwig
  2019-11-06  0:08     ` Sasha Levin
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-11-05 15:31 UTC (permalink / raw)
  To: Marta Rybczynska
  Cc: Charles Machalow, linux-nvme, kbusch, axboe, Christoph Hellwig,
	Sagi Grimberg, linux-kernel, Sasha Levin, Greg Kroah-Hartman,
	stable

On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
> Looks good to me. However, please note that the new ioctl made it already to 5.3.8.

It wasn't in 5.3, but it seems like you are right and it somehow got
picked for the stable releases.

Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
in 5.3-stable ASAP and make sure crap like backporting new ABIs that
haven't seen a release yet is never ever going to happen again?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
  2019-11-05 15:31   ` [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd Christoph Hellwig
@ 2019-11-06  0:08     ` Sasha Levin
  2019-11-06  0:18       ` Keith Busch
  2019-11-06  1:09       ` Christoph Hellwig
  0 siblings, 2 replies; 4+ messages in thread
From: Sasha Levin @ 2019-11-06  0:08 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Marta Rybczynska, Charles Machalow, linux-nvme, kbusch, axboe,
	Sagi Grimberg, linux-kernel, Greg Kroah-Hartman, stable

On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote:
>On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
>> Looks good to me. However, please note that the new ioctl made it already to 5.3.8.
>
>It wasn't in 5.3, but it seems like you are right and it somehow got
>picked for the stable releases.
>
>Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
>in 5.3-stable ASAP and make sure crap like backporting new ABIs that
>haven't seen a release yet is never ever going to happen again?

Sure, I'll revert it. I guess I wasn't expecting to see something like
this in a -rc release. How did it make it into one if it's not a fix?

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
  2019-11-06  0:08     ` Sasha Levin
@ 2019-11-06  0:18       ` Keith Busch
  2019-11-06  1:09       ` Christoph Hellwig
  1 sibling, 0 replies; 4+ messages in thread
From: Keith Busch @ 2019-11-06  0:18 UTC (permalink / raw)
  To: Sasha Levin
  Cc: Christoph Hellwig, Marta Rybczynska, Charles Machalow,
	linux-nvme, axboe, Sagi Grimberg, linux-kernel,
	Greg Kroah-Hartman, stable

On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote:
> On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote:
> > On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
> > > Looks good to me. However, please note that the new ioctl made it already to 5.3.8.
> > 
> > It wasn't in 5.3, but it seems like you are right and it somehow got
> > picked for the stable releases.
> > 
> > Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
> > in 5.3-stable ASAP and make sure crap like backporting new ABIs that
> > haven't seen a release yet is never ever going to happen again?
> 
> Sure, I'll revert it. I guess I wasn't expecting to see something like
> this in a -rc release. How did it make it into one if it's not a fix?

It is a fix, but it wasn't marked as such in the original changelog.
I've adjusted it for the pull request, currently staged here:

  https://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=0d6eeb1fd625272bd60d25f2d5e116cf582fc7dc

Still, a new ioctl seems pretty aggressive for stable bot, yeah?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
  2019-11-06  0:08     ` Sasha Levin
  2019-11-06  0:18       ` Keith Busch
@ 2019-11-06  1:09       ` Christoph Hellwig
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2019-11-06  1:09 UTC (permalink / raw)
  To: Sasha Levin
  Cc: Christoph Hellwig, Marta Rybczynska, Charles Machalow,
	linux-nvme, kbusch, axboe, Sagi Grimberg, linux-kernel,
	Greg Kroah-Hartman, stable

On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote:
> On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote:
>> On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
>>> Looks good to me. However, please note that the new ioctl made it already to 5.3.8.
>>
>> It wasn't in 5.3, but it seems like you are right and it somehow got
>> picked for the stable releases.
>>
>> Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
>> in 5.3-stable ASAP and make sure crap like backporting new ABIs that
>> haven't seen a release yet is never ever going to happen again?
>
> Sure, I'll revert it. I guess I wasn't expecting to see something like
> this in a -rc release. How did it make it into one if it's not a fix?

76d609da9ed1cc0dc780e2b539d7b827ce28f182 is a backport of
65e68edce0db433aa0c2b26d7dc14fbbbeb89fbb, which went into 5.4-rc2 and
was not marked for stable.  It might kinda bend the normal merge
window rules a little, but I don't see how it could be considered
something to backport.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-11-06  1:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191105061510.22233-1-csm10495@gmail.com>
     [not found] ` <442718702.90376810.1572939552776.JavaMail.zimbra@kalray.eu>
2019-11-05 15:31   ` [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd Christoph Hellwig
2019-11-06  0:08     ` Sasha Levin
2019-11-06  0:18       ` Keith Busch
2019-11-06  1:09       ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).